Re: [PATCH 10/15] pcmcia: introduce autoconfiguration feature

2010-09-03 Thread Gustavo F. Padovan
* Dominik Brodowski [2010-09-03 12:57:09 +0200]: > Introduce an autoconfiguration feature to set certain values in > pcmcia_loop_config(), instead of copying the same code over and over > in each PCMCIA driver. At first, introduce the following options: > > CONF_AUTO_CHECK_VCC check or matchin

Re: [PATCH 06/15] pcmcia: simplify IntType

2010-09-03 Thread Gustavo F. Padovan
* Dominik Brodowski [2010-09-03 12:57:05 +0200]: > IntType was only set to INT_MEMORY (driver pcmciamtd) or INT_MEMORY_AND_IO > (all other drivers). As this flags seems to relate to ioport access, make > it conditional to the driver having requested IO port access. There are two > drivers which d

Re: [PATCH 08/15] pcmcia: convert pcmcia_request_configuration to pcmcia_enable_device

2010-09-03 Thread Gustavo F. Padovan
* Dominik Brodowski [2010-09-03 12:57:07 +0200]: > pcmcia_enable_device() now replaces pcmcia_request_configuration(). > Instead of config_req_t, all necessary flags are either passed as > a parameter to pcmcia_enable_device(), or (in rare circumstances) > set in struct pcmcia_device -> flags. >

Re: [PATCH 03/15] pcmcia: move Vpp setup to struct pcmcia_device

2010-09-03 Thread Gustavo F. Padovan
* Dominik Brodowski [2010-09-03 12:57:02 +0200]: > Some drivers prefer to explicitly set Vpp. Instead of passing the > voltage inside config_req_t, store it in struct pcmcia_device. > > CC: linux-...@vger.kernel.org > CC: net...@vger.kernel.org > CC: linux-blueto...@vger.kernel.org > CC: linux-.

Re: [PATCH 07/15] pcmcia: move config_{base,index,regs} to struct pcmcia_device

2010-09-03 Thread Gustavo F. Padovan
* Dominik Brodowski [2010-09-03 12:57:06 +0200]: > Several drivers prefer to explicitly set config_{base,index,regs}, > formerly known as ConfigBase, ConfigIndex and Present. Instead of > passing these values inside config_req_t, store it in struct > pcmcia_device. > > CC: net...@vger.kernel.org

[PATCH 01/15] pcmcia: do not use win_req_t when calling pcmcia_request_window()

2010-09-03 Thread Dominik Brodowski
Instead of win_req_t, drivers are now requested to fill out struct pcmcia_device *p_dev->resource[2,3,4,5] for up to four iomem ranges. After a call to pcmcia_request_window(), the windows found there are reserved and may be used until pcmcia_release_window() is called. CC: net...@vger.kernel.org

[PATCH 05/15] pcmcia: simplify Status, ExtStatus register access

2010-09-03 Thread Dominik Brodowski
The Status (CISREG_CCSR) and ExtStatus (CISREG_ESR) registers were only accessed to enable audio output for some drivers and IRQ for serial_cs.c. The former also required setting config_req_t.Attributes to CONF_ENABLE_SPKR; the latter can be simplified to setting this field to CONF_ENABLE_ESR. CC:

[PATCH 09/15] pcmcia: Documentation update

2010-09-03 Thread Dominik Brodowski
Fill in missing descriptions and update some others for functions in pcmcia_resource.c. Signed-off-by: Dominik Brodowski --- drivers/pcmcia/pcmcia_resource.c | 93 +- 1 files changed, 71 insertions(+), 22 deletions(-) diff --git a/drivers/pcmcia/pcmcia_reso

[RFC] PCMCIA patches for 2.6.37-rc1

2010-09-03 Thread Dominik Brodowski
Hey, here's my usual patch series with PCMCIA clenaup patches intended for submission after 2.6.36 is released. The patches will be sent to the PCMCIA list shortly, with CC to other lists if deemed appropriate. Also, they can be found in the "pcmcia-test" branch at git://git.kernel.org/pub/scm/li

[PATCH 06/15] pcmcia: simplify IntType

2010-09-03 Thread Dominik Brodowski
IntType was only set to INT_MEMORY (driver pcmciamtd) or INT_MEMORY_AND_IO (all other drivers). As this flags seems to relate to ioport access, make it conditional to the driver having requested IO port access. There are two drivers which do not request IO ports, but did set INT_MEMORY_AND_IO: ray_

[PATCH 03/15] pcmcia: move Vpp setup to struct pcmcia_device

2010-09-03 Thread Dominik Brodowski
Some drivers prefer to explicitly set Vpp. Instead of passing the voltage inside config_req_t, store it in struct pcmcia_device. CC: linux-...@vger.kernel.org CC: net...@vger.kernel.org CC: linux-blueto...@vger.kernel.org CC: linux-...@lists.infradead.org CC: linux-wirel...@vger.kernel.org CC: lin

[PATCH 10/15] pcmcia: introduce autoconfiguration feature

2010-09-03 Thread Dominik Brodowski
Introduce an autoconfiguration feature to set certain values in pcmcia_loop_config(), instead of copying the same code over and over in each PCMCIA driver. At first, introduce the following options: CONF_AUTO_CHECK_VCC check or matching Vcc entry CONF_AUTO_SET_VPP set Vpp CONF_AUTO_AUDIO

[PATCH 04/15] pcmcia: remove Pin, Copy configuration register access

2010-09-03 Thread Dominik Brodowski
The "Pin" and "Copy" configuration registers (CISREG_SCR, CISREG_PPR) do not seem to be utilized anywhere. If a device would request a write to these registers, "0" would be written. Continue to do so, but warn of unexpected behavior -- and remove the "Pin" and "Copy" entries from config_req_t. Si

[PATCH 02/15] pcmcia: split up modify_configuration() into two fixup functions

2010-09-03 Thread Dominik Brodowski
pcmcia_modify_configuration() was only used by two drivers to fix up one issue each: setting the Vpp to a different value, and reducing the IO width to 8 bit. Introduce two explicitly named functions handling these things, and remove one further typedef. CC: net...@vger.kernel.org CC: linux-...@li

[PATCH 13/15] pcmcia: move driver name to struct pcmcia_driver

2010-09-03 Thread Dominik Brodowski
Signed-off-by: Dominik Brodowski --- drivers/ata/pata_pcmcia.c|4 +--- drivers/bluetooth/bluecard_cs.c |4 +--- drivers/bluetooth/bt3c_cs.c |4 +--- drivers/bluetooth/btuart_cs.c|4 +--- drivers/blue

[PATCH 07/15] pcmcia: move config_{base, index, regs} to struct pcmcia_device

2010-09-03 Thread Dominik Brodowski
Several drivers prefer to explicitly set config_{base,index,regs}, formerly known as ConfigBase, ConfigIndex and Present. Instead of passing these values inside config_req_t, store it in struct pcmcia_device. CC: net...@vger.kernel.org CC: linux-wirel...@vger.kernel.org CC: linux-...@vger.kernel.o

[PATCH 14/15] pcmcia: avoid messages on module (un)loading

2010-09-03 Thread Dominik Brodowski
printk() statements on module load or unload are frowned upon. Also, add a few __init or __exit declarations. Signed-off-by: Dominik Brodowski --- drivers/char/pcmcia/cm4000_cs.c|3 --- drivers/char/pcmcia/cm4040_cs.c|2 -- drivers/char/pcmcia/ipwireless/main.c

[PATCH 12/15] pcmcia: remove the "Finally, report what we've done" message

2010-09-03 Thread Dominik Brodowski
Remove this unnecessary message -- this info is either available in sysfs or by enabling dynamic debug from the PCMCIA core. CC: net...@vger.kernel.org CC: linux-wirel...@vger.kernel.org CC: linux-s...@vger.kernel.org CC: linux-...@vger.kernel.org Signed-off-by: Dominik Brodowski --- drivers/cha