Re: [PATCH v2 08/16] PCI: Stop and remove devices in one pass

2012-08-20 Thread Yinghai Lu
On Mon, Aug 20, 2012 at 8:27 AM, Bjorn Helgaas wrote: > On Fri, Aug 17, 2012 at 7:21 PM, Yinghai Lu wrote: >> On Fri, Aug 17, 2012 at 4:36 PM, Bjorn Helgaas wrote: >>> Previously, when we removed a PCI device, we made two passes over the >>> hierarchy rooted at the device. In the first pass, we

Re: [PATCH v2 00/16] Clean up drivers/pci/remove.c

2012-08-20 Thread Yijing Wang
On 2012/8/20 23:40, Bjorn Helgaas wrote: > On Sun, Aug 19, 2012 at 10:58 PM, Yijing Wang wrote: >> tested-by Yijing Wang > > Great, thanks for trying this out! Can you give me any details on > what you tested (what sort of machine, which hotplug driver, PCIe > button/LED style hotplug or Expres

Re: [PATCH v2 00/16] Clean up drivers/pci/remove.c

2012-08-20 Thread Bjorn Helgaas
On Sun, Aug 19, 2012 at 10:58 PM, Yijing Wang wrote: > tested-by Yijing Wang Great, thanks for trying this out! Can you give me any details on what you tested (what sort of machine, which hotplug driver, PCIe button/LED style hotplug or ExpressCard style, etc?) >> This started as a simple conv

Re: [PATCH v2 08/16] PCI: Stop and remove devices in one pass

2012-08-20 Thread Bjorn Helgaas
On Fri, Aug 17, 2012 at 7:21 PM, Yinghai Lu wrote: > On Fri, Aug 17, 2012 at 4:36 PM, Bjorn Helgaas wrote: >> Previously, when we removed a PCI device, we made two passes over the >> hierarchy rooted at the device. In the first pass, we stopped all >> the devices, and in the second, we removed t

Re: [PATCH v2 03/16] pcmcia: Use common pci_stop_and_remove_bus_device()

2012-08-20 Thread Bjorn Helgaas
On Fri, Aug 17, 2012 at 5:58 PM, Yinghai Lu wrote: > On Fri, Aug 17, 2012 at 4:36 PM, Bjorn Helgaas wrote: >> Use pci_stop_and_remove_bus_device() like most other hotplug drivers >> rather than the special-purpose "behind_bridge" variant. This just >> means we have to iterate through all the dev