Re: [PATCH v2 3/3] tools: move pcmcia crc32hash tool from Documentation

2016-09-22 Thread Dominik Brodowski
el directory or from pcmcia directory: > > Run make -C tools/pcmcia or cd tools/pcmcia; make > > Signed-off-by: Shuah Khan <shua...@osg.samsung.com> Acked-by: Dominik Brodowski <li...@dominikbrodowski.net> signature.asc Description: Digital signature _

Re: [PATCH 27/43] MAINTAINERS: update git URL for PCMCIA

2015-12-19 Thread Dominik Brodowski
On Fri, Dec 18, 2015 at 03:51:50PM +0800, Fengguang Wu wrote: > CC: linux-pcmcia@lists.infradead.org > CC: Dominik Brodowski <li...@dominikbrodowski.net> > Signed-off-by: Fengguang Wu <fengguang...@intel.com> Acked-by: Dominik Brodowski <li...@dominikbrodowski.net&g

[git pull] PCMCIA changes for v4.2

2015-06-22 Thread Dominik Brodowski
that location. The diffstat and list of changes is below, the individual diffs are sent (at least) to the linux-pcmcia list. Dominik Brodowski (1): pcmcia: do not break rsrc_nonstatic when handling anonymous cards Himangi Saraogi

[PATCH 05/12] drivers: pcmcia: electra_cf.c fix checkpatch error and warnings

2015-06-22 Thread Dominik Brodowski
Signed-off-by: Laurent Navet laurent.na...@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/electra_cf.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia/electra_cf.c index 6a1bc8e

[PATCH 03/12] PCMCIA: Remove commented references to dead class_device_create_file()

2015-06-22 Thread Dominik Brodowski
From: Robert P. J. Day rpj...@crashcourse.ca Since this routine doesn't even exist anymore, there's no point leaving in commented code using it. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/i82365.c | 7

[PATCH 06/12] pcmcia: Remove typedef tuple_flags

2015-06-22 Thread Dominik Brodowski
struct i { ... } -td ; @@ type tn.td; identifier tn.i; @@ -td + struct i Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/cistpl.c | 12 ++-- 1 file changed, 6

[PATCH 01/12] pcmcia: replace open-coded ARRAY_SIZE with macro

2015-06-22 Thread Dominik Brodowski
From: Jim Cromie jim.cro...@gmail.com Signed-off-by: Jim Cromie jim.cro...@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/i82365.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pcmcia/i82365.c b/drivers/pcmcia/i82365.c index

[PATCH 04/12] drivers: pcmcia: ds.c fix checkpatch errors

2015-06-22 Thread Dominik Brodowski
From: Laurent Navet laurent.na...@gmail.com fix these checkpatch errors : - ERROR: spaces required around that '' (ctx:VxW) - ERROR: foo * bar should be foo *bar - WARNING: please, no space before tabs Signed-off-by: Laurent Navet laurent.na...@gmail.com Signed-off-by: Dominik Brodowski li

[PATCH 02/12] drivers/pcmcia/electra_cf.c: add missing iounmap and kfree

2015-06-22 Thread Dominik Brodowski
julia.law...@lip6.fr Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/electra_cf.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pcmcia/electra_cf.c b/drivers/pcmcia

[PATCH 10/12] Disable write buffering on Toshiba ToPIC95

2015-06-22 Thread Dominik Brodowski
...@icequake.net Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/topic.h | 16 1 file changed, 16 insertions(+) diff --git a/drivers/pcmcia/topic.h b/drivers/pcmcia/topic.h index 615a45a..582688fe 100644 --- a/drivers/pcmcia/topic.h +++ b/drivers/pcmcia/topic.h

[PATCH 08/12] pcmcia/vrc4171: Remove typedefs for enums and struct

2015-06-22 Thread Dominik Brodowski
Acked-by: Julia Lawall julia.law...@lip6.fr Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/vrc4171_card.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/pcmcia/vrc4171_card.c b/drivers/pcmcia/vrc4171_card.c

[PATCH 12/12] pcmcia: do not break rsrc_nonstatic when handling anonymous cards

2015-06-22 Thread Dominik Brodowski
. To fix this issue, move the override for anonymous cards to the one place where it is needed -- when adding a PCMCIA device. Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/cistpl.c | 28 +--- drivers/pcmcia/ds.c | 20

Re: [PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Dominik Brodowski
Hi Takeshi, On Sun, Jun 14, 2015 at 09:14:41PM +0900, Takeshi Yoshimura wrote: In yenta_probe(), an irq leak potentially happens when pcmcia_register_socket() fails. I added the missed call. nice catch, many thanks. index 965bd84..7922e30f 100644 --- a/drivers/pcmcia/yenta_socket.c +++

Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close()

2015-06-14 Thread Dominik Brodowski
On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote: There are some resource leaks in yenta_probe() and _close(). I fixed the following issues with some code cleanups. Thanks to Dominik's suggestions. On the error path in yenta_probe(): - a requested irq is not released -

Re: [PATCH] Disable write buffering on Toshiba ToPIC95

2015-05-31 Thread Dominik Brodowski
Ryan, thanks for this patch. Could you add a Signed-off-by line as specified in Documentation/SubmittingPatches, please, so that I can pick it up and push it upstream? Thanks! Dominik On Sun, Jan 25, 2015 at 04:07:09PM -0800, Ryan C. Underwood wrote: From: Ryan Underwood

Re: old Xircom CEM33 doesn't work on kernel 3.2.1 (Gentoo-r2)

2012-06-05 Thread Dominik Brodowski
Hi Michael, On Sun, Jun 03, 2012 at 02:14:09AM +0200, Michael Feichtgraber wrote: Hi, i tried to setup an (very) old notebook (P3) with a CEM33 pcmcia card, just for experimental, net-setup was ok, ifconfig showed appropriated eth0 but dmesg wrote this to stdout: xirc2ps_cs 1.0 :

[git pull] PCMCIA updates for 3.4

2012-03-25 Thread Dominik Brodowski
Linus, a few PCMCIA updates for 3.4 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia.git master Please pull from that location. The diffstat and list of changes is below, the individual diffs are sent (at least) to the linux-pcmcia list.

[PATCH 3/5] pcmcia: Convert to DEFINE_PCI_DEVICE_TABLE

2012-03-25 Thread Dominik Brodowski
From: Axel Lin axel@gmail.com Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE tables. Also convert to use PCI_DEVICE macro for better readablity. Signed-off-by: Axel Lin axel@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers

[PATCH 1/5] pcmcia: irq: Remove IRQF_DISABLED

2012-03-25 Thread Dominik Brodowski
handler enables interrupts]). So now this flag is a NOOP and can be removed. Signed-off-by: Yong Zhang yong.zha...@gmail.com Acked-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/db1xxx_ss.c |4 ++-- drivers/pcmcia

[PATCH 5/5] pcmcia at91_cf: fix raw gpio number usage

2012-03-25 Thread Dominik Brodowski
gpio and irq numbers. This is no longer true after d0fbda9add3281. Tested on custom RM9200 board with 8gb CF card. Signed-off-by: Joachim Eastwood joachim.eastw...@jotron.com Acked-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Signed-off-by: Dominik Brodowski li

[PATCH 4/5] ARM: pxa: fix error handling in pxa2xx_drv_pcmcia_probe

2012-03-25 Thread Dominik Brodowski
@gmail.com Acked-by: Eric Miao eric.y.m...@gmail.com Acked-by: Marek Vasut marek.va...@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pxa2xx_base.c | 12 +++- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/pcmcia/pxa2xx_base.c b

[PATCH 2/5] pcmcia: convert drivers/pcmcia/* to use module_platform_driver()

2012-03-25 Thread Dominik Brodowski
...@lixom.net Acked-by: Michael Hennerich michael.henner...@analog.com Acked-by: Marc Zyngier m...@misterjones.org [for the viper part] Acked-by: Manuel Lauss manuel.la...@googlemail.com [for the db1xxx_ss.c part] Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia

Re: [PATCH] Makefile: don't hardcode the path to 'install'

2012-03-25 Thread Dominik Brodowski
Applied, thanks. On Wed, Mar 14, 2012 at 02:06:26PM +0100, Tom Gundersen wrote: In Arch Linux we currently use /bin/install rather than /usr/bin/install. This change work with both locations and avoids us having to change the Makefile. Cc: Dominik Brodowski li...@dominikbrodowski.net

Re: [PATCH] udev: behave like 80-drivers.rules

2012-03-25 Thread Dominik Brodowski
On Sun, Mar 25, 2012 at 09:28:06PM +0200, Tom Gundersen wrote: On Sun, Mar 25, 2012 at 8:55 PM, Dominik Brodowski li...@dominikbrodowski.net wrote: On Wed, Mar 14, 2012 at 06:12:25PM +0100, Tom Gundersen wrote:  1) Apply the rules also to 'change' events. This should do no harm

Re: pcmciautils.git

2012-03-17 Thread Dominik Brodowski
Hi, On Sat, Mar 17, 2012 at 11:03:36AM +0900, Komuro wrote: I stil can't find the http://kernel.org/pub/linux/utils/kernel/pcmcia/pcmcia.html this is in the process of being restored. The git tree is temporarily available at

Re: [yenta_cardbus: no PCI interrupts][=linux-3.1.6][Bug?]

2012-02-26 Thread Dominik Brodowski
CC'ing linuc-pci for the IRQ stuff -- there were no changes in the PCMCIA code in this period (at least none I'm aware of) Could you send the dmesg and lspci output of the following runs, please: - linux-2.6.37-r4 - dmesg-1, lspci-1 - reboot into a new kernel (which should work now, if I

Re: pcmciautils.git

2012-02-11 Thread Dominik Brodowski
On Sat, Feb 11, 2012 at 09:34:12AM +0900, Komuro wrote: Hi, Currently, I can't find git://git.kernel.org/pub/scm/linux/pcmcia/pcmciautils.git/ and Linux Kernel 2.6 PCMCIA site. We're in the process of restoring this stuff. As my GPG keys aren't closely connected to the kernel.org team,

Re: [PATCH] pcmcia at91_cf: fix raw gpio number usage

2012-02-05 Thread Dominik Brodowski
On Tue, Jan 10, 2012 at 02:37:25AM +0100, manab...@gmail.com wrote: From: Joachim Eastwood joachim.eastw...@jotron.com This patches fixes two things: * Use gpio_valid function to check gpio before usage This must be done after 63b4c29678500 which uses -EINVAL for unused pin's * Use

Re: [PATCH] pcmcia: convert drivers/pcmcia/* to use module_platform_driver()

2012-02-05 Thread Dominik Brodowski
On Sun, Nov 27, 2011 at 12:53:06PM +0800, Axel Lin wrote: This patch converts the drivers in drivers/pcmcia/* to use the module_platform_driver() macro which makes the code smaller and a bit simpler. Cc: Michael Hennerich henner...@blackfin.uclinux.org Cc: Manuel Lauss

Re: [PATCH,FIXED] PCMCIA card inserted, five s2ram cycles, you're dead

2012-02-05 Thread Dominik Brodowski
On Sun, Jan 22, 2012 at 09:12:48AM +, Russell King - ARM Linux wrote: Unfortunately, the description will need a couple of edits for it to apply properly (I just applied it to a local private branch.) On Sun, Jan 22, 2012 at 08:51:57AM +, Russell King - ARM Linux wrote: @@ -546,8

Re: [PATCH] pcmcia: Convert to DEFINE_PCI_DEVICE_TABLE

2012-02-05 Thread Dominik Brodowski
On Tue, Dec 27, 2011 at 04:17:46PM +0800, Axel Lin wrote: Convert static struct pci_device_id *[] to static DEFINE_PCI_DEVICE_TABLE tables. Also convert to use PCI_DEVICE macro for better readablity. Applied, thanks. Best, Dominik ___ Linux

Re: [PATCH 37/49] pcmcia: irq: Remove IRQF_DISABLED

2012-02-05 Thread Dominik Brodowski
On Sat, Oct 22, 2011 at 05:56:49PM +0800, Yong Zhang wrote: Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled], We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit

Re: [PATCH 2/5] Dynamic ID addition doesn't need get_driver()

2012-01-25 Thread Dominik Brodowski
be unloaded while it is being registered. Signed-off-by: Alan Stern st...@rowland.harvard.edu CC: Dmitry Torokhov dmitry.torok...@gmail.com CC: Jiri Kosina jkos...@suse.cz CC: Jesse Barnes jbar...@virtuousgeek.org CC: Dominik Brodowski li...@dominikbrodowski.net For the PCMCIA part: Acked

Re: [PATCH resend] Clean up new_id and remove_id sysfs attribute routines

2012-01-25 Thread Dominik Brodowski
no_dynamid_id flag is set). In the case of the PCMCIA subsystem, the newid attribute is created but never explicitly deleted. The patch adds a deletion routine. Signed-off-by: Alan Stern st...@rowland.harvard.edu CC: Jesse Barnes jbar...@virtuousgeek.org CC: Dominik

[PATCH 5/7] hostap_cs: support cards with Version 01.02 as third product ID

2011-07-31 Thread Dominik Brodowski
From: Pavel Roskin pro...@gnu.org Cards with numeric ID 0x0156:0x0002 and third ID Version 01.02 can be assumed to have Intersil firmware. Cards with Agere firmware use Version 01.01. Signed-off-by: Pavel Roskin pro...@gnu.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net

[git pull] PCMCIA updates for 3.1

2011-07-31 Thread Dominik Brodowski
. Thanks, Dominik Dominik Brodowski (1): smc91c92_cs.c: fix bogus compiler warning Jonathan Cameron (3): drivers:pcmcia:soc_common: make socket_init and socket_suspend optional pcmcia: pxa2xx: remove empty socket_init / socket_resume functions. pxa2xx pcmcia

[PATCH 7/7] smc91c92_cs.c: fix bogus compiler warning

2011-07-31 Thread Dominik Brodowski
the same condition as a previous branch, where j is set, e.g. int j; if (CONDITION) j = VALUE ... if (CONDITION) printk(j) Still, avoid this warning, as it is easy to circumvent. Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net

[PATCH 6/7] orinoco_cs: be more careful when matching cards with ID 0x0156:0x0002

2011-07-31 Thread Dominik Brodowski
From: Pavel Roskin pro...@gnu.org Without CONFIG_HERMES_PRISM, only match cards that have Version 01.01 as the third product ID. Those have Agere firmware. With CONFIG_HERMES_PRISM, match all 0x0156:0x0002 cards. Signed-off-by: Pavel Roskin pro...@gnu.org Signed-off-by: Dominik Brodowski li

Re: [PATCH 0/3] pxa2xx related pcmcia tidyups.

2011-07-29 Thread Dominik Brodowski
Applied all to -pcmcia. Thanks, Dominik On Wed, Jul 13, 2011 at 03:54:55PM +0100, Jonathan Cameron wrote: Big one here is that 10 drivers don't do anything for socket_init and socket_suspend. That would suggest making them optional? The other patch is a trivial cleanup of the one

Re: [PATCH 1/3] pcmcia: add PCMCIA_DEVICE_MANF_CARD_PROD_ID3

2011-07-29 Thread Dominik Brodowski
Applied all three patches to -pcmcia. Thanks, Dominik On Tue, Jul 26, 2011 at 06:52:35PM -0400, Pavel Roskin wrote: This is needed to match wireless cards with Intersil firmware that have ID 0x0156:0x0002 and the third ID Version 01.02. Such cards are currently matched by orinoco_cs,

Re: Problem with ide-cs

2011-07-29 Thread Dominik Brodowski
Larry, On Fri, Jul 29, 2011 at 11:14:20PM -0500, Larry Finger wrote: With kernel 3.0, my external hard drive attached to a PCMCIA card reports irq 11: nobody cared (try booting with the irqpoll option). The driver in question is ide-cs. When I try irqpoll, the device works correctly.

Re: [ds.h] need WIN_FLAGS_WIN_0, 1, 2, 3 definition

2011-07-24 Thread Dominik Brodowski
Hey Komuro, On Sun, Jul 24, 2011 at 12:28:10PM +0900, Komuro wrote: Hi, I think we need WIN_FLAGS_WIN_0, 1, 2, 3 definition below any comment? What do we need these definitions for? I don't remember any driver which would require such a definition? AFAICT this is only used internally in

Re: Re: [ds.h] need WIN_FLAGS_WIN_0, 1, 2, 3 definition

2011-07-24 Thread Dominik Brodowski
Hey, On Sun, Jul 24, 2011 at 08:08:11PM +0900, Komuro wrote: For example, when we use the resource[2], we should set WIN_FLAGS_WIN_2 to link-resource[2]-flags ? No, that's not necessary. The driver should not care which window is used; that's the job of pcmcia_resource.c . Furthermore,

Re: [TRIVIAL PATCH 0/3] pcmcia: Make struct pcmcia_device_id const

2011-05-11 Thread Dominik Brodowski
On Fri, May 06, 2011 at 11:04:55AM -0700, Joe Perches wrote: On Fri, 2011-05-06 at 08:15 +0200, Dominik Brodowski wrote: On Tue, May 03, 2011 at 07:28:59PM -0700, Joe Perches wrote: Reduces data use. Staging could be applied now, but additional harmless warnings do result. Joe Perches

Re: [ANNOUNCE] pcmciautils-018 released

2011-04-24 Thread Dominik Brodowski
Hey, On Sun, Apr 24, 2011 at 08:48:58PM +0900, Komuro wrote: [rules-base] # PCMCIA sockets: # # modprobe the pcmcia bus module so that 16-bit PCMCIA devices work SUBSYSTEM==pcmcia_socket, \ RUN+=/sbin/modprobe -b pcmcia The modprobe does not have -b option. $ modprobe

[ANNOUNCE] pcmciautils-018 released

2011-04-15 Thread Dominik Brodowski
| 36 ++-- src/yacc_config.y |7 10 files changed, 555 insertions(+), 443 deletions(-) Colin Watson (1): Don't link pcmcia-check-broken-cis against libsysfs Dominik Brodowski (5): gitignore update lspcmcia: print out card resource

[PATCH 3/4] cm4000_cs: Fix undefined ops warning

2011-02-22 Thread Dominik Brodowski
From: Alan Cox a...@linux.intel.com Signed-off-by: Alan Cox a...@linux.intel.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/cm4000_cs.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/char/pcmcia/cm4000_cs.c b/drivers

[PATCH 4/4] pcmcia: re-enable Zoomed Video support

2011-02-22 Thread Dominik Brodowski
Allow drivers to enable Zoomed Video support. Currently, this is only used by out-of-tree drivers (L64020 DVB driver in particular). CC: sta...@kernel.org [for 2.6.37] Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pcmcia_resource.c |2 ++ include/pcmcia/ds.h

[git pull] PCMCIA bugfixes for 2.6.38-rc6

2011-02-22 Thread Dominik Brodowski
undefined ops warning Dominik Brodowski (1): pcmcia: re-enable Zoomed Video support Julia Lawall (1): drivers/char/pcmcia/ipwireless/main.c: Convert release_resource to release_region/release_mem_region Pavel Machek (1): pcmcia vs. MECR on pxa25x/sa drivers/char/pcmcia

Re: [PATCH 0/6] Cleanups for pcmciatools

2011-01-30 Thread Dominik Brodowski
Hey, On Sun, Jan 30, 2011 at 11:05:23AM +0100, Wolfram Sang wrote: Some cleanups triggered by Alexander Mansurov, thanks for that. Wolfram Sang (6): Makefile: let plain 'make' be like 'make all' again lex: disable unused options read-cis: fix type-punning pointers read-cis: Remove

Re: bug in pcmcia-modules?

2011-01-30 Thread Dominik Brodowski
Hey, On Thu, Jan 06, 2011 at 07:03:15PM +0100, f@gmx.de wrote: pci :00:04.0: can't find IRQ for PCI INT A; please try using pci=biosirq pci :00:04.1: can't find IRQ for PCI INT B; please try using pci=biosirq ... yenta_cardbus :00:04.0: CardBus bridge found [:]

Re: from 2.4 Card Services to 2.6 linux-pcmcia

2010-12-14 Thread Dominik Brodowski
Hey, On Tue, Dec 14, 2010 at 05:25:26PM +0100, Guy Léonis wrote: Sorry to disturb you, it is by now only a documentation issue. In the frame of a European Space Agency project, I am in charge of porting a third-party PCMCIA driver (for a very specific and rare card) from kernel 2.4 (Card

[git pull] PCMCIA bugfixes for 2.6.37-rc1

2010-11-13 Thread Dominik Brodowski
Linus, a few PCMCIA bugfixes and improvements are available at git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent The diffstat and list of changes follows; the patches were sent out at least to linux-pcmcia a couple of days ago. Thanks, Dominik Andres Salomon

[PATCH 4/5] pcmcia: fix warning in synclink driver

2010-11-10 Thread Dominik Brodowski
0587102cf). Fix accordingly. Signed-off-by: Andres Salomon dilin...@queued.net Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/synclink_cs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers

[PATCH 2/5] pcmcia/cm4000: fix error code

2010-11-10 Thread Dominik Brodowski
From: Nicolas Kaiser ni...@nikai.net I'm assuming it's not intended to instantly change the error code from -ENODEV to -EIO, is it? Signed-off-by: Nicolas Kaiser ni...@nikai.net Acked-by: Harald Welte lafo...@gnumonks.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers

[PATCH 5/5] drivers/pcmcia/soc_common.c: Use printf extension %pV

2010-11-10 Thread Dominik Brodowski
...@lists.infradead.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/soc_common.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c index 689e3c0..3753fd0 100644 --- a/drivers

[RFC] PCMCIA bugfixes

2010-11-10 Thread Dominik Brodowski
Hey, in order to address a few -- mostly minor -- issues, I intend to push these changes shortly. They're available at git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent As usual, I'm interested in your input to this patch series. The individual patches will be sent out

[PATCH 3/5] pcmcia/sa1100: don't put machine specific init functions in .init.text

2010-11-10 Thread Dominik Brodowski
Miao eric.y.m...@gmail.com CC: linux-arm-ker...@lists.infradead.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pxa2xx_sharpsl.c |2 +- drivers/pcmcia/sa1100_assabet.c |2 +- drivers/pcmcia/sa1100_cerf.c|2 +- drivers/pcmcia/sa1100_generic.c

Re: Where should i add Compact flash driver?

2010-11-03 Thread Dominik Brodowski
Hey, as this doesn't seem to be a PCMCIA-capable driver, I'd say drivers/ata/ (same as pata_octeon_cf.c, for example)... But this decision seems quite easy to revert once the code is available :) Best, Dominik On Tue, Nov 02, 2010 at 10:55:10AM +0530, viresh kumar wrote: Hello, I am

Re: PATCH : linux-2.6.35.4 drivers pcmcia cs.c

2010-11-03 Thread Dominik Brodowski
Hey, On Tue, Nov 02, 2010 at 03:26:42PM +0800, guillermo arias wrote: To Dominic Brodowski :. it would enable CardBus on all PCMCIA bridges . comment :. if (!(skt-features || SS_CAP_CARDBUS)) : refuse to enable in any error(1) condition from pc or kernel . No, if (!((True or False) ||

Re: [PATCH 2.6.36-git1]pd6729:Coding Style fixes

2010-10-24 Thread Dominik Brodowski
Applied, thanks. Best, Dominik ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia

[PATCH 14/22] pcmcia: avoid messages on module (un)loading

2010-10-21 Thread Dominik Brodowski
printk() statements on module load or unload are frowned upon. Also, add a few __init or __exit declarations. Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/cm4000_cs.c|5 - drivers/char/pcmcia

[PATCH 12/22] pcmcia: remove the Finally, report what we've done message

2010-10-21 Thread Dominik Brodowski
Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/synclink_cs.c|7 --- drivers/isdn/hisax/avma1_cs.c|3 --- drivers/isdn/hisax/elsa_cs.c | 10 -- drivers/isdn/hisax/sedlbauer_cs.c

[PATCH 09/22] pcmcia: Documentation update

2010-10-21 Thread Dominik Brodowski
Fill in missing descriptions and update some others for functions in pcmcia_resource.c. Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pcmcia_resource.c | 111 ++ 1 files changed

[PATCH 21/22] pcmcia: don't call flush_scheduled_work() spuriously

2010-10-21 Thread Dominik Brodowski
From: Tejun Heo t...@kernel.org au100_generic and soc_common call flush_scheduled_work() spuriously. Remove them. This is to prepare for the deprecation and removal of flush_scheduled_work(). Signed-off-by: Tejun Heo t...@kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net

[PATCH 02/22] pcmcia: split up modify_configuration() into two fixup functions

2010-10-21 Thread Dominik Brodowski
-...@lists.infradead.org Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/mtd/maps/pcmciamtd.c |8 +-- drivers/net/pcmcia/smc91c92_cs.c |5 +- drivers/pcmcia/pcmcia_resource.c | 130

[PATCH 16/22] pcmcia: add a few debug statements

2010-10-21 Thread Dominik Brodowski
Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/pcmcia_resource.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c index 3194d51..a9af0d7 100644 --- a/drivers

[PATCH 18/22] pcmcia: fix unused function compile warning

2010-10-21 Thread Dominik Brodowski
...@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/cs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index d8189d4..d9ea192 100644 --- a/drivers/pcmcia/cs.c +++ b/drivers/pcmcia/cs.c @@ -844,7

[PATCH 17/22] pcmcia: vrc4173_cardu: Fix error path for pci_release_regions and pci_disable_device

2010-10-21 Thread Dominik Brodowski
...@gmail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/vrc4173_cardu.c | 58 +++- 1 files changed, 39 insertions(+), 19 deletions(-) diff --git a/drivers/pcmcia/vrc4173_cardu.c b/drivers/pcmcia/vrc4173_cardu.c index 9b3c158..c6d36b3

[PATCH 22/22] pcmcia: synclink_cs: fix information leak to userland

2010-10-21 Thread Dominik Brodowski
From: Vasiliy Kulikov sego...@gmail.com Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory. Signed-off-by: Vasiliy Kulikov sego...@gmail.com CC: sta...@kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net

[PATCH 07/22] pcmcia: move config_{base, index, regs} to struct pcmcia_device

2010-10-21 Thread Dominik Brodowski
) Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/bluetooth/bluecard_cs.c |2 +- drivers/char/pcmcia/ipwireless/main.c|2 +- drivers/char/pcmcia/synclink_cs.c|6 ++-- drivers

[git pull] PCMCIA updates for 2.6.36

2010-10-21 Thread Dominik Brodowski
list. Thanks, Dominik Dominik Brodowski (16): pcmcia: do not use win_req_t when calling pcmcia_request_window() pcmcia: split up modify_configuration() into two fixup functions pcmcia: move Vpp setup to struct pcmcia_device pcmcia: remove Pin, Copy configuration

[PATCH 01/22] pcmcia: do not use win_req_t when calling pcmcia_request_window()

2010-10-21 Thread Dominik Brodowski
CC: linux-wirel...@vger.kernel.org CC: linux-...@lists.infradead.org CC: Jiri Kosina jkos...@suse.cz CC: linux-s...@vger.kernel.org Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- Documentation/pcmcia/driver-changes.txt |7

[PATCH 19/22] pcmcia/yenta: guide users in case of problems with O2-bridges

2010-10-21 Thread Dominik Brodowski
-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/o2micro.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pcmcia/o2micro.h b/drivers/pcmcia/o2micro.h index e74beba..5096e92 100644 --- a/drivers/pcmcia/o2micro.h +++ b/drivers/pcmcia/o2micro.h

[PATCH 03/22] pcmcia: move Vpp setup to struct pcmcia_device

2010-10-21 Thread Dominik Brodowski
-...@vger.kernel.org CC: linux-s...@vger.kernel.org Acked-by: Gustavo F. Padovan pado...@profusion.mobi (for drivers/bluetooth) Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/ata/pata_pcmcia.c |4

[PATCH 13/22] pcmcia: move driver name to struct pcmcia_driver

2010-10-21 Thread Dominik Brodowski
Tested-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/ata/pata_pcmcia.c|4 +--- drivers/bluetooth/bluecard_cs.c |4 +--- drivers/bluetooth/bt3c_cs.c |4

[git pull] PCMCIA bugfixes for 2.6.36-rc5

2010-09-26 Thread Dominik Brodowski
Linus, in order to get some more serial devices to work, and to fix an error path in a socet driver, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent Thanks, Dominik Dominik Brodowski (1): pcmcia: preserve configuration information

Re: linux-next: Tree for September 20 (scsi/pcmcia/nsp_cs.c)

2010-09-20 Thread Dominik Brodowski
Thanks for testing, should be fixed for tomorrow. On Mon, Sep 20, 2010 at 09:18:11AM -0700, Randy Dunlap wrote: On Mon, 20 Sep 2010 16:12:39 +1000 Stephen Rothwell wrote: Hi all, Changes since 20100917: drivers/scsi/pcmcia/nsp_cs.c:1573: error: 'cfg' undeclared (first use in this

serial_cs bug (serial subsystem, not pcmcia subsystem)

2010-09-19 Thread Dominik Brodowski
Hey, On Sun, Sep 19, 2010 at 04:39:23PM +0900, Komuro wrote: Hi, http://userweb.kernel.org/~brodo/pcmcia-2.6.35.diff Serial part of Xircom card works with pcmcia-2.6.35.diff. thanks for testing. This means that some non-PCMCIA change since 2.6.35 broke the serial part of Xircom cards

Re: [PATCH 06/14] pcmcia: cs: fix device_register() error handling

2010-09-19 Thread Dominik Brodowski
On Sun, Sep 19, 2010 at 04:54:55PM +0400, Vasiliy Kulikov wrote: If device_register() fails then call put_device(). See comment to device_register. Signed-off-by: Vasiliy Kulikov sego...@gmail.com Acked-by: Dominik Brodowski li...@dominikbrodowski.net Thanks, Dominik

Re: [PATCH 07/14] pcmcia: ds: fix device_register() error handling

2010-09-19 Thread Dominik Brodowski
On Sun, Sep 19, 2010 at 04:54:58PM +0400, Vasiliy Kulikov wrote: If device_register() fails then call put_device(). See comment to device_register. Signed-off-by: Vasiliy Kulikov sego...@gmail.com Acked-by: Dominik Brodowski li...@dominikbrodowski.net Thanks, Dominik

serial_cs bug (serial subsystem, not pcmcia subsystem)

2010-09-19 Thread Dominik Brodowski
Hey Pavel, thanks for testing! On Sun, Sep 19, 2010 at 12:04:36PM +0200, Pavel Machek wrote: No, I still have the problem in -rc4. I did a quick test, and 2.6.35+your bigdiff works ok. so we now have two indepenent indications something is broken in the serial subsystem -- the other being

Re: Re: Re: Re: Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-18 Thread Dominik Brodowski
Hey, On Sat, Sep 18, 2010 at 07:20:31PM +0900, Komuro wrote: With this patch, fmvj18x_cs based card works (both network and serial). good. Will push the patch upstream, then. but Serial part of Xircom card still does not work. Also on re-inserting the card (with 2.6.36-rc4+ as of today)? I

[RFC] PCMCIA patches for 2.6.36-rc5

2010-09-15 Thread Dominik Brodowski
interested in your input to this patch series. The individual patches will be sent out (at least) to the PCMCIA list in a few moments. Best, Dominik Dominik Brodowski (3): pcmcia serial_cs.c: fix multifunction card handling pcmcia: per-device, not per-socket debug messages

[PATCH 1/3] pcmcia serial_cs.c: fix multifunction card handling

2010-09-15 Thread Dominik Brodowski
Sang w.s...@pengutronix.de Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/serial/serial_cs.c | 62 +-- 1 files changed, 36 insertions(+), 26 deletions(-) diff --git a/drivers/serial/serial_cs.c b/drivers/serial/serial_cs.c index

Re: [PATCH pcmciautils] Makefile: add short help target

2010-09-10 Thread Dominik Brodowski
Applied, thanks! On Fri, Sep 10, 2010 at 12:29:32PM +0200, Wolfram Sang wrote: To help people finding out about the debugtools by either running 'make help' or having a look at the top of the Makefile itself. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Dominik Brodowski li

Re: Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-07 Thread Dominik Brodowski
Dear Komuro, On Tue, Sep 07, 2010 at 09:24:30PM +0900, Komuro wrote: Attached file is the output of /sys/kernel/debug/dynamic_debug/control. Could you issue $ echo module pcmcia +p /sys/kernel/debug/dynamic_debug/control and (re-)insert the card, and then send the dmesg (probably $ dmesg

Re: Re: Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-09-04 Thread Dominik Brodowski
Hey, On Sat, Sep 04, 2010 at 09:03:40PM +0900, Komuro wrote: $ echo module pcmcia +p /sys/kernel/debug/dynamic_debug/control Which kernel .config option do I need to enable dynamic_debug? CONFIG_DYNAMIC_DEBUG=y Then mount debugfs to /sys/kernel/debug, if it isn't done automatically

[PATCH 14/15] pcmcia: avoid messages on module (un)loading

2010-09-03 Thread Dominik Brodowski
printk() statements on module load or unload are frowned upon. Also, add a few __init or __exit declarations. Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/char/pcmcia/cm4000_cs.c|3 --- drivers/char/pcmcia/cm4040_cs.c|2 -- drivers/char

[PATCH 10/15] pcmcia: introduce autoconfiguration feature

2010-09-03 Thread Dominik Brodowski
...@vger.kernel.org CC: Jiri Kosina jkos...@suse.cz CC: linux-s...@vger.kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/ata/pata_pcmcia.c| 23 + drivers/bluetooth/bt3c_cs.c |7 +- drivers/bluetooth/btuart_cs.c

[PATCH 05/15] pcmcia: simplify Status, ExtStatus register access

2010-09-03 Thread Dominik Brodowski
: net...@vger.kernel.org CC: linux-wirel...@vger.kernel.org CC: linux-ser...@vger.kernel.org CC: linux-s...@vger.kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/isdn/hisax/sedlbauer_cs.c |4 +-- drivers/net/pcmcia/axnet_cs.c |4

[PATCH 01/15] pcmcia: do not use win_req_t when calling pcmcia_request_window()

2010-09-03 Thread Dominik Brodowski
CC: linux-wirel...@vger.kernel.org CC: linux-...@lists.infradead.org CC: Jiri Kosina jkos...@suse.cz CC: linux-s...@vger.kernel.org Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- Documentation/pcmcia/driver-changes.txt |7 +++ drivers/char/pcmcia/ipwireless/main.c | 87

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-30 Thread Dominik Brodowski
Hey, does this patch help? If not, could you please enable dynamic debug by issuing $ echo module pcmcia +p /sys/kernel/debug/dynamic_debug/control Thanks, Dominik From: Dominik Brodowski li...@dominikbrodowski.net Date: Mon, 30 Aug 2010 08:18:54 +0200 Subject: [PATCH] pcmcia: fix

Re: [PATCH 11/18] pcmcia: do not use io_req_t when calling pcmcia_request_io()

2010-08-14 Thread Dominik Brodowski
Hey, On Sat, Aug 14, 2010 at 08:59:11AM +0900, Komuro wrote: @@ -248,9 +248,8 @@ static int fmvj18x_probe(struct pcmcia_device *link) lp-base = NULL; /* The io structure describes IO port mapping */ -link-io.NumPorts1 = 32; -link-io.Attributes1 = IO_DATA_PATH_WIDTH_AUTO;

Re: MAINTAINERS: PCMCIA SUBSYSTEM: Should F: drivers/net/pcmcia/ be added?

2010-08-13 Thread Dominik Brodowski
Hey, On Thu, Aug 12, 2010 at 03:47:52PM -0700, Joe Perches wrote: On Thu, 2010-08-12 at 15:22 -0700, Joe Perches wrote: On Mon, 2010-08-09 at 17:34 +0200, Dominik Brodowski wrote: look good from a PCMCIA point of view, therefore: Signed-off-by: Dominik Brodowski li

[PATCH] pcmcia: avoid buffer overflow in pcmcia_setup_isa_irq

2010-08-12 Thread Dominik Brodowski
Fritz chf.fr...@googlemail.com Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net Signed-off-by: Christoph Fritz chf.fr...@googlemail.com --- Note: a similar patch is already queued for 2.6.35.2. This patch applies to 2.6.34 and all other previous stable kernels still maintained. diff

Re: [PATCH] pcnet_cs: Use proper netdev_*-printouts

2010-08-11 Thread Dominik Brodowski
On Sun, Aug 08, 2010 at 02:32:05PM +0200, Wolfram Sang wrote: To prevent broken messages like: [ 204.024291] eth%d: pcnet_reset_8390() did not complete. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Dominik Brodowski li...@dominikbrodowski.net Cc: Joe Perches j...@perches.com Cc

Re: [PATCH 11/18] pcmcia: pd6729: call disable_pci_device() if pci_probe() failed

2010-08-07 Thread Dominik Brodowski
On Fri, Aug 06, 2010 at 11:52:44PM +0400, Kulikov Vasiliy wrote: Driver should call disable_pci_device() if it returns from pci_probe() with error. Also it must not be called if pci_request_region() fails as it means that somebody uses device resources and rules the device. But that would mean

[PATCH 05/18] pcmcia: remove unused flag, simplify headers

2010-08-05 Thread Dominik Brodowski
As we only provide one way to set up resources now, we can remove the resource-setup-related bitfield (except resource_setup_done). In addition, pcmcia_state only consisted of one entry, so remove this bitfield as well. Suggested-by: Komuro komurojun-...@nifty.com Signed-off-by: Dominik Brodowski

[PATCH 08/18] pcmcia: clean up cs.h

2010-08-05 Thread Dominik Brodowski
Remove some obsolete definitions from cs.h Signed-off-by: Dominik Brodowski li...@dominikbrodowski.net --- drivers/pcmcia/rsrc_nonstatic.c |3 +++ include/pcmcia/cs.h | 12 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/pcmcia

  1   2   3   4   5   6   7   >