Re: [PATCH 10/33] pcmcia: soc_common: switch to using gpio_descs

2016-09-14 Thread Linus Walleij
Which seems like before the patch series. I still suspect the PCMCIA is not really working but I have limited experience of the bus so I don't really know how to test it deeply or have my PCMCIA ethernet or harddrive probe properly. There are no regressions however, so with something like

Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support

2016-09-14 Thread Linus Walleij
at already in my branch. Unfortunately not, the bug is still there, I'll point it out in the relevant patch, just need to do a boot test. Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-14 Thread Linus Walleij
On Thu, Sep 8, 2016 at 3:21 PM, Linus Walleij wrote: > On Mon, Sep 5, 2016 at 2:26 PM, Russell King - ARM Linux > wrote: >> On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: >>> I couldn't resist testing on the Compaq iPAQ h3600. It works the >>&g

Re: [PATCH 18/33] pcmcia: sa1100: provide generic CF support

2016-09-14 Thread Linus Walleij
should be pdev->id rather than dev->id. After fixing this, my legacy h3600 PCMCIA started probing again. (It revealed another bug in fetching GPIOs but it is an orthogobal problem altogether, looking into it.) Yours, Linus Walleij ___ Linux PCM

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-08 Thread Linus Walleij
On Mon, Sep 5, 2016 at 2:26 PM, Russell King - ARM Linux wrote: > On Mon, Sep 05, 2016 at 11:06:28AM +0200, Linus Walleij wrote: >> I couldn't resist testing on the Compaq iPAQ h3600. It works the >> same as before so: >> Tested-by: Linus Walleij [for Compaq iPAQ H3

Re: [PATCH 01/33] gpio: sa1100: fix irq probing for ucb1x00

2016-09-07 Thread Linus Walleij
GPIO > interrupts. Fix this. > > Fixes: 23393d49fb75 ("gpio: kill off set_irq_flags usage") > Signed-off-by: Russell King Patch applied per Russell's request. Trying to get this tested and upstream ASAP. Yours, Linus Walleij ___

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-05 Thread Linus Walleij
st testing on the Compaq iPAQ h3600. It works the same as before so: Tested-by: Linus Walleij [for Compaq iPAQ H3600] The only news in the bootlog is this: sa11x0-pcmcia: probe of sa11x0-pcmcia failed with error -2 This device does have a PCMCIA "sleeve" where I slotted in an ethernet c

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-09-04 Thread Linus Walleij
PIO signals have hardware > interrupts associated with them, but not all. > > Do you approve? Yes of course. Acked-by: Linus Walleij Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Linus Walleij
On Tue, Aug 30, 2016 at 11:42 PM, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: >> > +#define to_gpio_reg(x) container_of(x, struct gpio_reg, gc) >> >> You don't need that trickery anymore, just: >> >> &g

Re: [RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)

2016-08-30 Thread Linus Walleij
MCIA > updates. Further updates for IrDA drivers, DMA engine, serial, and > ethernet will follow in time. For all the GPIO patches: Acked-by: Linus Walleij With the smallish changes needed to patch 5/33 that one is acked too. In fact I would ACK it anyway, because the net total cleanup is so n

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Linus Walleij
else > + ret = gpiochip_add_data(&r->gc, r); Aha both device and device-less, I see. Apart from that it looks nice, any other questionmarks were fixed in the other replies. Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Re: [PATCH v2] pcmcia: db1xxx_ss: fix last irq_to_gpio user

2016-03-08 Thread Linus Walleij
> Signed-off-by: Manuel Lauss > --- > v2: "Fixes" line, and CC stable, and added Arnd's ack. Reviewed-by: Linus Walleij Yours, Linus Walleij ___ Linux PCMCIA reimplementation list http://lists.infradead.org/mailman/listinfo/linux-pcmcia