Most of the irq_req_t typedef'd struct can be re-worked quite
easily:
(1) IRQInfo2 was unused in any case, so drop it.
(2) IRQInfo1 was used write-only, so drop it.
(3) Instance (private data to be passed to the IRQ handler):
Most PCMCIA drivers using pcmcia_request_irq() to actually
Hi Dominik,
> Most of the irq_req_t typedef'd struct can be re-worked quite
> easily:
>
> (1) IRQInfo2 was unused in any case, so drop it.
>
> (2) IRQInfo1 was used write-only, so drop it.
>
> (3) Instance (private data to be passed to the IRQ handler):
> Most PCMCIA drivers using pcmcia_
Hi,
>link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED;
IRQ_FIRST_SHARED is not used at all in the pcmcia-subsystem.
so it should be removed.
> Most of the irq_req_t typedef'd struct can be re-worked quite
> easily:
>
> (1) IRQInfo2 was unused in any case, so drop it.
>
> (2)
Hey,
On Sat, Nov 14, 2009 at 09:33:14AM +0900, Komuro wrote:
> >link->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_SHARED;
>
> IRQ_FIRST_SHARED is not used at all in the pcmcia-subsystem.
> so it should be removed.
Thanks for the hint. Will make a separate patch out of it (see below)
Bes
Hi Dominik,
> diff --git a/include/pcmcia/cs.h b/include/pcmcia/cs.h
> index afc2bfb..39376e6 100644
> --- a/include/pcmcia/cs.h
> +++ b/include/pcmcia/cs.h
> @@ -126,7 +126,7 @@ typedef struct irq_req_t {
> #define IRQ_TYPE_TIME0x01
> #define IRQ_TYPE_DYNAMIC_SHARING
Hey,
On Sun, Nov 29, 2009 at 11:14:56AM +0100, Wolfram Sang wrote:
> > diff --git a/include/pcmcia/cs.h b/include/pcmcia/cs.h
> > index afc2bfb..39376e6 100644
> > --- a/include/pcmcia/cs.h
> > +++ b/include/pcmcia/cs.h
> > @@ -126,7 +126,7 @@ typedef struct irq_req_t {
> > #define IRQ_TYPE_TIME
Hi,
IRQ_TYPE_EXCLUSIVE below is unnecessary.
>--- a/drivers/isdn/hardware/avm/avm_cs.c
>+++ b/drivers/isdn/hardware/avm/avm_cs.c
>
> /* Interrupt setup */
> p_dev->irq.Attributes = IRQ_TYPE_EXCLUSIVE; <- unnecessary
>-p_dev->irq.Attributes = IRQ_TYPE_DYNAMIC_SHARING|IRQ_FIRST_S
