At least warn if pcmcia_write_cis_mem() didn't succeed, util we have
proper error handling in place.

Signed-off-by: Dominik Brodowski <li...@dominikbrodowski.net>
---
 drivers/pcmcia/cistpl.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/pcmcia/cistpl.c b/drivers/pcmcia/cistpl.c
index 17a5da3..81364a1 100644
--- a/drivers/pcmcia/cistpl.c
+++ b/drivers/pcmcia/cistpl.c
@@ -220,8 +220,10 @@ void pcmcia_write_cis_mem(struct pcmcia_socket *s, int 
attr, u_int addr,
        }
 
        sys = set_cis_map(s, 0, MAP_ACTIVE | ((cis_width) ? MAP_16BIT : 0));
-       if (!sys)
+       if (!sys) {
+               dev_warn(&s->dev, "could not map memory\n");
                return; /* FIXME: Error */
+       }
 
        writeb(flags, sys+CISREG_ICTRL0);
        writeb(addr & 0xff, sys+CISREG_IADDR0);
@@ -243,8 +245,10 @@ void pcmcia_write_cis_mem(struct pcmcia_socket *s, int 
attr, u_int addr,
        card_offset = addr & ~(s->map_size-1);
        while (len) {
            sys = set_cis_map(s, card_offset, flags);
-           if (!sys)
+           if (!sys) {
+               dev_warn(&s->dev, "could not map memory\n");
                return; /* FIXME: error */
+           }
 
            end = sys + s->map_size;
            sys = sys + (addr & (s->map_size-1));
-- 
1.6.3.3


_______________________________________________
Linux PCMCIA reimplementation list
http://lists.infradead.org/mailman/listinfo/linux-pcmcia

Reply via email to