From: Julia Lawall
The result of calling kzalloc is never used or freed.
The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
//
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@
Julia Lawall schrieb:
> From: Julia Lawall
>
> The result of calling kzalloc is never used or freed.
>
> The semantic match that finds this problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> //
> @r exists@
> local idexpression x;
> statement S;
> expression E;
> identifier
On Sat, 21 Nov 2009, walter harms wrote:
>
>
> Julia Lawall schrieb:
> > From: Julia Lawall
> >
> > The result of calling kzalloc is never used or freed.
> >
> > The semantic match that finds this problem is as follows:
> > (http://www.emn.fr/x-info/coccinelle/)
> >
> > //
> > @r exists@
>
On Sat, Nov 21, 2009 at 04:12:59PM +0100, Julia Lawall wrote:
> Both kzallocs were added at the same time, when the function was added in
> commit 701a5dc05ad99a06958b3f97cb69d99b47cebee3. I have added the author
> to the CC list.
That commit id means nothing to me.
___
On Sat, 21 Nov 2009, Russell King - ARM Linux wrote:
> On Sat, Nov 21, 2009 at 04:12:59PM +0100, Julia Lawall wrote:
> > Both kzallocs were added at the same time, when the function was added in
> > commit 701a5dc05ad99a06958b3f97cb69d99b47cebee3. I have added the author
> > to the CC list.
>
On Sat, Nov 21, 2009 at 03:16:47PM +, Russell King - ARM Linux wrote:
> On Sat, Nov 21, 2009 at 04:12:59PM +0100, Julia Lawall wrote:
> > Both kzallocs were added at the same time, when the function was added in
> > commit 701a5dc05ad99a06958b3f97cb69d99b47cebee3. I have added the author
> >
On Sat, Nov 21, 2009 at 04:12:59PM +0100, Julia Lawall wrote:
> On Sat, 21 Nov 2009, walter harms wrote:
>
> >
> >
> > Julia Lawall schrieb:
> > > From: Julia Lawall
> > >
> > > The result of calling kzalloc is never used or freed.
> > >
> > > The semantic match that finds this problem is as
> Just remove the first kzalloc and don't convert it to an array; that's the
> safest option. I don't remember if there's a reason why I switched to a
> linked list - however, what I will say is that the way all the sa11xx
> and pxa stuff interact is not plainly obvious.
OK, that is what my patch
Russell,
> Thanks for the additional info which allows me to track which patch it
> corresponds with. As an aside, it's really not nice to git pull and
> then edit the commits afterwards - that's much worse than rebasing.
> When trees are pulled, the act of merging it conveys sufficent "sign-off"
