Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Namhyung Kim
Hi Arnaldo and Masami, On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > In this series I've also tried to fix some object leaks in perf top > > and perf stat. > > After applying this series, this re

Re: What is 'web--browse' on builtin-help.c ?

2015-12-01 Thread Namhyung Kim
Hi Taeung, On Wed, Dec 02, 2015 at 12:46:40PM +0900, Taeung Song wrote: > Hi, all > > I’m checking perf-help subcommand and config ‘help.format’. > source code for them contain functionality for info and web > but functionality for info and web didn’t work well. ( there isn’t problems > about ‘m

Re: [PATCH v3] perf tools: Work around lack of sched_getcpu in glibc < 2.6.

2015-03-23 Thread Namhyung Kim
t; util/cloexec.c:24: error: implicit declaration of function > ‘sched_getcpu’ > util/cloexec.c:24: error: nested extern declaration of ‘sched_getcpu’ > make: *** [util/cloexec.o] Error 1 > > Cc: sta...@vger.kernel.org # 3.18+ > Signed-off-by: Vinson Lee Acked-by: Namhyung Kim

Re: [PATCH] perf annotate: Set the input file name after parsing options.

2015-03-22 Thread Namhyung Kim
Hi Roland, On Thu, Mar 19, 2015 at 01:26:09PM -0400, Roland Grunberg wrote: > The input file name should be set after parse_options has been called if > the '-i' option is to have any effect. > > Signed-off-by: Roland Grunberg Acked-by: Namhyung Kim Thanks, Nam

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-22 Thread Namhyung Kim
Hi Stephane, On Fri, Mar 20, 2015 at 02:12:30PM -0700, Stephane Eranian wrote: > On Fri, Mar 20, 2015 at 2:07 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escr

Re: What do mean children of top ?

2015-03-03 Thread Namhyung Kim
Hi Arnaldo and Taewoong, On Tue, Mar 03, 2015 at 01:23:48PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 03, 2015 at 02:04:47AM +0900, TaeWoong Song escreveu: > > Hi, perf users > > > > About > > The function perf_top_config() on builtin-top.c: > > It depend on whether top.children is ’t

Re: compile error : about declaration of ‘pthread_attr_setaffinity_np’

2015-02-27 Thread Namhyung Kim
(Adding Arnaldo and Jiri to CC.) On Tue, Feb 24, 2015 at 06:02:51PM +0900, taeung wrote: > Hi, Namhyung Hi Taeung, > > After I pulled new changed source codes from 'perf/core' branch > (https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git) > ,when I compiled perf I've had a problem with

Re: [PATCH] perf symbols: Define STT_GNU_IFUNC for glibc 2.9 and older.

2015-02-10 Thread Namhyung Kim
l-elf.c:75: error: for each function it appears in.) > make: *** [util/symbol-elf.o] Error 1 > > Cc: sta...@vger.kernel.org # 3.17+ > Signed-off-by: Vinson Lee Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/util/symbol-elf.c | 4 > 1 file changed, 4 in

Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0

2015-01-10 Thread Namhyung Kim
On Sat, Jan 10, 2015 at 10:16:06AM +, Vineet Gupta wrote: > On Thursday 08 January 2015 01:23 PM, Namhyung Kim wrote: > > Hmm.. okay. I think we don't need to allocate the id arrays when size > > is 0. So perf_event__process_attr() will have the same problem IMHO

Re: [PATCH 5/5] perf tools: [uclibc] provide stub for pthread_attr_setaffinity_np

2015-01-08 Thread Namhyung Kim
On Tue, Jan 06, 2015 at 07:22:15PM +0530, Vineet Gupta wrote: > uClibc Linuxthreads.old doesnt support pthread_attr_setaffinity_np() > call > > ->8--- > CC bench/futex-hash.o > CC bench/futex-wake.o > bench/futex-hash.c: In function 'bench_futex_

Re: [PATCH 4/5] perf tools: [uclibc] don't rely on glibc malloc working for sz 0

2015-01-07 Thread Namhyung Kim
Hi Vineet, On Tue, Jan 06, 2015 at 07:22:14PM +0530, Vineet Gupta wrote: > When running perf on ARC (uClibc based userspace), ran into this issue > ->8 > [ARCLinux]$ ./perf record ls > bin etc perfsys > debug

Re: Size of perf data files

2014-11-27 Thread Namhyung Kim
Hi Arnaldo, On Thu, 27 Nov 2014 10:19:16 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Nov 27, 2014 at 09:56:21AM +0900, Namhyung Kim escreveu: >> Hi Milian, >> >> On Wed, 26 Nov 2014 19:11:01 +0100, Milian Wolff wrote: >> > I tried this on a benchmark of mine:

Re: Size of perf data files

2014-11-26 Thread Namhyung Kim
Hi Milian, On Wed, 26 Nov 2014 19:11:01 +0100, Milian Wolff wrote: > I tried this on a benchmark of mine: > > before: > [ perf record: Woken up 196 times to write data ] > [ perf record: Captured and wrote 48.860 MB perf.data (~2134707 samples) ] > > after, with dwarf,512 > [ perf record: Woken up

Re: sampling and reading

2014-11-04 Thread Namhyung Kim
Hi Arnav, On Tue, 4 Nov 2014 20:27:08 + (UTC), Arnav wrote: > i am working on a project where i need to find program counters for every > 100M > instructions. > > i have used the following command to record the event > > perf record -e instructions -c 1 ./filename > > now, since cou

Re: Adding cache misses and references to list of default events for perf stat?

2014-11-04 Thread Namhyung Kim
Hi Andi and Milian, On Tue, 04 Nov 2014 12:16:25 -0800, Andi Kleen wrote: > Milian Wolff writes: > >> Hello all, >> >> could we have the cache-references,cache-misses events added to the list of >> default events for perf stat? I think it is a very valuable metric for all >> user-space applicat

Re: Collect Per thread event count using perf

2014-10-28 Thread Namhyung Kim
Hi Hemendra, On Wed, 29 Oct 2014 02:03:36 + (UTC), Hemendra Rawat wrote: > Hi, > > I'm new to perf. I want to use perf to collect cpu-cycles spent in > each function for a multi-threaded program (Nasa Parallel Bench > marks OpenMP version). > > I'm using following commands to record and ana

Re: [PATCH] perf top: Add a visual cue for toggle zeroing of samples

2014-10-06 Thread Namhyung Kim
Hi Taeung, On Sun, 5 Oct 2014 15:49:34 +0900, Taeung Song wrote: > When 'perf top' is run, one can't easily find a difference > between -z option and normal output. > So I added a visual cue to know whether it is the zeroing or not. [SNIP] > +static int hists__browser_title(struct hists *hists,

Re: What do zeroing of samples in 'perf top' mean ?

2014-09-29 Thread Namhyung Kim
Hi Taeung, On Tue, 30 Sep 2014 12:19:41 +0900, taeung wrote: > Hi, > > I have two questions about 'zeroing of samples' in 'perf top'. > > I knew if I use 'perf top', I can see a performance counter profile in > real time. > But I can't find a difference between 'perf top -a' and 'perf top --zero'.

Re: [PATCH 1/1] perf tools: Fix Symbol Address for ET_DYN

2014-09-28 Thread Namhyung Kim
Hi Tong, On Thu, 25 Sep 2014 22:53:22 -0700, Tong Shen wrote: >> +/** >> + * is_non_relocatable_dyn - check if ELF file is ET_DYN, but not >> relocatable >> + * @ehdr: ELF header of the ELF file >> + * @shdr: a section header in the ELF file >> + * >> + * For ELF files

Re: [PATCH 1/1] perf tools: Fix Symbol Address for ET_DYN

2014-09-25 Thread Namhyung Kim
Hi Tong, Does a non-relocatable-dyn mean a prelink-ed dso? Thanks, Namhyung On Wed, 24 Sep 2014 17:28:24 -0700, Tong Shen wrote: > Gentle Ping :-) > > On Mon, Sep 15, 2014 at 11:06 AM, Tong Shen wrote: >> Gentle ping :-) >> >> On Thu, Sep 11, 2014 at 1:38 PM, Arnaldo Carvalho de Melo >> wrote

Re: [PATCH] perf tools: modify error code when perf_session__new() fail.

2014-09-25 Thread Namhyung Kim
Hi Taeung, On Wed, 24 Sep 2014 10:33:37 +0900, Taeung Song wrote: > Because perf_session__new() could fail for more reasons than just ENOMEM, > I modified error code(ENOMEM or EINVAL) into -1. > > Signed-off-by: Taeung Song Acked-by: Namhyung Kim Thanks, Namhyung > --- >

Re: [PATCH] modified error code when perf_session__new() fail

2014-09-22 Thread Namhyung Kim
Hi Jiri, 2014-09-22 (월), 15:46 +0200, Jiri Olsa: > On Sun, Sep 21, 2014 at 12:44:55AM +0900, Namhyung Kim wrote: > > That being said I'm okay with the patch itself. Jiri, this is what you > > wanted to do, right? > > I have some vague memories about this.. any

Re: Perf event for Wall-time based sampling?

2014-09-22 Thread Namhyung Kim
On Fri, 19 Sep 2014 14:59:55 +0900, Namhyung Kim wrote: > I'm also *very* interest in collecting idle/wait info using perf. Looks > like we can somehow use sched:* tracepoints but it requires root > privilege though (unless /proc/sys/kernel/perf_event_paranoid being -1). > > W

Re: [PATCH] modified error code when perf_session__new() fail

2014-09-20 Thread Namhyung Kim
Hi Taeung, Please CC perf maintainers when you send a perf patch. I'm adding Arnaldo who maintains tooling part and Jiri who suggested this change. 2014-09-17 (수), 17:31 +0900, taeung: > Hi, > > I modified error code for the requirement as below. > > Author: taeung > Date: Sat Sep 13 16:22

Re: Perf event for Wall-time based sampling?

2014-09-19 Thread Namhyung Kim
2014-09-19 (금), 16:53 +0200, Milian Wolff: > On Friday 19 September 2014 11:33:40 Arnaldo Carvalho de Melo wrote: > > Em Fri, Sep 19, 2014 at 02:59:55PM +0900, Namhyung Kim escreveu: > > > Hi Arnaldo and Millan, > > > > > > On Thu, 18 Sep 2014 16:17:13 -

Re: Perf event for Wall-time based sampling?

2014-09-18 Thread Namhyung Kim
Hi Arnaldo and Millan, On Thu, 18 Sep 2014 16:17:13 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Sep 18, 2014 at 06:37:47PM +0200, Milian Wolff escreveu: >> On Thursday 18 September 2014 12:57:45 Arnaldo Carvalho de Melo wrote: >> > Em Thu, Sep 18, 2014 at 05:26:33PM +0200, Milian Wolff escrev

Re: [PATCH 2/2] perf Makefile: default WERROR to off.

2014-08-25 Thread Namhyung Kim
On Mon, 25 Aug 2014 21:37:08 +0200, John Spencer wrote: > From 4a72032828a6784d93f4becf723303a17d723544 Mon Sep 17 00:00:00 2001 > From: John Spencer > Date: Mon, 25 Aug 2014 21:25:43 +0200 > Subject: [PATCH 2/2] perf Makefile: default WERROR to off. > > Having WERROR on by default breaks build ev

Re: [PATCH 1/2] perf Makefile: fix GNU-only grep usage

2014-08-25 Thread Namhyung Kim
00:00:00 2001 > From: John Spencer > Date: Mon, 25 Aug 2014 21:24:30 +0200 > Subject: [PATCH 1/2] perf Makefile: fix GNU-only grep usage > > this makes it work with non-GNU grep's as well. > > Signed-off-by: John Spencer Acked-by: Namhyung Kim Thanks, Namhyung > &g

Re: cross compiling perf tool on ARM fails in yocto-linux environment

2014-08-12 Thread Namhyung Kim
Hi Suresh, On Tue, 12 Aug 2014 18:04:10 + (UTC), Suresh Nagarajan wrote: > I am trying to cross-compile perf tool for ARM on x86 machine. > > > > > [snagarajan@moltar-76 perf]$ alias armmake='make CROSS_COMPILE=arm-linux- > gnueabihf- ARCH=

Re: Power consumption measurements for ARM

2014-08-12 Thread Namhyung Kim
Hi taeung, On Tue, 12 Aug 2014 17:20:45 +0900, taeung wrote: > Hi, perf hackers > > I have other question. > As I know, perf also supports RAPL(running average power limit ) > for power consumption measurements. > > And as I understand, the amount of power consumption is estimated > by using hardw

Re: About use of dlsym()

2014-08-11 Thread Namhyung Kim
Hi taeung, On Fri, 08 Aug 2014 15:29:26 +0900, taeung wrote: > Hello, perf hackers :-) > > I'm beginner in perf. > I'm analysing the sequence of function call and how it was written to > update 'report' of gtk view. > > This is a thread of a command 'perf report --gtk' > > 1. run_argv() > (in main

Re: kprobe string

2014-07-17 Thread Namhyung Kim
Hi Brendan, On Wed, 16 Jul 2014 23:29:10 -0700, Brendan Gregg wrote: > G'Day David, > > On Wed, Jul 16, 2014 at 9:41 PM, David Ahern wrote: >> >> >> On 07/16/2014 06:51 PM, Brendan Gregg wrote: >>> >>> G'Day, >>> >>> I'm not sure where else to ask this; I don't think this functionality >>> is in

Re: Where is main linux-perf IRC ?

2014-07-03 Thread Namhyung Kim
Hi Taeung, On Wed, 02 Jul 2014 22:31:26 +0900, Taeung wrote: > Where is main linux-perf IRC ? > > I've failed finding main perf IRC though I try to find 'perf' IRC server. You can find it on #perf in OFTC . Please check www.oftc.net for details. Thanks, Namhyung -- To unsubscribe from this list

Re: Referencing perf?

2014-05-13 Thread Namhyung Kim
Hi Harald and Vince, On Tue, 13 May 2014 10:24:06 -0400 (EDT), Vince Weaver wrote: > On Sat, 10 May 2014, Harald Servat wrote: > >> which is the appropriate way to reference perf in a publication? > > That's a good question. > > The original authors are T. Gleixner and I. Molnar, but they've nev

Re: Loop block overhead

2014-05-13 Thread Namhyung Kim
Hi lhmaster, On Wed, 7 May 2014 14:55:05 -0300, lhmaster wrote: > Thank you for the info. > > I researched a bit and found that srcline uses addr2line capabilities > to map memory addressed into source lines. Nevertheless, as I invoke > > $ perf report -s srcline, sys > > only the original mem add

Re: Access to backtraces from user-space tracepoint callback in perf-script?

2014-05-13 Thread Namhyung Kim
Hi Milian, On Wed, 07 May 2014 14:46:31 +0200, Milian Wolff wrote: > On Tuesday 29 April 2014 17:44:54 Milian Wolff wrote: >> Hello, >> >> today I played around with perf-script(-python) and custom tracepoints. What >> I could not figure out so far is how to print a backtrace from the python >> c

Re: recording rapl/power events

2014-04-25 Thread Namhyung Kim
Hi Andi, On Tue, 22 Apr 2014 03:17:56 -0700, Andi Kleen wrote: > Adrien BAK writes: >> >> This looks promising, although I couldn't find any useful >> documentation on this. Do you know if the perf userland tool allows >> for this kind of slave-sampling or if I have to build my own tool >> around

Re: [PATCH] Correctly handle symbols in VDSO

2014-04-06 Thread Namhyung Kim
t; 8.76% > __vdso_gettimeofday > __gettimeofday > ACE_OS::gettimeofday() > ... Tested-by: Namhyung Kim Just one question below.. > >

Re: perf not working for some commands?

2014-01-28 Thread Namhyung Kim
Hi Jiri, On Tue, 28 Jan 2014 10:22:03 +0100, Jiri Olsa wrote: > [jolsa@krava perf]$ strace -fo out ./perf stat krava > Workload failed: No such file or directory > [jolsa@krava perf]$ cat out | grep exec You can also use "strace -f -e execve ./perf stat krava" :) Thanks, Namhyung -- To unsubscri

Re: Does perf record support event multiplexing?

2014-01-28 Thread Namhyung Kim
Hi AmirReza, On Mon, 27 Jan 2014 16:14:21 -0500, AmirReza Ghods wrote: > Thank you for your response, but that doesn't really answer my > question. I wanted to know why scaling of the event counts is > implemented in "perf stat" but NOT implemented in "perf record". I think the reason is "perf re

Re: Intel PEBS Load Latency Measurement

2013-11-01 Thread Namhyung Kim
On Tue, 29 Oct 2013 14:20:09 +0100, Manuel Selva wrote: > One more thing I forgot to ask is clarification about the pid > parameter. According to Vince Weaver page: "If pid is 0, measurements > happen on the current thread, if pid is greater than 0, the process > indicated by pid is measured, and i

Re: Fwd: Intel PEBS Load Latency Measurement

2013-11-01 Thread Namhyung Kim
nel to record events about processes naming, and memory > mappings of code to be able to retrieve offline the source code > associated to instruction pointers present in samples. > > Thanks again for your help, > > Manu > > > 2013/10/29 Namhyung Kim >> >> Hi Ma

Re: Intel PEBS Load Latency Measurement

2013-10-28 Thread Namhyung Kim
Hi Manuel, On Mon, 28 Oct 2013 12:28:06 +0100, Manuel Selva wrote: > Hi, > > I am coming back on this subject after working on other stuff for > several weeks. Andi pointed me to the userland tool 'perf mem' > introduced in "recent" kernels (can't find the version) that is using > the kernel perf_

Re: Changing frequency rate to perf mem

2013-10-27 Thread Namhyung Kim
Hi Harald, On Thu, 24 Oct 2013 09:48:09 +0200, Harald Servat wrote: > On 24/10/13 07:12, Andi Kleen wrote: >> Harald Servat writes: >>> Unfortunately, this seems to break something and >>> perf segfaults often. Which is the most appropriate way to tune the >>> user frequency of perf mem? >> >> Be

Re: No tracepoint event in the perf list output

2013-04-11 Thread Namhyung Kim
Hi Donitta, On Mon, 8 Apr 2013 09:51:32 + (UTC), Donitta wrote: > Hi, > > According to the perf documentation, when running "perf list" command we > should have all pre-defined events that could be hardware, software, hardware > cache, raw hardware event descriptor, hardware breakpoint or t

Re: Fw: Re: Re: Howto make perf probe work

2013-04-03 Thread Namhyung Kim
Hi, On Thu, 4 Apr 2013 01:28:34 +0800, OSDepend wrote: >> On Tue, 2 Apr 2013 17:11:01 +0800, OSDepend wrote: >> >> For some reason, do_page_fault() is marked as __kprobe on some arch >> >> which means it cannot be probed. >> > >> > My kernel is runing on X86_64 arch, is there any chance for me to

Re: Fw: Re: Re: Howto make perf probe work

2013-04-03 Thread Namhyung Kim
Hi, On Tue, 2 Apr 2013 17:11:01 +0800, >> For some reason, do_page_fault() is marked as __kprobe on some arch >> which means it cannot be probed. > > My kernel is runing on X86_64 arch, is there any chance for me to get the > do_page_fault() entry/exit work? nope, AFAIK. > Or How can i add a e

Re: perf event attrributes

2013-04-01 Thread Namhyung Kim
Hi Chris, On Mon, 1 Apr 2013 16:09:50 +, Freehill Christopher-RAT wrote: > Andi, > > Thanks for the response. > > I am not familiar with "config/config1", but I infer from your message that I > would make folders in sysfs for different event groups (?) and then have a > file for each event t

Re: Fw: Re: Re: Howto make perf probe work

2013-04-01 Thread Namhyung Kim
> >HI, > >Please enable kprobe_event config option in the kernel and build the same > >and boot the board using it. Then please try to add event using perf probe > >command > > Thanks very much for your reply, and I already enable DEBUG_KPROBE_EVENT in > kernel. > I did success in "perf probe han

Re: Chronogram with pref ?

2013-01-23 Thread Namhyung Kim
On Wed, 23 Jan 2013 14:17:03 +0100, Milian Wolff wrote: > On Wednesday 23 January 2013 09:49:16 dark_footix wrote: >> If I am interested to start a development of an graphic interface to visual >> the result, do you have some result of log which one I could parse ? which >> could be the formalism o

Re: perf with gnuplot

2013-01-23 Thread Namhyung Kim
Hi Thorsten, On Wed, 23 Jan 2013 13:38:00 +0100, Thorsten Schuett wrote: > Hi, > > I record three different events for my test-program: > perf record -s -e cycles,instructions,LLC-load-misses ./test-program > > I want to plot the occurences of the different events over time, > i.e. x-axis is time

Re: Queries on using PERF tool

2012-11-29 Thread Namhyung Kim
Hi Shahina, 2012-11-29 (목), 13:45 +0530, Shahina Rabbani: > Hi Namhyung Kim , > > > First of all Thanks for your mail. > I have some more doubts. Please help me. > > > Q1: when we are working with more than one CPU, there will be a shared > L2 cache for all the CPUs

Re: PEBS event monitoring

2012-11-28 Thread Namhyung Kim
Hi Chulmin, On Thu, 29 Nov 2012 15:08:16 +0900, Chulmin Kim wrote: > Hi, all. > > Sorry for consecutive basic questions. > > I am about to use PEBS monitoring of Intel CPU. (westmere) > > Let me elaborate pfmon example a bit. > > % pfmon --smpl-module=pebs -einstructions_retired --inv=1 > --coun

Re: Queries on using PERF tool

2012-11-28 Thread Namhyung Kim
Hi, On Wed, 28 Nov 2012 15:02:43 +0900, Chulmin Kim wrote: > 2012-11-28 오후 2:47, Shahina Rabbani 쓴 글: >> Hi, >> >> I am a new user of PERF tool. I have few questions to ask about the PERF >> tool. >> Please help me with the answers. >> >> Q1. Is it possible to use PERF tool on a piece of code? Sa

Re: Multiple commands in perf 3.2.30 and 3.5.5 on Ubuntu 12 do not work

2012-11-14 Thread Namhyung Kim
Hi Florin, On Tue, 13 Nov 2012 23:01:18 + (UTC), Florin Trofin wrote: > I mentioned in a previous post that "perf archive" command is not recognized > on > Ubuntu 12.04 (perf version 3.2.30) although it is listed in the --help > output. > I wanted to see if the issue was fixed in a later ve

Re: [RFC] perf: proposed perf_event_open() manpage

2012-10-23 Thread Namhyung Kim
Hi Vince, Great work! On Tue, 23 Oct 2012 11:35:13 -0400 (EDT), Vince Weaver wrote: > Hello > > attached is a proposed manpage for the perf_event_open() system call. > > I'd appreciate any review or comments, especially for the parts marked > as FIXME or "[To be documented]" > > This system call

Re: perf top -z not working?

2012-10-22 Thread Namhyung Kim
On Mon, 22 Oct 2012 07:12:19 -0600, David Ahern wrote: > On 10/22/12 5:50 AM, Ryan Johnson wrote: > It seems that `perf top -z' does not behave as advertized, at > least not on the 3.2.0-25 kernel (Ubuntu) that I'm running. The > man page states that it should "zero history across displ

Re: Question about LLC-load-misses event

2012-10-22 Thread Namhyung Kim
Hi Chulmin, On Mon, 15 Oct 2012 22:31:34 +0900, Chulmin Kim wrote: > 2012-10-15 오후 10:07, Chulmin Kim 쓴 글: >> (perf command : perf stat -a -A -e LLC-loads -e LLC-load-misses -e >> instructions sleep 3) >> >> The problem is,, the bandwidth from STREAM benchmark does not match with >> the monitored

Re: [PATCH v3] memory leak fix while calling system_path

2012-09-16 Thread Namhyung Kim
Hi, On Fri, 14 Sep 2012 11:14:13 +0800, liang xie wrote: > memory leak fix while calling system_path > > Since v1: Remove an unnecessary null pointer check per Felipe's comments > Since v2: Make system_path&perf_exec_path always return dynamically > allocated string > > Signed-off-by: xieliang >

Re: [PATCH v2] A trivial memory leak fix while calling system_path

2012-09-06 Thread Namhyung Kim
Hi, liang On Fri, 7 Sep 2012 11:34:49 +0800, liang xie wrote: > A trivial memory leak fix while calling system_path > > Since v1: Remove an unnecessary null pointer check per Felipe's comments > > Signed-off-by: Liang Xie > --- > tools/perf/util/exec_cmd.c |4 +++- > tools/perf/util/help.c

Re: attr inherit vs inherit_stat

2012-09-06 Thread Namhyung Kim
(Adding peterz in case he has a time to answer) On Thu, 6 Sep 2012 11:19:21 -0400, Vince Weaver wrote: > On Tue, 4 Sep 2012, Namhyung Kim wrote: >> >> AFAIK the "inherit" field determines whether the event is inherited to a >> child process/thread. The "inher

Re: attr inherit vs inherit_stat

2012-09-04 Thread Namhyung Kim
On Tue, 7 Aug 2012 15:47:32 -0400, Vince Weaver wrote: > Hello Hello Vince, > > I'm trying to figure out the difference between the "inherit" and > "inherit_stat" bitfields in the perf_event_attr structure. > > Both seem to have similar functionality, and the code in core.c > is hard to follow. >

Re: How to trace threads created by a process after perf has started recording, using the -p PID flag?

2012-09-03 Thread Namhyung Kim
Hi, Mikolaj On Tue, 4 Sep 2012 00:17:50 +0200, Mikolaj Konarski wrote: >>> Could someone clarify the behaviour of the -p PID flag of perf-record? >>> In our experiments (3.2.0-27 #43-Ubuntu SMP x86_64), >>> it ignores events on threads spawned after perf-record is started. >>> Is this the intended

Re: Perf tool cross build issue

2012-08-15 Thread Namhyung Kim
Hi, Koteswararao On Tue, 14 Aug 2012 12:00:12 +0900, Koteswararao Nelakurthi wrote: > Dear Perf developers, > > > I am trying to cross compile Perf source present in 2.6.35/tools/perf 2.6.35? That's too old. Can't you try it with more recent version? Thanks, Namhyung > directory for ARM.in ubu

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Namhyung Kim
Hi, Arun On Wed, 8 Aug 2012 12:16:30 -0700, Arun Sharma wrote: > On 3/30/12 10:43 PM, Arun Sharma wrote: >> [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] >> >> v6 ChangeLog: >> >> rebased to tip:perf/core and fixed a minor problem in computing >> the total period in hists__re

Re: [RFD] perf: events defined contexts (was Re: perf: prctl(PR_TASK_PERF_EVENTS_DISABLE) has no effect)

2012-08-05 Thread Namhyung Kim
Hi, On Fri, 27 Jul 2012 14:45:38 +0200, Jiri Olsa wrote: > On Fri, Jul 27, 2012 at 01:56:36PM +0200, Frederic Weisbecker wrote: >> The problem is more general than that I think. >> We need to be able to define finer grained contexts than just >> "task" and/or "CPU". >> >> And reusing events thems

Re: Callgraph like kcachegrind

2012-07-05 Thread Namhyung Kim
Hi, On Fri, Jul 6, 2012 at 9:50 AM, Arun Sharma wrote: > On 7/5/12 5:27 PM, Namhyung Kim wrote: >> >> On Wed, 4 Jul 2012 21:44:28 -0300, Arnaldo Carvalho de Melo wrote: >>> >>> Em Thu, Jun 28, 2012 at 02:59:39PM +0200, Christoph Bartoschek escreveu: >>

Re: Callgraph like kcachegrind

2012-07-05 Thread Namhyung Kim
On Wed, 4 Jul 2012 21:44:28 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 28, 2012 at 02:59:39PM +0200, Christoph Bartoschek escreveu: >> is it somehow possible to get a callgraph like gets it from kcachegrind? >> >> I tried to use -g/-G on a program that runs but the information is not as

Re: Minor fix

2012-06-24 Thread Namhyung Kim
Hi, Alexis On Mon, 25 Jun 2012 00:33:43 +0200, Alexis Berlemont wrote: > Hi, > > Has anyway try to compile perf at the latest tag (v3.5-rc4) or on > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git ? > > I did not manage to do it without this little fix. > > Did I miss somethin

Re: Perf 2.6.32-220.el6.x86_64 problem when recording 2 counters

2012-05-23 Thread Namhyung Kim
Hi, On Wed, 23 May 2012 18:06:59 +0200, HUMMEL Michel wrote: > Hello, > I am testing the perf command of my new centos 6.2 server, and I don't > understand something. > My Conf : > > $ grep name /proc/cpuinfo > model name : Int

Re: using perf lock

2012-05-23 Thread Namhyung Kim
Hi, On Wed, 23 May 2012 15:42:42 + (UTC), Hank wrote: > I've been trying to use perf lock command on my Ubuntu 12.04, but I'm getting > this error: > > invalid or unsupported event: 'lock:lock_acquire' > > What might be the problem? Should I get the kernel source code? > Maybe due to the ker

Re: [BUG] perf top -G is broken

2012-05-03 Thread Namhyung Kim
Hi, On Wed, 2 May 2012 13:02:50 -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, May 02, 2012 at 11:50:45AM +0900, Namhyung Kim escreveu: >> Some guy reported me that perf top -G is broken with segment fault. I >> can reproduce it on my system easily but the time is vary - few s

[BUG] perf top -G is broken

2012-05-01 Thread Namhyung Kim
Hi, Some guy reported me that perf top -G is broken with segment fault. I can reproduce it on my system easily but the time is vary - few seconds to 30 minutes. I ran it with --stdio to get a core file: $ sudo ./perf top -G --stdio > /dev/null [sudo] password for namhyung: Failed to open /tmp/p

Re: LLC-* events not working on sandybridge

2012-05-01 Thread Namhyung Kim
Hi, On Mon, 30 Apr 2012 18:50:39 +0100, David Wragg wrote: > Namhyung Kim writes: >> On Sun, 29 Apr 2012 00:03:14 +0100, David Wragg wrote: >>> I've run into a problem with perf on an Intel Sandybridge machine: The >>> LLC-* events never seem to trigger. >>

Re: LLC-* events not working on sandybridge

2012-04-30 Thread Namhyung Kim
Hi, On Sun, 29 Apr 2012 00:03:14 +0100, David Wragg wrote: > Hi, > > I've run into a problem with perf on an Intel Sandybridge machine: The > LLC-* events never seem to trigger. > > For example: > > $ perf stat -e LLC-load-misses ls / > [...] > 0 LLC-load-misses > >0.00108

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v4)

2012-03-14 Thread Namhyung Kim
The user can then drill down into the callchains of functions that have high inclusive times. Sample command lines: $ perf record -ag -- sleep 1 $ perf report -g graph,0.5,callee -n -s inclusive Reviewed-by: Namhyung Kim Thanks, looks good to me now - although I still prefer make it a switch

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v3)

2012-03-13 Thread Namhyung Kim
ker Cc: Mike Galbraith Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Stephane Eranian Cc: Namhyung Kim Cc: Tom Zanussi Cc: linux-ker...@vger.kernel.org Cc: linux-perf-users@vger.kernel.org --- tools/perf/builtin-annotate.c |2 +- tools/perf/builtin-diff.c |2 +- tools/perf/builtin-repor

Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

2012-03-12 Thread Namhyung Kim
Hi, 2012-03-13 4:58 AM, Arun Sharma wrote: On 3/12/12 11:21 AM, Arun Sharma wrote: BTW, I don't like the name 'inclusive' as a sort key. If it cares about time, IMHO, the name should contain 'time' - something like 'itime' or 'inctime'? The existing sort orders: pid, comm, dso, symbol, parent

Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

2012-03-12 Thread Namhyung Kim
2012-03-13 3:21 AM, Arun Sharma wrote: On 3/12/12 12:43 AM, Namhyung Kim wrote: Known bugs: total_period computation is broken for order=callee I'd like to add two more :). * If perf record misses callchain info, perf report will get stuck. * If it's used with "symbol&quo

Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

2012-03-12 Thread Namhyung Kim
2012-03-13 3:05 AM, Arun Sharma wrote: On 3/12/12 12:15 AM, Namhyung Kim wrote: I think it's because of the shared hist_entry. If a callchain is a subset of another, it will be marked as inclusive so that it cannot be contributed to total period. Say, there're two chains - X (a ->

Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

2012-03-12 Thread Namhyung Kim
Hi, 2012-03-08 7:41 AM, Arun Sharma wrote: This patch series refactors existing code a bit and adds sort by inclusive time (time spent in the function + callees). Sample command lines: # perf record -ag -- sleep 1 # perf report -g graph,0.5,callee -n -s inclusive Known bugs: total_period com

Re: [PATCH 0/2] perf: add sort by inclusive time functionality (v2)

2012-03-12 Thread Namhyung Kim
Hi, 2012-03-09 3:49 AM, Arun Sharma wrote: On 3/8/12 7:31 AM, Frederic Weisbecker wrote: On Thu, Mar 08, 2012 at 08:29:01AM +0100, Ingo Molnar wrote: * Arun Sharma wrote: This patch series refactors existing code a bit and adds sort by inclusive time (time spent in the function + callees).