Re: [PATCH] [PPC32] ADMA support for PPC 440SPe processors.

2007-03-19 Thread Stefan Roese
On Tuesday 20 March 2007 04:06, Michael Ellerman wrote: > On Mon, 2007-03-19 at 17:13 +0100, Benjamin Herrenschmidt wrote: > > BTW folks. Would it be hard to change your spe_ prefixes to something > > else ? There's already enough confusion between the freescale SPE unit > > and the cell SPEs :-) >

Re: [PATCH] [PPC32] ADMA support for PPC 440SPe processors.

2007-03-17 Thread Stefan Roese
On Saturday 17 March 2007 19:17, Dan Williams wrote: > Yes, defaulting to 'y' is not necessary, but ASYNC_TX_DMA=y && > DMA_ENGINE=n is an explicit feature of the interface. When DMA_ENGINE > is not selected all the asynchronous paths in the API are compiled > out. This allows subsytems, like md-

Re: [PATCH] [PPC32] ADMA support for PPC 440SPe processors.

2007-03-17 Thread Stefan Roese
Dan, I just noticed that your patch "dmaengine: add the async_tx api": @@ -22,6 +22,17 @@ config NET_DMA Since this is the main user of the DMA engine, it should be enabled; say Y here. +config ASYNC_TX_DMA + tristate "Asynchronous Bulk Memory Transfers/Transforms API"

Re: [PATCH] [PPC32] ADMA support for PPC 440SPe processors.

2007-03-16 Thread Stefan Roese
On Friday 16 March 2007 09:29, Benjamin Herrenschmidt wrote: > > + /* > > +* Map registers > > +*/ > > + i2o_reg = (i2o_regs_t *)ioremap64(I2O_MMAP_BASE, I2O_MMAP_SIZE); > > + dma_reg0 = (dma_regs_t *)ioremap64(DMA0_MMAP_BASE, DMA_MMAP_SIZE); > > + dma_reg1 = (dma_regs_t *)ioremap6