Re: [PATCH] opensm: add force_link_speed_file config option.

2009-10-15 Thread Dave Olson
On Thu, 15 Oct 2009, Ira Weiny wrote: | > And what about width and other potentially tunable port parameters? | | I don't think width is "tunable" via the spec. The force_link_speed option | was a non-standard work around for potentially bad hardware. I was trying to | avoid going down the non-s

Re: [PATCH] opensm: add force_link_speed_file config option.

2009-10-15 Thread Ira Weiny
On Thu, 15 Oct 2009 23:26:01 +0200 Sasha Khapyorsky wrote: > Hi Ira, > > On 13:26 Thu 15 Oct , Ira Weiny wrote: > > > > From: Ira Weiny > > Date: Wed, 14 Oct 2009 16:09:25 -0700 > > Subject: [PATCH] opensm: add force_link_speed_file config option. > > > > From the config file help: >

Re: [PATCHv3] opensm: Reduce heap consumption by multicast routing tables (MFTs)

2009-10-15 Thread Hal Rosenstock
On Thu, Oct 15, 2009 at 4:42 PM, Sasha Khapyorsky wrote: > On 17:35 Wed 14 Oct     , Hal Rosenstock wrote: >> >> Heap memory consumption by the unicast and multicast routing tables can be >> reduced. >> >> This patch is analagous to the previous patch doing this for the unicast >> routing tables (

[PATCHv4] opensm: Reduce heap consumption by multicast routing tables (MFTs)

2009-10-15 Thread Hal Rosenstock
Heap memory consumption by the unicast and multicast routing tables can be reduced. This patch is analagous to the previous patch doing this for the unicast routing tables (LFTs). Using valgrind --tool=massif (for heap profiling), there are couple of place ->38.75% (11,206,656B) 0x43267E: osm_sw

Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency

2009-10-15 Thread Yevgeny Kliteynik
Sasha Khapyorsky wrote: On 09:36 Thu 15 Oct , Hal Rosenstock wrote: Signed-off-by: Hal Rosenstock --- diff --git a/opensm/opensm/osm_ucast_cache.c b/opensm/opensm/osm_ucast_cache.c index 31a5333..8db9df2 100644 --- a/opensm/opensm/osm_ucast_cache.c +++ b/opensm/opensm/osm_ucast_cache.c @@ -

[PATCH] opensm/osm_ucast_cache: reduce OSM_LOG_INFO debug printouts

2009-10-15 Thread Sasha Khapyorsky
Convert debug log messages to use OSM_LOG_DEBUG level (instead of OSM_LOG_INFO), add cache invalidation verbose message (OSM_LOG_VERBOSE level). Signed-off-by: Sasha Khapyorsky --- opensm/opensm/osm_ucast_cache.c | 91 +-- 1 files changed, 40 insertions(+),

Re: [PATCH] link-local address fix for rdma_resolve_addr

2009-10-15 Thread Jason Gunthorpe
On Thu, Oct 15, 2009 at 12:27:21PM -0700, David J. Wilder wrote: > On Wed, 2009-10-14 at 13:09 Jason Gunthorpe wrote: > > > So, it tries to match the source addr to the addrs bound to the > > device, which is wrong - that isn't how the ip stack works. > > > You can patch this up a little bit by f

Re: [ofa-general][PATCH 3/4] SRP fail-over faster

2009-10-15 Thread Jason Gunthorpe
On Thu, Oct 15, 2009 at 03:25:15PM -0400, David Dillow wrote: > On Thu, 2009-10-15 at 09:23 -0700, Vu Pham wrote: > > David Dillow wrote: > > > And if I want to disable this completely? > > > > > > > Unless these patches are bad and affect the stability of the driver, why > > do you want to di

[PATCH V2] opensm: add force_link_speed_file config option.

2009-10-15 Thread Ira Weiny
From: Ira Weiny Date: Wed, 14 Oct 2009 16:09:25 -0700 Subject: [PATCH] opensm: add force_link_speed_file config option. From the config file help: # Optional file used to override individual port GUIDs and speeds to be forced. # Port GUIDs which are _not_ listed in this

Re: [PATCH] opensm: add force_link_speed_file config option.

2009-10-15 Thread Sasha Khapyorsky
Hi Ira, On 13:26 Thu 15 Oct , Ira Weiny wrote: > > From: Ira Weiny > Date: Wed, 14 Oct 2009 16:09:25 -0700 > Subject: [PATCH] opensm: add force_link_speed_file config option. > > From the config file help: > > # Optional file used to override individual port GUIDs and speeds to

Re: [PATCH] opensm/osm_lid_mgr.c: Cosmetic commentary changes

2009-10-15 Thread Sasha Khapyorsky
On 14:43 Thu 15 Oct , Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCHv2] opensm/osm_ucast_updn.c: Further reduction in cas_per_sw allocation

2009-10-15 Thread Sasha Khapyorsky
On 16:00 Thu 15 Oct , Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock Applied. Thanks. Sasha -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency

2009-10-15 Thread Sasha Khapyorsky
On 15:43 Thu 15 Oct , Hal Rosenstock wrote: > On Thu, Oct 15, 2009 at 3:26 PM, Sasha Khapyorsky wrote: > > On 09:36 Thu 15 Oct     , Hal Rosenstock wrote: > >> > >> Signed-off-by: Hal Rosenstock > >> --- > >> diff --git a/opensm/opensm/osm_ucast_cache.c > >> b/opensm/opensm/osm_ucast_cache.c

Re: [PATCHv3] opensm: Reduce heap consumption by multicast routing tables (MFTs)

2009-10-15 Thread Sasha Khapyorsky
On 17:35 Wed 14 Oct , Hal Rosenstock wrote: > > Heap memory consumption by the unicast and multicast routing tables can be > reduced. > > This patch is analagous to the previous patch doing this for the unicast > routing tables (LFTs). > > Using valgrind --tool=massif (for heap profiling), t

Re: [PATCH] opensm: add force_link_speed_file config option.

2009-10-15 Thread Ira Weiny
Sasha, Hal caught that I am not freeing the force_link_speed_except_guids on shutdown. V2 coming shortly. Ira On Thu, 15 Oct 2009 13:26:50 -0700 Ira Weiny wrote: > > From: Ira Weiny > Date: Wed, 14 Oct 2009 16:09:25 -0700 > Subject: [PATCH] opensm: add force_link_speed_file config option.

[PATCH] opensm: add force_link_speed_file config option.

2009-10-15 Thread Ira Weiny
From: Ira Weiny Date: Wed, 14 Oct 2009 16:09:25 -0700 Subject: [PATCH] opensm: add force_link_speed_file config option. From the config file help: # Optional file used to override individual port GUIDs and speeds to be forced. # Port GUIDs which are _not_ listed in this

[PATCH 7/8] trivial: fix many typos s/untill/until/

2009-10-15 Thread Thadeu Lima de Souza Cascardo
Signed-off-by: Thadeu Lima de Souza Cascardo --- drivers/infiniband/ulp/iser/iser_verbs.c |2 +- drivers/net/bonding/bond_alb.c |2 +- drivers/net/wireless/rt2x00/rt2800usb.c |2 +- drivers/scsi/bnx2i/bnx2i_iscsi.c |2 +- drivers/staging/rtl8187se/r8180.h

[PATCH] opensm/osm_lid_mgr.c: Cosmetic commentary changes

2009-10-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/opensm/opensm/osm_lid_mgr.c b/opensm/opensm/osm_lid_mgr.c index 74b5e39..990c26e 100644 --- a/opensm/opensm/osm_lid_mgr.c +++ b/opensm/opensm/osm_lid_mgr.c @@ -175,8 +175,8 @@ static void lid_mgr_validate_db(IN osm_lid_mgr_t * p_mgr)

[PATCHv2] opensm/osm_ucast_updn.c: Further reduction in cas_per_sw allocation

2009-10-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- Changes since v1: Use cl_ptr_vector_get_size for max lid diff --git a/opensm/opensm/osm_ucast_updn.c b/opensm/opensm/osm_ucast_updn.c index ced076a..e81a299 100644 --- a/opensm/opensm/osm_ucast_updn.c +++ b/opensm/opensm/osm_ucast_updn.c @@ -432,13 +432,14 @@ st

Re: [ofa-general][PATCH 3/4] SRP fail-over faster

2009-10-15 Thread David Dillow
On Thu, 2009-10-15 at 09:23 -0700, Vu Pham wrote: > David Dillow wrote: > > And if I want to disable this completely? > > > > Unless these patches are bad and affect the stability of the driver, why > do you want to disable it? If you don't use multipath/device-mapper and > use /dev/sd**, eve

Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency

2009-10-15 Thread Hal Rosenstock
On Thu, Oct 15, 2009 at 3:26 PM, Sasha Khapyorsky wrote: > On 09:36 Thu 15 Oct     , Hal Rosenstock wrote: >> >> Signed-off-by: Hal Rosenstock >> --- >> diff --git a/opensm/opensm/osm_ucast_cache.c >> b/opensm/opensm/osm_ucast_cache.c >> index 31a5333..8db9df2 100644 >> --- a/opensm/opensm/osm_u

RE: [ofw] Re: [PATCH] osmtest - Add OSM_CDECL to main() declaration

2009-10-15 Thread Smith, Stan
Hefty, Sean wrote: >>> Sean maintains a separate set of patches applied to IB diags in >>> order to >> address issues like the x86 requirement for __cdecl on main(). >>> Since OSM_CDECL was already defined in OFED opensm, it did not seem >>> to be a >> major concession to prefix main() with it. >>>

Re: [PATCH] link-local address fix for rdma_resolve_addr

2009-10-15 Thread David J. Wilder
On Wed, 2009-10-14 at 13:09 Jason Gunthorpe wrote: > So, it tries to match the source addr to the addrs bound to the > device, which is wrong - that isn't how the ip stack works. > You can patch this up a little bit by fixing up addr_resolve_local to > set sin6_scope_ip. I found the bug in addr_

Re: [PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency

2009-10-15 Thread Sasha Khapyorsky
On 09:36 Thu 15 Oct , Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock > --- > diff --git a/opensm/opensm/osm_ucast_cache.c b/opensm/opensm/osm_ucast_cache.c > index 31a5333..8db9df2 100644 > --- a/opensm/opensm/osm_ucast_cache.c > +++ b/opensm/opensm/osm_ucast_cache.c > @@ -876,7 +876

Re: [PATCH] opensm/osm_ucast_updn.c: Further reduction in cas_per_sw memory allocation

2009-10-15 Thread Sasha Khapyorsky
On 09:34 Thu 15 Oct , Hal Rosenstock wrote: > > Signed-off-by: Hal Rosenstock > --- > diff --git a/opensm/opensm/osm_ucast_updn.c b/opensm/opensm/osm_ucast_updn.c > index ced076a..c46b033 100644 > --- a/opensm/opensm/osm_ucast_updn.c > +++ b/opensm/opensm/osm_ucast_updn.c > @@ -424,7 +424,7 @

Re: [PATCH] opensm/opensm/osm_subnet.c: adjust buffer to ensure a '\n' is printed

2009-10-15 Thread Sasha Khapyorsky
On 17:21 Wed 14 Oct , Ira Weiny wrote: > > From: Ira Weiny > Date: Wed, 14 Oct 2009 17:05:53 -0700 > Subject: [PATCH] opensm/opensm/osm_subnet.c: adjust buffer to ensure a '\n' > is printed > > When printing cached options strings which fill the print buffer. > Adjust the length

Re: [ofa-general][PATCH 3/4] SRP fail-over faster

2009-10-15 Thread Vu Pham
David Dillow wrote: On Wed, 2009-10-14 at 15:47 -0700, Roland Dreier wrote: > First it does not make sense for user to set it below 60; therefore, > > > it is forced to have 60 and above > > Why not? A minute seems to be a really long time given the point of > > these patches

[PATCH] opensm/osm_ucast_updn.c: Further reduction in cas_per_sw memory allocation

2009-10-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/opensm/opensm/osm_ucast_updn.c b/opensm/opensm/osm_ucast_updn.c index ced076a..c46b033 100644 --- a/opensm/opensm/osm_ucast_updn.c +++ b/opensm/opensm/osm_ucast_updn.c @@ -424,7 +424,7 @@ static void updn_find_root_nodes_by_min_hop(OUT updn_t * p_up

[PATCH] opensm/osm_ucast_cache.c: Cosmetic change to log message for consistency

2009-10-15 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/opensm/opensm/osm_ucast_cache.c b/opensm/opensm/osm_ucast_cache.c index 31a5333..8db9df2 100644 --- a/opensm/opensm/osm_ucast_cache.c +++ b/opensm/opensm/osm_ucast_cache.c @@ -876,7 +876,7 @@ void osm_ucast_cache_add_link(osm_ucast_mgr_t * p_mgr,