Re: [PATCH] IB/rds: use IB_CQ_REPORT_MISSED_EVENTS to avoid missed CQ callbacks

2010-03-30 Thread Ralph Campbell
On Tue, 2010-03-30 at 16:30 -0700, Roland Dreier wrote: > > OpenFabrics added a IB_CQ_REPORT_MISSED_EVENTS flag to detect this > > OpenFabrics? Funny, I thought I added that flag. You did. I can change the comment if you like. > (This is not a serious objection ... I'm just being annoying. Bei

Re: [PATCH] IB/rds: use IB_CQ_REPORT_MISSED_EVENTS to avoid missed CQ callbacks

2010-03-30 Thread Roland Dreier
> OpenFabrics added a IB_CQ_REPORT_MISSED_EVENTS flag to detect this OpenFabrics? Funny, I thought I added that flag. (This is not a serious objection ... I'm just being annoying. Being serious, I'm happy to see this used outside of IPoIB and this looks like a good optimization) > This patch

[PATCH] IB/rds: use IB_CQ_REPORT_MISSED_EVENTS to avoid missed CQ callbacks

2010-03-30 Thread Ralph Campbell
ib_req_notify_cq(IB_CQ_NEXT_COMP) is not guaranteed to generate a callback for the next completion entered since there is a race between arming the callback and another CQE being added to the queue. OpenFabrics added a IB_CQ_REPORT_MISSED_EVENTS flag to detect this race and allow the verbs consumer