Mellanox implementation for atomic operations

2010-05-10 Thread lihaidong
Hi, I have a question about atomic operations. According to IB specification o10-48, all atomic operation request made to the same HCA, referencing the same physical memory are serialized with respect to each other. I know this should be complied with if HCA supports atomic operations,

Re: [PATCH 2/4] ib_core: implement XRC RCV qp's

2010-05-10 Thread Jack Morgenstein
On Thursday 06 May 2010 01:56, Roland Dreier wrote:   In my original implementation, the low-level driver was responsible for generating   the events for all the processes.  To move this mechanism to the core would require   a fairly extensive re-write.  I would need to introduce ib_core

Re: [PATCH 2/4] ib_core: implement XRC RCV qp's

2010-05-10 Thread Jack Morgenstein
On Monday 10 May 2010 13:01, Jack Morgenstein wrote: I have an initial implementation of this which I will clean up and send you for review (actually, an implementation which has the ib_create_xrc_rcv_qp/ib_destroy_xrc_rcv_qp, and which does not need the low-level driver implementations of

Re: [PATCH 7/7] CQ overflow detection giving false positives

2010-05-10 Thread Roland Dreier
All look fine... I rolled them up into the patch adding iw_cxgb4 (might as well have the initial driver merge have all know fixes). -- Roland Dreier rola...@cisco.com || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe

[PATCH] RDMA/ucma: Copy iWARP route information.

2010-05-10 Thread Steve Wise
For iWARP rdma_cm ids, the route information is the L2 src and next hop addresses. Signed-off-by: Steve Wise sw...@opengridcomputing.com --- drivers/infiniband/core/ucma.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/core/ucma.c

Re: [PATCH 1/2] RDMA/core: add support for iWarp multicast acceleration over IB_QPT_RAW_ETY QP type

2010-05-10 Thread Steve Wise
Hey Roland, Do you have thoughts on this change? It is useful along with the IBV_QPT_RAW_ETY type added to libibverbs for cxgb devices too. Steve. miroslaw.walukiew...@intel.com wrote: The patch enables usage of attach_mcast()/detach_mcast driver specific verbs for iWARP devices. IB path

RE: [PATCH] ummunotify: Userspace support for MMU notifications V2

2010-05-10 Thread Sean Hefty
As discussed in http://article.gmane.org/gmane.linux.drivers.openib/61925 and follow-up messages, libraries using RDMA would like to track precisely when application code changes memory mapping via free(), munmap(), etc. Current pure-userspace solutions using malloc hooks and other tricks

Re: [PATCH 5/37] librdmacm: replace query_route call with separate queries

2010-05-10 Thread Steve Wise
Hey Sean, You define global int af_ib_support. It never gets set to non-zero. Was this debug code or does it get set somewhere else that I'm missing? Steve. Sean Hefty wrote: To support other address families and multiple path records, replace the query_route call with specific query

RE: [PATCH 5/37] librdmacm: replace query_route call with separate queries

2010-05-10 Thread Sean Hefty
You define global int af_ib_support. It never gets set to non-zero. Was this debug code or does it get set somewhere else that I'm missing? It doesn't get set until a later patch in the series, once all the needed infrastructure is in place. - Sean -- To unsubscribe from this list: send the

Re: [PATCH v3 1/2] libibnetdisc: Convert to a multi-smp algorithm

2010-05-10 Thread Ira Weiny
On Fri, 7 May 2010 13:50:53 -0700 Sasha Khapyorsky sas...@voltaire.com wrote: Hi Ira, On 19:12 Thu 22 Apr , Ira Weiny wrote: On Tue, 13 Apr 2010 16:25:31 +0300 Sasha Khapyorsky sas...@voltaire.com wrote: On 13:46 Tue 13 Apr , Sasha Khapyorsky wrote: However see some

Re: [PATCH 5/37] librdmacm: replace query_route call with separate queries

2010-05-10 Thread Steve Wise
Sean Hefty wrote: You define global int af_ib_support. It never gets set to non-zero. Was this debug code or does it get set somewhere else that I'm missing? It doesn't get set until a later patch in the series, once all the needed infrastructure is in place. Ok I see it. It

IPoIB multiqueue support?

2010-05-10 Thread Christoph Lameter
I see that some IB nics can do multiqueu in ethernet mode. Is there any work on multiqueue support for IPoIB going on? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: IPoIB multiqueue support?

2010-05-10 Thread Roland Dreier
Is there any work on multiqueue support for IPoIB going on? No, although one could view connected mode as an even better place to start, since you already get perfect classification by remote peer for free. - R. -- Roland Dreier rola...@cisco.com || For corporate legal information go to:

Re: [PATCH v3 33/52] IB/qib: Add qib_sd7220.c

2010-05-10 Thread Roland Dreier
I don't think this is really a merge-blocker, but this code seems to have faith in the talismanic power of atomic_t to avoid races in nearby code. The following anti-pattern appears in a few other variants in the driver as well (just search for atomic_inc_return). +if

Re: [PATCH v3 18/52] IB/qib: Add qib_iba7322.c

2010-05-10 Thread Roland Dreier
+/* + * Setup QMH7342 receive and transmit parameters, necessary because + * each bay, Mez connector, and IB port need different tuning, beyond + * what the switch and HCA can do automatically. + * It's expected to be done by cat'ing files to the modules file, + * rather than setting