[PATCH 31/37] drivers/infiniband/core: Use kmemdup

2010-05-15 Thread Julia Lawall
From: Julia Lawall ju...@diku.dk Use kmemdup when some other buffer is immediately copied into the allocated region. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression from,to,size,flag; statement S; @@ - to =

Re: [PATCH 31/37] drivers/infiniband/core: Use kmemdup

2010-05-15 Thread Roland Dreier
looks good, applied, thanks. -- Roland Dreier rola...@cisco.com || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: [ewg] [PATCHv8 02/11] ib_core: IBoE support only QP1

2010-05-15 Thread Or Gerlitz
Eli Cohen wrote: Roland Dreier wrote: @@ -1007,7 +1010,7 @@ static void ib_sa_add_one(struct ib_device *device) - sa_dev = kmalloc(sizeof *sa_dev + + sa_dev = kzalloc(sizeof *sa_dev + Do you happen to remember why you needed these kmalloc - kzalloc conversions? I can't remember

Re: [ewg] [PATCHv8 03/11] IB/umad: Enable support only for IB ports

2010-05-15 Thread Or Gerlitz
Eli Cohen wrote: Roland Dreier wrote: Why do we not allow umad for IBoE ports? I understand there's no QP0 but why can't userspace use QP1 just like for IB link layer ports? Currently QP1 is only used by the CM protocol which is implemented in the kernel. Since we handle the iboe