[PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread Eli Cohen
Today, there are no means to know which port of a hardware device a netdev interface uses. This patch adds a new field to struct net_device that is used to store this value. The network driver should use the SET_NETDEV_PORT_NUM() macro to set the port number for the device it manages. For drivers

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread David Miller
From: Eli Cohen e...@mellanox.co.il Date: Wed, 26 May 2010 11:17:02 +0300 Today, there are no means to know which port of a hardware device a netdev interface uses. This patch adds a new field to struct net_device that is used to store this value. The network driver should use the

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread Eli Cohen
On Wed, May 26, 2010 at 01:39:26AM -0700, David Miller wrote: From: Eli Cohen e...@mellanox.co.il Date: Wed, 26 May 2010 11:17:02 +0300 Today, there are no means to know which port of a hardware device a netdev interface uses. This patch adds a new field to struct net_device that is

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread David Miller
From: Eli Cohen e...@dev.mellanox.co.il Date: Wed, 26 May 2010 11:45:23 +0300 Do you think we should use dev_id also for the sysfs file name so every driver can choose to interpret this field as it chooses to, or should I keep the sysfs file name as port_number? What's wrong with using the

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread Eli Cohen
On Wed, May 26, 2010 at 01:55:26AM -0700, David Miller wrote: From: Eli Cohen e...@dev.mellanox.co.il Date: Wed, 26 May 2010 11:45:23 +0300 What's wrong with using the existing dev_id sysfs file name and saying that it means the port number of the card? Nobody, and I really mean nobody,

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread David Miller
From: Eli Cohen e...@dev.mellanox.co.il Date: Wed, 26 May 2010 12:08:52 +0300 So if I understand you correctly, you think that I should not bother to set a default value of 1. Each driver that cares about the value of this field, will set it however they want. I actually mean that the value 0

Re: [PATCH] net/core: Save the port number a netdevice uses

2010-05-26 Thread Eli Cohen
On Wed, May 26, 2010 at 02:16:35AM -0700, David Miller wrote: I actually mean that the value 0 should mean the first port, the value 1 should mean the second port, etc. OK, thanks for clarifying. I'll send a new patch soon. -- To unsubscribe from this list: send the line unsubscribe

[PATCH] net/core: use net_device dev_id to indicate port number

2010-05-26 Thread Eli Cohen
Today, there are no means to know which port of a hardware device a netdev interface uses. struct net_device conatins a field, dev_id, that can be used for that. This patch adds a new macro, SET_NETDEV_DEV_ID(), to provide a standard way to set the value of this field. Also also make use of this

Re: [PATCH] mlx4_en: show device's port used

2010-05-26 Thread Tziporet Koren
On 5/26/2010 12:32 AM, Roland Dreier wrote: I don't think there are many devices out there which have more than one port. ?? http://developer.intel.com/network/connectivity/solutions/gigabit.htm http://www.broadcom.com/products/Ethernet-Controllers/Enterprise-Server/BCM5704C etc

Re: [PATCH] net/core: use net_device dev_id to indicate port number

2010-05-26 Thread Eli Cohen
On Wed, May 26, 2010 at 08:23:06AM -0700, Stephen Hemminger wrote: On Wed, 26 May 2010 12:52:00 +0300 Eli Cohen e...@mellanox.co.il wrote: Today, there are no means to know which port of a hardware device a netdev interface uses. struct net_device conatins a field, dev_id, that can be used

Re: [PATCH] net/core: use net_device dev_id to indicate port number

2010-05-26 Thread Stephen Hemminger
On Wed, 26 May 2010 18:27:30 +0300 Eli Cohen e...@dev.mellanox.co.il wrote: On Wed, May 26, 2010 at 08:23:06AM -0700, Stephen Hemminger wrote: On Wed, 26 May 2010 12:52:00 +0300 Eli Cohen e...@mellanox.co.il wrote: Today, there are no means to know which port of a hardware device a

[PATCH] IB/qib: fix powerpc compile warnings

2010-05-26 Thread Ralph Campbell
Fix the compile warnings for uninitialized variables in qib_fs.c when compiling for powerpc. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_fs.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] IB/core User RMPP patch

2010-05-26 Thread Mike Heinz
Currently, if a user application calls umad_register() or umad_register_oui() with an rmpp_version of zero, incoming rmpp messages are discarded. This patch changes this behavior so that rmpp_version of zero causes incoming rmpp packets to be passed through without alteration, instead.

RE: [ANNOUNCE] librdmacm 1.0.12

2010-05-26 Thread Hefty, Sean
I'm not an expert of code, but I read this thread and I understand that new librdmacm version will be easier for users. New APIs were added to the librdmacm that make it easier for a developer to establish a connection over an RDMA device. Additionally, wrappers were added around several of

[PATCH] IB/qib: use a single txselect module parameter for serdes tuning

2010-05-26 Thread Ralph Campbell
As part of the earlier patches submitted and reviewed, it was agreed to change the way serdes tuning parameters were specified to the driver. The updated patch got dropped by the linux-rdma email list so the earlier version of qib_iba7322.c was integrated. This patch updates qib_iab7322.c with the

Re: [PATCH] IB/qib: use a single txselect module parameter for serdes tuning

2010-05-26 Thread Roland Dreier
sorry about that... somehow I messed this up. Anyway, I applied this patch. -- Roland Dreier rola...@cisco.com || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line unsubscribe linux-rdma in

[PATCH] mlx4_en: use net_device dev_id to indicate port number

2010-05-26 Thread Eli Cohen
Today, there are no means to know which port of a hardware device a netdev interface uses. struct net_device conatins a field, dev_id, that can be used for that. Use this field to save the port number in ConnectX that is being used by the net device; port numbers are zero based. Signed-off-by: