[RFC 0/12] ib-mgmt: port madeye to user space

2010-10-23 Thread Hefty, Sean
In short, this series ports the kernel madeye debug utility to user space. It builds on the updated kernel MAD snooping functionality patches recently submitted to this list. In length, the series adds the following to the ib-mgmt tree: * Adds the ability to snoop MADs to libibumad. * Adds new

[RFC 2/12] ib-mgmt: provide MAD definitions with libibumad

2010-10-23 Thread Hefty, Sean
The only definitions for MAD data types are in ib_types.h, which is an opensm file. The libibumad interface is essentially useless without these data types. Add new header files to libibumad with basic MAD data types. The definitions and structures are based on those defined in the linux

[RFC 3/12] ib-mgmt: add SA MAD definitions to umad

2010-10-23 Thread Hefty, Sean
Add a new header file, umad_sa.h, to libibumad that contains basic SA MAD definitions. Only the SA attributes values, new methods, and base SA MAD format are given. SA attribute structure definitions are left for future development. Signed-off-by: Sean Hefty sean.he...@intel.com ---

[RFC 4/12] ib-mgmt: Add basic SM definitions to umad

2010-10-23 Thread Hefty, Sean
Add a new header file, umad_sm.h, to libibumad that contains basic SM MAD definitions. Only the SM attributes values, new methods, and base SM MAD format are given. SM attribute structure definitions are left for future development. Signed-off-by: Sean Hefty sean.he...@intel.com ---

[RFC 6/12] ib-mgmt: add new umad header files to release

2010-10-23 Thread Hefty, Sean
What good are the new header files if we don't install them? Not much, so let's install 'em. Signed-off-by: Sean Hefty sean.he...@intel.com --- libibumad/Makefile.am |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libibumad/Makefile.am b/libibumad/Makefile.am index

[RFC 7/12] ib-mgmt: update mad.h to use umad_types.h

2010-10-23 Thread Hefty, Sean
Update mad.h to include umad_types.h and use the umad definitions. The data type names in mad.h are kept for backwards compatibility, until all applications update to using the umad names. Signed-off-by: Sean Hefty sean.he...@intel.com --- libibmad/include/infiniband/mad.h | 173

[RFC 8/12] ib-mgmt: fix trace table response

2010-10-23 Thread Hefty, Sean
A response to a get trace table request is a get table response. There is no 'get trace table response'. See IB spec 1.2.1, section 15.4.9. Signed-off-by: Sean Hefty sean.he...@intel.com --- Separating out this change, so the 'fix' is clear. libibmad/include/infiniband/mad.h |2 +- 1 files

[RFC 9/12] ib-mgmt: convert ib_types.h to use umad types

2010-10-23 Thread Hefty, Sean
Several data type definitions have been added to umad. Update ib_types.h to make use of these definitions. For backwards compatibility, the existing names in ib_types.h are kept until they can be deprecated. Signed-off-by: Sean Hefty sean.he...@intel.com --- opensm/include/iba/ib_types.h | 186

[RFC 10/12] ib-mgmt: remove duplicate definition of IB_MAD_STATUS_CLASS_MASK

2010-10-23 Thread Hefty, Sean
osmtest includes a duplicate definition. Remove it. The update to ib_types.h results in a build warning without this fix. Signed-off-by: Sean Hefty sean.he...@intel.com --- opensm/osmtest/osmtest.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) mode change 100644 = 100755

[RFC 11/12] ib-mgmt: move ntohll/htonll from mad.h to umad.h

2010-10-23 Thread Hefty, Sean
Users of umad require ntohll/htonll to set/extract data from MADs. Move the definition from libibmad to libibumad. Signed-off-by: Sean Hefty sean.he...@intel.com --- libibmad/include/infiniband/mad.h | 29 + libibmad/include/infiniband/mad_osd.h |2 --

[RFC 12/12] ib-mgmt/diags: add utility to display snooped mads

2010-10-23 Thread Hefty, Sean
Port the kernel madeye utility to user space. Use the new MAD snooping ability exported from the kernel to view captured MADs and display them. Signed-off-by: Sean Hefty sean.he...@intel.com --- infiniband-diags/Makefile.am |6 infiniband-diags/configure.in |3

Re: [PATCH 2/5] IB/srp: implement SRP_CRED_REQ and SRP_AER_REQ

2010-10-23 Thread Bart Van Assche
On Mon, Oct 18, 2010 at 3:10 PM, David Dillow dillo...@ornl.gov wrote: [ ... ] While looking at this, I noticed that we didn't do any syncs in srp_send_tsk_mgmt(), so I've pushed this patch for now. We can remove the *_sync_for_cpu() calls later if it turns out we really don't need them. [

Re: [PATCH 2/5] IB/srp: implement SRP_CRED_REQ and SRP_AER_REQ

2010-10-23 Thread David Dillow
On Sat, 2010-10-23 at 12:47 +0200, Bart Van Assche wrote: On Mon, Oct 18, 2010 at 3:10 PM, David Dillow dillo...@ornl.gov wrote: [ ... ] While looking at this, I noticed that we didn't do any syncs in srp_send_tsk_mgmt(), so I've pushed this patch for now. We can remove the

Re: [RFC 3/12] ib-mgmt: add SA MAD definitions to umad

2010-10-23 Thread Jason Gunthorpe
On Sat, Oct 23, 2010 at 12:02:11AM -0700, Hefty, Sean wrote: +struct umad_sa_packet { + struct umad_hdr mad_hdr; + struct umad_rmpp_hdrrmpp_hdr; + uint8_t sm_key[8]; I would like to see a umad64_ne_t type for these 64 bit quanties. It can be 2 32 bit

Re: [RFC 11/12] ib-mgmt: move ntohll/htonll from mad.h to umad.h

2010-10-23 Thread Jason Gunthorpe
On Sat, Oct 23, 2010 at 12:12:58AM -0700, Hefty, Sean wrote: +#if __BYTE_ORDER == __LITTLE_ENDIAN + #ifndef ntohll +#define ntohll(x) bswap_64(x) + #endif +#elif __BYTE_ORDER == __BIG_ENDIAN + #ifndef ntohll +#define ntohll(x) (x) + #endif +#endif +#ifndef htonll + #define

Re: [PATCH] IPoIB: set dev_id field of IPoIB net_device

2010-10-23 Thread Roland Dreier
thanks, applied. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH] RDMA/UCMA: Allow tuning the max backlog.

2010-10-23 Thread Roland Dreier
thanks, applied. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: propagate node_description changes down to FW to generate trap 144

2010-10-23 Thread Roland Dreier
thanks, applied. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-23 Thread Roland Dreier
I'm lost on which initialization / cleanup fixes are the right ones to take for qib. Can someone point me to the definitive set of patches? - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [RFC 4/12] ib-mgmt: Add basic SM definitions to umad

2010-10-23 Thread Jason Gunthorpe
On Sat, Oct 23, 2010 at 12:03:18AM -0700, Hefty, Sean wrote: +struct umad_smp { + uint8_t base_version; + uint8_t mgmt_class; + uint8_t class_version; + uint8_t method; + uint16_t status; + uint8_t hop_ptr; + uint8_t hop_cnt; + uint64_t tid; +