On Monday 18 July 2011 19:39, Roland Dreier wrote:
On Mon, Jul 18, 2011 at 9:35 AM, Hefty, Sean sean.he...@intel.com wrote:
- if (ret !IS_ERR(id_priv-cm_id.ib)) {
+ if (ret !IS_ERR(id)) {
ib_destroy_cm_id(id_priv-cm_id.ib);
I would change the above line to
Roland, the enclosed patch series enhances the user space IB
stack to support IBoE. This work is based on earlier patches
done by Eli Cohen e...@mellanox.co.il and posted during
August/2010 see some pointers below.
One notable change from the previous post, is keeping the UD related
resolution
The new field has one of three values - IBV_LINK_LAYER_UNSPECIFIED,
IBV_LINK_LAYER_INFINIBAND, IBV_LINK_LAYER_ETHERNET. It can be used
by applications to know the link layer used by the port, which
can be either Infiniband or Ethernet.
The addition of the new field does not change the size of
Modify the code to allow passing the link layer of a port from the
kernel to the library.
The new field does not change the size of struct ibv_query_port_resp
as it replaces a reserved field. As such binary compatibility between
the kernel to the library is kept, since old kernel running below
Add IB GID change event which is generated by the kernel
IBoE stack when the HW driver updates the GID table.
Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il
Signed-off-by: Eli Cohen e...@mellanox.co.il
---
examples/asyncwatch.c |2 ++
include/infiniband/verbs.h |3 ++-
Since IBoE requires usage of GRH, update ibv_*_pinpong examples to accept
GIDs. GIDs are given as an index to the local port's table and are exchanged
between the client and the server through the socket connection.
Signed-off-by: Or Gerlitz ogerl...@mellanox.co.il
Signed-off-by: Eli Cohen
Modify libmlx4 to support IBoE, where the only user space piece
to handle is the creation of UD address handles - the L2 Ethernet
attributes have to be resolved from the DGID.
Derived from work by Eli Cohen e...@mellanox.co.il
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
src/mlx4.h |
Add VLANs support for the UD address handle creation flow,
where the vlan id is taken from the destination GID and the
and vlan priority from the IB SL specified by the application.
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
src/mlx4.h |1 +
src/qp.c|1 +
src/verbs.c |9
align the list of ConnectX devices supported by the library to be
the same as the mlx4 driver from the upstream kernel
Signed-off-by: Or Gerlitz ogerl...@mellanox.com
---
Roland, these two simple awk/cut commands can be used to
actually validate the claim made by the change log...
$ grep
On Tue, Jul 19, 2011 at 9:03 AM, David Dillow dillo...@ornl.gov wrote:
I Ack'd thinking Roland would pick it up directly since has done that in
the past for singe patches, but I'm fine with pulling it into my tree
and pushing that way.
Roland?
I've had it in my for-next branch for a while
On Tue, Jul 19, 2011 at 12:32:52PM +0300, Or Gerlitz wrote:
Modify libmlx4 to support IBoE, where the only user space piece
to handle is the creation of UD address handles - the L2 Ethernet
attributes have to be resolved from the DGID.
It seems a shame to add a kernel syscall to every ah
On Tue, 2011-07-19 at 07:24 -0400, Bart Van Assche wrote:
On Sat, Jun 25, 2011 at 6:14 PM, David Dillow dillo...@ornl.gov wrote:
On Sat, 2011-06-25 at 10:10 +0200, Bart Van Assche wrote:
So a SCSI driver must either take the channel and target id values in
account
in its quecommand()
On Tue, Jul 19, 2011 at 12:30:08PM +0300, Or Gerlitz wrote:
Add IB GID change event which is generated by the kernel
IBoE stack when the HW driver updates the GID table.
You also need to update ibv_event_type_str
Has a kernel patch that reserves/uses the corresponding ID been
accepted yet?
On Tue, Jul 19, 2011 at 12:27:17PM +0300, Or Gerlitz wrote:
The addition of the new field does not change the size of struct
ibv_port_attr due to alignment of the preceding fields. As such
binary compatibility between the library to applications is kept,
What zeros the field in the current
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
You also need to update ibv_event_type_str
sure, will do that.
Has a kernel patch that reserves/uses the corresponding ID been accepted yet?
yes, its in Roland's for-next branch
BTW, this has value for straight IB, hopefully it
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
Since IBoE requires usage of GRH, update ibv_*_pinpong examples to accept
GIDs. GIDs are given as an index to the local port's table and are exchanged
between the client and the server through the socket connection.
Since these examples
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
Or Gerlitz wrote:
Jason, as the change log explains, under Ethernet link type the code
(see mlx4_resolve_grh_to_l2) goes and extracts the Ethernet L2 info
(mac and vlan, look on the last patch) from the GID.
Looking at the control flow
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
Or Gerlitz wrote:
What zeros the field in the current library?
+ port_attr-link_layer = IBV_LINK_LAYER_UNSPECIFIED;
+ port_attr-pad = 0;
Or
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of
On Tue, Jul 19, 2011 at 11:22:51PM +0300, Or Gerlitz wrote:
Jason Gunthorpe jguntho...@obsidianresearch.com wrote:
Or Gerlitz wrote:
What zeros the field in the current library?
+ port_attr-link_layer = IBV_LINK_LAYER_UNSPECIFIED;
+ port_attr-pad = 0;
Where are you getting
More clearly: what initializes the memory you've redefined to be
link_layer in libibverbs 1.1.5 ? I see nothing.
Why does the value in an older library cause an issue?
Or, how will this library version interact with an older kernel?
--
To unsubscribe from this list: send the line unsubscribe
On Tue, Jul 19, 2011 at 09:20:25PM +, Hefty, Sean wrote:
More clearly: what initializes the memory you've redefined to be
link_layer in libibverbs 1.1.5 ? I see nothing.
Why does the value in an older library cause an issue?
ABI compatability means if dynamic linking succeeds then the
21 matches
Mail list logo
