Re: [PATCH 0/4] iWARP MPAv2 Support

2011-10-03 Thread Kumar Sanghvi
Hi Roland, On 09/25/2011 08:17 PM, Kumar Sanghvi wrote: This series adds support for MPA V2 Enhanced RDMA Negotiation protocol. Details about the protocol are available at below IETF Draft: http://www.ietf.org/id/draft-ietf-storm-mpa-peer-connect-06.txt To brief on MPA V2: 1) It allows two

[PATCH for-3.2 v1 3/5] ib/mlx4: Add extended port capabilities support

2011-10-03 Thread Marcel Apfelbaum
An Extended Port Info packet is sent to each hw port during HCA init and if returns without error it is assumed the port supports extended port capabilities. Signed-off-by: Marcel Apfelbaum marc...@dev.mellanox.co.il Reviewed-by: Hal Rosenstock h...@mellanox.com --- drivers/net/mlx4/main.c

[PATCH for-3.2 v1 5/5]libibverbs: Add support for extended speeds

2011-10-03 Thread Marcel Apfelbaum
8: FDR-10 is a proprietary link speed which is 10.3125 Gbps at 64/66 encoding rather than 8b10b encoding. 16: FDR - 14.0625 Gbps 32: EDR - 25.78125 Gbps Signed-off-by: Marcel Apfelbaum marc...@dev.mellanox.co.il Reviewed-by: Hal Rosenstock h...@mellanox.com --- examples/devinfo.c |7

PATCH for-3.2 v1 4/5] ib/mlx4: Configure extended active speeds

2011-10-03 Thread Marcel Apfelbaum
Set the extended active speeds based on the hardware configuration. Signed-off-by: Marcel Apfelbaum marc...@dev.mellanox.co.il Reviewed-by: Hal Rosenstock h...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 41 -- 1 file changed, 39 insertions(+), 2

[PATCH for-3.2 v1 4/5] ib/mlx4: Configure extended active speeds

2011-10-03 Thread Marcel Apfelbaum
Set the extended active speeds based on the hardware configuration. Signed-off-by: Marcel Apfelbaum marc...@dev.mellanox.co.il Reviewed-by: Hal Rosenstock h...@mellanox.com --- drivers/infiniband/hw/mlx4/main.c | 41 -- 1 file changed, 39 insertions(+), 2

Re: [PATCH] rdma/cm: Fix crash in cma_req_handler

2011-10-03 Thread Roland Dreier
Sorry, missed this. applied now. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH for-3.2 v1 1/5] ib/core: Add extended link speeds

2011-10-03 Thread Hefty, Sean
--- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -77,6 +77,35 @@ enum ib_rate mult_to_ib_rate(int mult) } EXPORT_SYMBOL(mult_to_ib_rate); +int ib_rate_to_int(enum ib_rate rate, int *rounded) +{ I like this approach better, but I wonder if it still couldn't

Re: [PATCH 2/4] iw_cxgb4: Add support for MPA V2 Enhanced RDMA Negotiation

2011-10-03 Thread Steve Wise
On 09/25/2011 09:47 AM, Kumar Sanghvi wrote: The patch adds support for Enhanced RDMA Connection Establishment (draft-ietf-storm-mpa-peer-connect-06). Details of draft can be obtained from: http://www.ietf.org/id/draft-ietf-storm-mpa-peer-connect-06.txt The patch updates the following functions

Re: [PATCH 3/4] amso1100/iw_cxgb3: Minimal MPAv2 support

2011-10-03 Thread Steve Wise
On 09/25/2011 09:47 AM, Kumar Sanghvi wrote: As part of MPAv2 Enhanced RDMA Negotiation, pass max supported ird/ord values upwards for the time-being in iw-cxgb3 and amso1100. Signed-off-by: Kumar Sanghvikuma...@chelsio.com Reviewed-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe

Re: [PATCH 4/4] RDMA/nes: Adds support for MPA frame Version 2

2011-10-03 Thread Steve Wise
On 09/25/2011 09:47 AM, Kumar Sanghvi wrote: From: Tatyanatatyana.e.nikol...@intel.com MPA V2 changes are based on a IETF STORM Draft, which will update RFC5043 and RFC5044. MPA V2 extends the configuration negotiation for RDMA connection establishment. For backwards compatibility, MPA V2

Re: [PATCH for-3.2 v1 1/5] ib/core: Add extended link speeds

2011-10-03 Thread Roland Dreier
On Mon, Oct 3, 2011 at 11:53 AM, Hefty, Sean sean.he...@intel.com wrote: I like this approach better, but I wonder if it still couldn't be slightly cleaner.  Rather than returning 'rounded' and having the caller assume that 1 means add .5 to the result, we could return the fractional part

RE: [PATCH for-3.2 v1 1/5] ib/core: Add extended link speeds

2011-10-03 Thread Hefty, Sean
Why not just define this function to return the rate in units where it's a whole number? ie just have the function return the value in Mbps instead of Gbps, so it returns 2500, 5000, etc. instead of 2+(*rounded=5), 5+(*rounded=0), etc. even simpler! Or if ib_rate_to_int() is only used to