RE: [PATCH net-next V0 03/21] mlx4_core: Add native argument to mlx4_cmd and its callers (where needed)

2011-12-04 Thread Yevgeny Petrilin
       return mlx4_cmd(dev, limit_watermark, srq_num, 0, MLX4_CMD_ARM_SRQ, -                       MLX4_CMD_TIME_CLASS_B); +                       MLX4_CMD_TIME_CLASS_B, 0); Instead of a 0 or 1 for the native parameter, can we define something like enum { MLX4_CMD_NATIVE,

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Jack Morgenstein
On Friday 02 December 2011 19:51, Roland Dreier wrote:  #else /* CONFIG_PCI_IOV */ +static int sr_iov; +#define probe_vf 0  int mlx4_log_num_mgm_entry_size = 9;  #endif /* CONFIG_PCI_IOV */ I don't think it's a good idea to put module parameters inside an #ifdef.  Then depending on

sparse endianness complaints for drivers/infiniband

2011-12-04 Thread Bart Van Assche
Hi, Has anyone had a look recently at the sparse endianness complaints about the code under drivers/infiniband ? I haven't analyzed these messages closely yet - these might indicate real bugs. $ make C=2 CF=-D__CHECK_ENDIAN__ M=drivers/infiniband modules [ ... ] CHECK

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Or Gerlitz
On 12/4/2011 4:29 PM, Jack Morgenstein wrote: If the kernel is not configured to support IOV, pci_enable_sriov will fail. Jack, If CONFIG_PCI_IOV isn't set, pci_enable_sriov isn't there... Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

RE: [PATCH net-next V0 18/21] mlx4_core: adjust catas operation for SRIOV mode

2011-12-04 Thread Liran Liss
On Fri, Dec 2, 2011 at 2:19 AM, Yevgeny Petrilin yevge...@mellanox.co.il wrote: When running in SRIOV mode, driver should not automatically start/stop the mlx4_core upon sensing an HCA internal error -- doing this disables/enables sriov, which will cause the hypervisor to hang if there

Re: [PATCH] infiniband-diags/src/ibccquery.c: Fix off by one output bug, ccti_limit is 0 based not 1 based

2011-12-04 Thread Ira Weiny
On Fri, 2 Dec 2011 16:00:10 -0800 Albert Chu ch...@llnl.gov wrote: Signed-off-by: Albert Chu ch...@llnl.gov Thanks applied, Ira --- src/ibccquery.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ibccquery.c b/src/ibccquery.c index a7fd79f..69db8d0 100644

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Jack Morgenstein
On Sunday 04 December 2011 17:39, Or Gerlitz wrote: On 12/4/2011 4:29 PM, Jack Morgenstein wrote: If the kernel is not configured to support IOV, pci_enable_sriov will fail. Jack, If CONFIG_PCI_IOV isn't set, pci_enable_sriov isn't there... Or. Not so. I checked. If CONFIG_PCI_IOV

Re: [RFC] – Proposal for new process for OFED releases

2011-12-04 Thread Or Gerlitz
On 12/2/2011 2:04 AM, Hefty, Sean wrote: We propose a new process for the OFED releases starting from next OFED release: - OFED content will be the relevant kernel.org modules and user space released packages - OFED will offer only backports to the distros (no fixes) I think this point needs

Re: [PATCH net-next V0 19/21] mlx4_core: Modify driver initialization flow to accommodate SRIOV for Ethernet

2011-12-04 Thread Or Gerlitz
On 12/5/2011 9:19 AM, Jack Morgenstein wrote: If CONFIG_PCI_IOV isn't set, pci_enable_sriov isn't there... Not so. I checked. If CONFIG_PCI_IOV isn't set, pci_enable_sriov returns -ENODEV via a static inline function. Look in kernel file include/linux/pci.h (for the most recent kernel)