RE: [PATCH] IB: Fix potential mem leak in schedule_nes_timer()

2012-02-26 Thread Jesper Juhl
On Fri, 24 Feb 2012, Latif, Faisal wrote: > I do not approve this patch. > > The type field is always set to either NES_TIMER_TYPE_SEND or > NES_TIMER_TYPE_CLOSE when schedule_nes_timer() is called. Even if we > wanted to make sure the value of type is one or the other, proper patch > can be

Re: [PATCH 03/18] ib_srp: Enlarge block layer timeout

2012-02-26 Thread David Dillow
On Sun, 2012-02-26 at 19:25 +, Bart Van Assche wrote: > On Sun, Feb 26, 2012 at 6:32 AM, David Dillow wrote: > > On Sat, 2012-01-14 at 12:41 +, Bart Van Assche wrote: > > > Enlarge the block layer timeout such that it is above the > > > InfiniBand transport layer timeout. This is necessary

Re: [PATCH 03/18] ib_srp: Enlarge block layer timeout

2012-02-26 Thread Bart Van Assche
On Sun, Feb 26, 2012 at 6:32 AM, David Dillow wrote: > On Sat, 2012-01-14 at 12:41 +, Bart Van Assche wrote: > > Enlarge the block layer timeout such that it is above the > > InfiniBand transport layer timeout. This is necessary to avoid > > that an SRP response is received after the SCSI laye

Re: [PATCH 2/6] IB/core: fix wrong display of rate in sysfs

2012-02-26 Thread Or Gerlitz
On 1/11/2012 9:45 PM, Or Gerlitz wrote: Yep, this function is surely not programming state of the art.. however, except for SDR, the above line doing rate = rate * ib_width_enum_to_int(attr.active_width) would hold for all the speeds and all the widths (1X, 4X, 12X), if we just set rate (possib