possible circular locking dependency in ucma

2012-02-27 Thread Or Gerlitz
Hi Sean, I run into the below ucma related warnings from the kernel with 3.3-rc5 when I stepped over crash of process as of wrong libs/etc (not the point here...). Do you see here a real bug? basically the process was exiting and the cleanup code in the kernel was running rdma_destroy_id when a ca

Re: [PATCH 2/6] IB/core: fix wrong display of rate in sysfs

2012-02-27 Thread Roland Dreier
> Could you please let me know if you want a change in this patch, or this fix > can go in using the current form for 3.4? It doesn't really work if everything needs me to micromanage every step... the original patch obviously made some ugly code uglier, Sean pointed out an obvious way to make thi

Re: [PATCH 02/18] ib_srp: Consolidate repetitive sysfs code

2012-02-27 Thread Roland Dreier
I went ahead and merged patches 1-2 which you acked, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: possible circular locking dependency in ucma

2012-02-27 Thread Hefty, Sean
I'll take a look at this in the next couple of days when I get time. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

ibv_fork_init() question

2012-02-27 Thread Steve Wise
Hey Roland, I'm experimenting with doing RDMA operations from a child process and I have a question. My application calls ibv_fork_init() at startup (first thing in main()) and it succeeds, and I see, for instance, that libibverbs has initialized mm_root. Next my application registers page-a

Re: ibv_fork_init() question

2012-02-27 Thread Roland Dreier
On Mon, Feb 27, 2012 at 11:54 AM, Steve Wise wrote: > I'm experimenting with doing RDMA operations from a child process and I have > a question.  My application calls ibv_fork_init() at startup (first thing in > main())  and it succeeds, and I see, for instance, that libibverbs has > initialized m

[PATCH] ib_ehca: fix compile failure on ppc64

2012-02-27 Thread Kyle McMartin
I'm getting compile failures building this driver, which I narrowed down to the ilog2 call in ehca_get_max_hwpage_size... ERROR: ".ilog2_NaN" [drivers/infiniband/hw/ehca/ib_ehca.ko] undefined! make[1]: *** [__modpost] Error 1 make: *** [modules] Error 2 The use of shca->hca_cap_mr_pgsize is c

Re: [PATCH 1/25 v2] rdma/cm: define native IB address

2012-02-27 Thread Roland Dreier
On Tue, Dec 20, 2011 at 1:44 PM, Hefty, Sean wrote: > Define AF_IB and sockaddr_ib to allow the rdma_cm to use native IB > addressing. > > Signed-off-by: Sean Hefty > --- >  include/linux/socket.h |    2 + >  include/rdma/ib.h      |   89 > >  2 f

[PATCH] infiniband-diags: remove unused options from check_lft_balance.pl

2012-02-27 Thread Ira Weiny
Signed-off-by: Ira Weiny --- scripts/check_lft_balance.pl | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/scripts/check_lft_balance.pl b/scripts/check_lft_balance.pl index 48f756b..395096c 100755 --- a/scripts/check_lft_balance.pl +++ b/scripts/check_lft_ba

RE: [PATCH 1/25 v2] rdma/cm: define native IB address

2012-02-27 Thread Hefty, Sean
> > diff --git a/include/linux/socket.h b/include/linux/socket.h > > index d0e77f6..c2c7687 100644 > > --- a/include/linux/socket.h > > +++ b/include/linux/socket.h > > @@ -184,6 +184,7 @@ struct ucred { > >  #define AF_PPPOX       24      /* PPPoX sockets                */ > >  #define AF_WANPIPE

Re: [PATCH] ib_ehca: fix compile failure on ppc64

2012-02-27 Thread Roland Dreier
On Mon, Feb 27, 2012 at 2:02 PM, Kyle McMartin wrote: >  static u64 ehca_get_max_hwpage_size(struct ehca_shca *shca) >  { > -       return 1UL << ilog2(shca->hca_cap_mr_pgsize); > +       u32 pgsize = shca->hca_cap_mr_pgsize; > +       return 1UL << ilog2(pgsize); >  } How about using rounddown_p

Re: [PATCH 2/6] IB/core: fix wrong display of rate in sysfs

2012-02-27 Thread Or Gerlitz
On 2/27/2012 7:23 PM, Roland Dreier wrote: It doesn't really work if everything needs me to micromanage every step... the original patch obviously made some ugly code uglier, Sean pointed out an obvious way to make things cleaner. If no one has a problem, I'll just go ahead with the following..