[PATCH 1/4] RDMA/ocrdma: Fix warnings about uninitialized variables

2012-04-24 Thread Roland Dreier
From: Roland Dreier First, fix drivers/infiniband/hw/ocrdma/ocrdma_verbs.c: In function 'ocrdma_alloc_pd': drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:371:17: warning: 'dpp_page_addr' may be used uninitialized in this function [-Wuninitialized] drivers/infiniband/hw/ocrdma/ocrdma_ve

[PATCH 4/4] RDMA/ocrdma: Remove write-only variables

2012-04-24 Thread Roland Dreier
From: Roland Dreier Signed-off-by: Roland Dreier --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c|6 ++ drivers/infiniband/hw/ocrdma/ocrdma_verbs.c |6 -- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniba

[PATCH 3/4] RDMA/ocrdma: Set event's device member in ocrdma_dispatch_ibevent()

2012-04-24 Thread Roland Dreier
From: Roland Dreier We need to set ib_evt.device, or else ib_dispatch_event() will crash when we call it for unaffiliated events (and consumers may get confused in their QP/CQ/SRQ event handler for affiliated events). Also fix sparse warning: drivers/infiniband/hw/ocrdma/ocrdma_hw.c:678:36:

[PATCH 2/4] RDMA/ocrdma: Make needlessly global functions/structs static

2012-04-24 Thread Roland Dreier
From: Roland Dreier Signed-off-by: Roland Dreier --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 12 ++-- drivers/infiniband/hw/ocrdma/ocrdma_main.c |6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infin

ocrdma merged to my next branch

2012-04-24 Thread Roland Dreier
From: Roland Dreier So I pulled in the Emulex ocrdma driver with the intention of merging for 3.5. I took the chance to add a few simple patches that fix minor problems with the driver; please let me know if you see any problems with any of the changes I made. By the way, the way that the drive

Re: [PATCH V2 3/5] ib-diags/saquery: Fix smkey handling

2012-04-24 Thread Jim Foraker
On Tue, 2012-04-24 at 07:17 -0700, Hal Rosenstock wrote: > On 4/23/2012 8:56 PM, Jim Foraker wrote: > > smkey is already defined as a global inside saquery.c, so remove > > broken support for passing it around as a function parameter > > > > Signed-off-by: Jim Foraker > > --- > > src/saquery.c

Re: [PATCH 1/4] IB/core: add RAW Packet QP type

2012-04-24 Thread Roland Dreier
Thanks, applied at long last. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH fixes] IB/core: fix generation of unmatched responses for unhandled MADs

2012-04-24 Thread Roland Dreier
> Commit 0b307043049f34211affdde46f82e7abbe8c4590 "IB/mad: Return > error response for unsupported MADs" introduced two problems: Thanks, applied as two patches, since AFAICT the two fixes are not tied to each other. - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" i

RE: possible recursive locking detected in the cma?

2012-04-24 Thread Hefty, Sean
> The usual fix is to use mutex_lock_nested, cf "Exception: Nested data > dependencies leading to nested locking" in > Documentation/lockdep-design.txt. I haven't looked at how easy that > is to do in this case. I think in this case, it's easier to just delay the call to rdma_destroy_id() until

Re: possible recursive locking detected in the cma?

2012-04-24 Thread Roland Dreier
On Tue, Apr 24, 2012 at 12:37 PM, Hefty, Sean wrote: >> = >> [ INFO: possible recursive locking detected ] >> 3.3.0-32035-g1b2649e-dirty #4 Not tainted >> - >> kworker/5:1/418 is trying to acquire lock: >>  (&i

RE: possible recursive locking detected in the cma?

2012-04-24 Thread Hefty, Sean
> Specifically, I see that your commit 186834b5de69 "RDMA/ucma: Fix > AB-BA deadlock" deals only with the ucma and this trace doesn't > have ucma symbols, so is that a different race? or false alarm? Maybe I'm overlooking something, but this looks like a false match. > ==

RE: [PATCH] libibverbs-xrc: Rename the attribute private -> private_data

2012-04-24 Thread Hefty, Sean
thanks - applied -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH][TRIVIAL] rping: security fix: replace sprintf with snprintf

2012-04-24 Thread Hefty, Sean
thanks - applied -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 2/5] infiniband-diags: Allow specification of an mkey to use on the command line

2012-04-24 Thread Ira Weiny
On Tue, 24 Apr 2012 10:17:21 -0400 Hal Rosenstock wrote: > On 4/23/2012 8:56 PM, Jim Foraker wrote: > > Signed-off-by: Jim Foraker > > --- > > include/ibdiag_common.h |1 + > > libibnetdisc/include/infiniband/ibnetdisc.h |3 ++- > > libibnetdisc/src/ibnetdisc.c

Re: [PATCH V2 3/5] ib-diags/saquery: Fix smkey handling

2012-04-24 Thread Hal Rosenstock
On 4/23/2012 8:56 PM, Jim Foraker wrote: > smkey is already defined as a global inside saquery.c, so remove > broken support for passing it around as a function parameter > > Signed-off-by: Jim Foraker > --- > src/saquery.c | 59 > - > 1

Re: [PATCH V2 2/5] infiniband-diags: Allow specification of an mkey to use on the command line

2012-04-24 Thread Hal Rosenstock
On 4/23/2012 8:56 PM, Jim Foraker wrote: > Signed-off-by: Jim Foraker > --- > include/ibdiag_common.h |1 + > libibnetdisc/include/infiniband/ibnetdisc.h |3 ++- > libibnetdisc/src/ibnetdisc.c|1 + > man/ibaddr.8|

Re: [PATCH V2 1/5] infiniband-diags/ibportstate.c: Support MKey, lease, and protect bits

2012-04-24 Thread Hal Rosenstock
On 4/23/2012 8:56 PM, Jim Foraker wrote: > Allow user to both display and change mkey-related values. > > Signed-off-by: Jim Foraker > --- > src/ibportstate.c | 98 > ++--- > 1 file changed, 79 insertions(+), 19 deletions(-) > > diff --git a/sr

Re: [PATCH V2 0/5] Mkey support in infiniband-diags

2012-04-24 Thread Hal Rosenstock
On 4/23/2012 8:53 PM, Jim Foraker wrote: > I am about to send version 2 of the mkey patches for > infiniband-diags to the list. Notable changes are: > > . both current mkey and new mkey (for ibportstate) may now be prompted > for in addition to specified on the command line (ie, identical to

[PATCH][TRIVIAL] rping: security fix: replace sprintf with snprintf

2012-04-24 Thread Dotan Barak
Replace sprintf with snprintf to protects from buffer overflow. Signed-off-by: Dotan Barak --- examples/rping.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/rping.c b/examples/rping.c index ee292ec..785338e 100644 --- a/examples/rping.c +++ b/examples/rping.

possible recursive locking detected in tne cma?

2012-04-24 Thread Or Gerlitz
Hi Sean, I hitted this one few days ago, problem is that I'm not sure what **exactly** was the kernel I was using... surely it was upstream post 3.3 something but not clear whose tree. Specifically, I see that your commit 186834b5de69 "RDMA/ucma: Fix AB-BA deadlock" deals only with the ucma and t

[PATCH] libibverbs-xrc: Rename the attribute private -> private_data

2012-04-24 Thread Dotan Barak
Since "private" is a reserved word in C++, it shouldn't be used as a name of a structure attribute. Signed-off-by: Dotan Barak Reviewed-by: Jack Morgenstein --- include/infiniband/ofverbs.h |2 +- include/infiniband/verbs.h |4 ++-- src/ofverbs.c|4 ++-- 3 files ch