Re: [PATCH for-next V1 09/29] net/mlx4_core: For SRIOV, initialize ib port-capabilities for all slaves

2012-07-11 Thread Or Gerlitz
On 7/10/2012 7:57 PM, Roland Dreier wrote: thanks, applied thanks, I see now that you've picked also patch #8, so we're making progress... any further thoughts/feedback following the responses I provided on your questions around DM and SM? Or. -- To unsubscribe from this list: send the line

[PATCH] infiniband-diags/perfquery.c: Fix compile warning

2012-07-11 Thread Hal Rosenstock
src/perfquery.c: In function main: src/perfquery.c:662: warning: integer constant is too large for long type Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/src/perfquery.c b/src/perfquery.c index e85b14e..32dd98f 100644 --- a/src/perfquery.c +++ b/src/perfquery.c @@ -659,7

[PATCH] infiniband-diags: Fix RPM build error

2012-07-11 Thread Hal Rosenstock
RPM build errors: Installed (but unpackaged) file(s) found: /etc/infiniband-diags Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/Makefile.am b/Makefile.am index 33b5f90..2265110 100644 --- a/Makefile.am +++ b/Makefile.am @@ -147,5 +147,5 @@ install-data-hook:

[PATCH librdmacm] rdma_resolve_addr: source address protocol family must be valid

2012-07-11 Thread Yann Droneaud
If a source address is provided but its protocol family is not recognized, returns an error. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- src/cma.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/cma.c b/src/cma.c index f688c4c..364b587 100755 ---

[PATCH libibverbs] memory: use SCNxPTR format to read uintptr_t values

2012-07-11 Thread Yann Droneaud
SCNxPTR is the correct format to parse uintptr_t hexadecimal values, whatever the width of uintptr_t type. This fix a warning when building on a 32bits system. Signed-off-by: Yann Droneaud ydrone...@opteya.com --- src/memory.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

[PATCH libibverbs] memory: commented unused verify() function

2012-07-11 Thread Yann Droneaud
Signed-off-by: Yann Droneaud ydrone...@opteya.com --- src/memory.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/memory.c b/src/memory.c index faa43f3..ea9e712 100644 --- a/src/memory.c +++ b/src/memory.c @@ -268,6 +268,7 @@ static void __mm_rotate_left(struct

[PATCH for-next 0/6] batch of fixes for 3.6

2012-07-11 Thread Or Gerlitz
Hi Roland, Here's a batch of small fixes from Dotan for 3.6 Or. Dotan Barak (6): IB/mthca: Events received for non-existent QPs should generate a warning IB/mthca: Fill in the attribute sq_sig_type value in query QP IB/mlx4: Fill the masked_atomic_cap attribute in query device

[PATCH for-next 2/6] IB/mthca: Fill in the attribute sq_sig_type value in query QP

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il The query QP code was didn't fill that attribute, do that. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com ---

[PATCH for-next 6/6] net/mlx4_core: Free ICM table in case of error

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il In mlx4_init_icm_table, free the allocated table if we failed to allocate memory to its entries. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Yevgeny Petrilin yevge...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH for-next 5/6] IB/cm: Destroy idr as part of the module init error flow

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Clean the idr as part of the error flow since it is a resource too. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Sean Hefty sean.he...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/cm.c |

[PATCH for-next 4/6] net/mlx4_core: Remove double function declarations

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Spotted four duplicate declarations in icm.h, remove them. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@dev.mellanox.com --- drivers/net/ethernet/mellanox/mlx4/icm.h |6 -- 1 files changed, 0

[PATCH for-next 3/6] IB/mlx4: Fill the masked_atomic_cap attribute in query device

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il When the user queries for device capabilities, fill the masked_atomic_cap attrbiute according to the support level of atomic capabilities instead of hard coded value. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Eli Cohen

[PATCH for-next 1/6] IB/mthca: Events received for non-existent QPs should generate a warning

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Events received for non-existent QPs should generate a warning along with the event type which was received. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz

[PATCH RESEND for-next 0/6] batch of fixes for 3.6

2012-07-11 Thread Or Gerlitz
Hi Roland, Here's a batch of small fixes from Dotan for 3.6 Please ignore the prev posting, it had wrong sign-off address for me. Or. Dotan Barak (6): IB/mthca: Events received for non-existent QPs should generate a warning IB/mthca: Fill in the attribute sq_sig_type value in query QP

[PATCH RESEND for-next 1/6] IB/mthca: Events received for non-existent QPs should generate a warning

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Events received for non-existent QPs should generate a warning along with the event type which was received. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz

[PATCH RESEND for-next 2/6] IB/mthca: Fill in the attribute sq_sig_type value in query QP

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il The query QP code was didn't fill that attribute, do that. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Jack Morgenstein ja...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com ---

[PATCH RESEND for-next 6/6] net/mlx4_core: Free ICM table in case of error

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il In mlx4_init_icm_table, free the allocated table if we failed to allocate memory to its entries. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Yevgeny Petrilin yevge...@mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com

[PATCH RESEND for-next 4/6] net/mlx4_core: Remove double function declarations

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Spotted four duplicate declarations in icm.h, remove them. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/net/ethernet/mellanox/mlx4/icm.h |6 -- 1 files changed, 0

[PATCH RESEND for-next 5/6] IB/cm: Destroy idr as part of the module init error flow

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il Clean the idr as part of the error flow since it is a resource too. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Sean Hefty sean.he...@intel.com Signed-off-by: Or Gerlitz ogerl...@mellanox.com --- drivers/infiniband/core/cm.c |

[PATCH RESEND for-next 3/6] IB/mlx4: Fill the masked_atomic_cap attribute in query device

2012-07-11 Thread Or Gerlitz
From: Dotan Barak dot...@dev.mellanox.co.il When the user queries for device capabilities, fill the masked_atomic_cap attrbiute according to the support level of atomic capabilities instead of hard coded value. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il Reviewed-by: Eli Cohen

Re: [PATCH for-next 1/6] IB/mthca: Events received for non-existent QPs should generate a warning

2012-07-11 Thread Roland Dreier
On Wed, Jul 11, 2012 at 8:33 AM, Or Gerlitz ogerl...@mellanox.com wrote: - mthca_warn(dev, Async event for bogus QP %08x\n, qpn); + mthca_warn(dev, Async event %d for bogus QP %08x\n, + (int) event_type, qpn); Looks fine -- just wondering if

Re: [PATCH libibverbs] memory: use SCNxPTR format to read uintptr_t values

2012-07-11 Thread Roland Dreier
On Wed, Jul 11, 2012 at 8:10 AM, Yann Droneaud ydrone...@opteya.com wrote: @@ -116,7 +117,7 @@ static unsigned long get_page_size(void *base) int n; uintptr_t range_start, range_end; - n = sscanf(buf, %lx-%lx, range_start, range_end); +

Re: [PATCH for-next 1/6] IB/mthca: Events received for non-existent QPs should generate a warning

2012-07-11 Thread Or Gerlitz
On 7/11/2012 6:40 PM, Roland Dreier wrote: On Wed, Jul 11, 2012 at 8:33 AM, Or Gerlitz ogerl...@mellanox.com wrote: - mthca_warn(dev, Async event for bogus QP %08x\n, qpn); + mthca_warn(dev, Async event %d for bogus QP %08x\n, + (int)

Re: [PATCH for-next 1/6] IB/mthca: Events received for non-existent QPs should generate a warning

2012-07-11 Thread Roland Dreier
Nothing special that I can think of, want me to post v1 with that cast removed? It's OK, I'll drop it when I apply. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH libibverbs] memory: commented unused verify() function

2012-07-11 Thread Or Gerlitz
any reason not to remove it all together? Or. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH libibverbs] memory: use SCNxPTR format to read uintptr_t values

2012-07-11 Thread Jason Gunthorpe
On Wed, Jul 11, 2012 at 08:47:05AM -0700, Roland Dreier wrote: Looks fine in itself, and I don't necessarily expect you to be the one to answer, but: - what does /proc/pid/maps show when running a 32-bit process on a 64-bit kernel? Should we be using uint64_t / SCNx64? (but surely

Re: [PATCH libibverbs] memory: use SCNxPTR format to read uintptr_t values

2012-07-11 Thread Yann Droneaud
Le mercredi 11 juillet 2012 à 08:47 -0700, Roland Dreier a écrit : On Wed, Jul 11, 2012 at 8:10 AM, Yann Droneaud ydrone...@opteya.com wrote: @@ -116,7 +117,7 @@ static unsigned long get_page_size(void *base) int n; uintptr_t range_start, range_end; -

Re: [PATCH RESEND for-next 0/6] batch of fixes for 3.6

2012-07-11 Thread Roland Dreier
thanks, applied all 6 (with the cast removal in 1/6) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH libibverbs] memory: commented unused verify() function

2012-07-11 Thread Yann Droneaud
Hi, Le mercredi 11 juillet 2012 à 18:58 +0300, Or Gerlitz a écrit : any reason not to remove it all together? It might be use for debug purpose. Perhaps someone will add such code back after seeing my patch. If no one step up for this, the red-black tree verification function could be

Re: [PATCH] infiniband-diags: Fix RPM build error

2012-07-11 Thread Ira Weiny
On Wed, 11 Jul 2012 10:06:16 -0400 Hal Rosenstock h...@dev.mellanox.co.il wrote: RPM build errors: Installed (but unpackaged) file(s) found: /etc/infiniband-diags Signed-off-by: Hal Rosenstock h...@mellanox.com --- diff --git a/Makefile.am b/Makefile.am index 33b5f90..2265110 100644

Re: [PATCH] infiniband-diags/perfquery.c: Fix compile warning

2012-07-11 Thread Ira Weiny
On Wed, 11 Jul 2012 10:05:37 -0400 Hal Rosenstock h...@dev.mellanox.co.il wrote: src/perfquery.c: In function main: src/perfquery.c:662: warning: integer constant is too large for long type Signed-off-by: Hal Rosenstock h...@mellanox.com Thanks, applied. Ira --- diff --git

Re: [PATCH for-next V1 10/29] net/mlx4_core: Implement mechanism for reserved qkeys

2012-07-11 Thread Roland Dreier
thanks, applied -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH V2 07/10] opensm/console; add port option to perfmgr print_counters

2012-07-11 Thread Ira Weiny
Changes since V1: My rebase got cross wired for the console help message. Fix this. Signed-off-by: Ira Weiny wei...@llnl.gov --- include/opensm/osm_perfmgr.h|3 ++- include/opensm/osm_perfmgr_db.h |6 -- opensm/osm_console.c| 13 ++---

[PATCH V2 08/10] opensm/console: add abreviations for perfmgr commands

2012-07-11 Thread Ira Weiny
Add: pm for perfmgr pc for print_counters Changes since V1: My rebase got cross wired for the console help message. Fix this. Signed-off-by: Ira Weiny wei...@llnl.gov --- opensm/osm_console.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git

[PATCH V2 10/10] opensm/console: add perfmgr print_errors (pe) console command.

2012-07-11 Thread Ira Weiny
Only print ports with error counters 0 Changes since V1: My rebase got cross wired for the console help message. Fix this. Signed-off-by: Ira Weiny wei...@llnl.gov --- include/opensm/osm_perfmgr.h|2 +- include/opensm/osm_perfmgr_db.h |6 +- opensm/osm_console.c

RE: [PATCH librdmacm] rdma_resolve_addr: source address protocol family must be valid

2012-07-11 Thread Hefty, Sean
thanks - applied -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] librdmacm/rsocket: Build librspreload library as part of build

2012-07-11 Thread Hefty, Sean
Build the rsocket preload library as part of the build. To reduce the risk of the preload library intercepting calls without the user's knowledge, the preload library is installed into {_libdir}/rsocket. Signed-off-by: Sean Hefty sean.he...@intel.com --- diff --git a/Makefile.am

linux-next: manual merge of the net-next tree with the infiniband tree

2012-07-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/mellanox/mlx4/main.c between commit 6634961c14d3 (mlx4: Put physical GID and P_Key table sizes in mlx4_phys_caps struct and paravirtualize them) from the infiniband tree and commit 0ff1fb654bec ({NET,

linux-next: manual merge of the net-next tree with the infiniband tree

2012-07-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in include/linux/mlx4/device.h between commit 396f2feb05d7 (mlx4_core: Implement mechanism for reserved Q_Keys) from the infiniband tree and commit 0ff1fb654bec ({NET, IB}/mlx4: Add device managed flow steering firmware API)