cxgb4: Missing NULL check of the return value of get_skb() in function send_flowc()

2012-07-12 Thread Roland Dreier
steve, in case you didn't read this because of the generic subject: On Thu, Jul 12, 2012 at 7:16 PM, wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=44631 > >Summary: Missing NULL check of the return value of get_skb() in > function send_flowc() >

[Bug 44631] New: Missing NULL check of the return value of get_skb() in function send_flowc()

2012-07-12 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=44631 Summary: Missing NULL check of the return value of get_skb() in function send_flowc() Product: Drivers Version: 2.5 Kernel Version: 2.6.39 Platform: All OS/Version: Linux

Re: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread David Miller
From: Shlomo Pongratz Date: Thu, 12 Jul 2012 20:13:28 + > The RCU and reference count protect the individual entries in the hash. > The R/W lock protects the hash table itself. e.g. deleting the hash table > itself, or in the future re-sizing it. You don't need a R/W lock for that, we have

Re: [PATCH][TRIVIAL] infiniband-diags/vendstat.c: Commentary change

2012-07-12 Thread Ira Weiny
On Thu, 12 Jul 2012 06:35:13 -0400 Hal Rosenstock wrote: > > Add device names to go along with device IDs > > Signed-off-by: Hal Rosenstock Thanks applied, Ira > --- > diff --git a/src/vendstat.c b/src/vendstat.c > index 1c493fa..8535792 100644 > --- a/src/vendstat.c > +++ b/src/vendstat.c >

RE: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread Marciniszyn, Mike
> The RCU and reference count protect the individual entries in the hash. > The R/W lock protects the hash table itself. e.g. deleting the hash table > itself, > or in the future re-sizing it. > S.P. Understood. Good job! This a been thorn for a long time! Mike -- To unsubscribe from this list

RE: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread Shlomo Pongratz
From: Marciniszyn, Mike [mike.marcinis...@intel.com] Sent: Thursday, July 12, 2012 7:48 PM To: Or Gerlitz; rol...@kernel.org Cc: linux-rdma@vger.kernel.org; da...@davemloft.net; Erez Shitrit; Shlomo Pongratz Subject: RE: [PATCH] IB/ipoib: break linkage to neighbouring system ipoib_path_lookup(skb

RE: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread Marciniszyn, Mike
ipoib_path_lookup(skb, n, dev); > +struct ipoib_neigh *ipoib_neigh_get(struct net_device *dev, u8 *daddr) > { > + struct ipoib_dev_priv *priv = netdev_priv(dev); > + struct ipoib_hash_table *htbl = &priv->neigh_htbl; > struct ipoib_neigh *neigh; > - struct ipoib_dev_priv *priv =

[PATCH][MINOR] mstflint/hca_self_test.ofed: Handle lspci output for ConnectX3 (on RHEL 6.2)

2012-07-12 Thread Lloyd Brown
Not sure whether the difference is the hardware, or the OS revision, but the lspci output looks like this example, and wasn't being caught: 02:00.0 Network controller [0207]: Mellanox Technologies MT27500 Family [ConnectX-3] Signed-off-by: Lloyd Brown --- hca_self_test.ofed |4 ++-- 1 file

RE: [PATCH] librdmacm/preload.c: Eliminate some compile warnings

2012-07-12 Thread Hefty, Sean
doh (to me) - thanks! applied -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] opensm/osm_node_info_rcv.c: In ni_rcv_process_existing_ca_or_router, handle error

2012-07-12 Thread Hal Rosenstock
Add handling for case where osm_node_get_physp_ptr returns NULL pointer Signed-off-by: Hal Rosenstock --- diff --git a/opensm/osm_node_info_rcv.c b/opensm/osm_node_info_rcv.c index 58c92b9..293f0c8 100644 --- a/opensm/osm_node_info_rcv.c +++ b/opensm/osm_node_info_rcv.c @@ -479,6 +479,16 @@ alia

[PATCH] librdmacm/preload.c: Eliminate some compile warnings

2012-07-12 Thread Hal Rosenstock
by fixing a couple of typecasts src/preload.c: In function ?bind?: src/preload.c:350: warning: assignment from incompatible pointer type src/preload.c: In function ?connect?: src/preload.c:397: warning: assignment from incompatible pointer type Signed-off-by: Hal Rosenstock --- diff --git a/src

Re: [PATCH] IB/ipoib: break linkage to neighbouring system

2012-07-12 Thread Or Gerlitz
On 7/10/2012 1:01 PM, Or Gerlitz wrote: [...] This patch aims to solve the race conditions found in the IPoIB driver. The patch breaks the connection between the core networking neighbour structure and the ipoib_neigh structure. Except for avoiding the race, it allows to in under a setup where S

Re: linux-next: manual merge of the net-next tree with the infiniband tree

2012-07-12 Thread Hadar Hen Zion
On 7/12/2012 5:09 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/mellanox/mlx4/main.c between commit 6634961c14d3 ("mlx4: Put physical GID and P_Key table sizes in mlx4_phys_caps struct and paravirtualize them") from the i

Re: linux-next: manual merge of the net-next tree with the infiniband tree

2012-07-12 Thread Hadar Hen Zion
On 7/12/2012 5:13 AM, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in include/linux/mlx4/device.h between commit 396f2feb05d7 ("mlx4_core: Implement mechanism for reserved Q_Keys") from the infiniband tree and commit 0ff1fb654bec ("{NET, IB}/mlx4:

[PATCH][TRIVIAL] infiniband-diags/vendstat.c: Commentary change

2012-07-12 Thread Hal Rosenstock
Add device names to go along with device IDs Signed-off-by: Hal Rosenstock --- diff --git a/src/vendstat.c b/src/vendstat.c index 1c493fa..8535792 100644 --- a/src/vendstat.c +++ b/src/vendstat.c @@ -142,10 +142,10 @@ typedef struct { } is4_config_counter_groups_t; static uint16_t ext_fw_inf

Re: [PATCH] infiniband-diags: Fix RPM build error

2012-07-12 Thread Hal Rosenstock
On 7/11/2012 1:02 PM, Ira Weiny wrote: > On Wed, 11 Jul 2012 10:06:16 -0400 > Hal Rosenstock wrote: > >> >> RPM build errors: >> Installed (but unpackaged) file(s) found: >> /etc/infiniband-diags >> >> Signed-off-by: Hal Rosenstock >> --- >> diff --git a/Makefile.am b/Makefile.am >> index 33b5f9

[PATCH 1/2] scsi: use kernel's '%pM' format option to print MAC

2012-07-12 Thread Andy Shevchenko
Signed-off-by: Andy Shevchenko Cc: Tom Tucker Cc: Steve Wise Cc: linux-rdma@vger.kernel.org --- drivers/scsi/fnic/vnic_dev.c | 10 ++ drivers/scsi/qla4xxx/ql4_nx.c |8 ++-- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/