Re: [PATCH 0/5] Fix bugs in ib_srp patches for H.A. purposes

On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > This patchset aims at fixing bugs that have been discovered in our own > SRP test environment so far. These patches are based on your patchset v4, > "Make ib_srp better suited for H.A. purposes",(09 Aug 2012). > > The 5th patch, "fix an erro

Re: [PATCH 4/5] ib_srp: check if rport->lld_data is NULL before removing rport

On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_srp.c > index 1b274484..ba7bbfd 100644 > --- a/drivers/infiniband/ulp/srp/ib_srp.c > +++ b/drivers/infiniband/ulp/srp/ib_srp.c > @@ -647,9 +647,19 @@ static v

Re: [PATCH 3/5] ib_srp: hold a mutex when adding a new target port

On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > [ cut here ] > WARNING: at block/genhd.c:1466 __disk_unblock_events+0x10f/0x120() > Pid: 17238, comm: scsi_id Not tainted 3.2.8-pserver #1 > Call Trace: > [] ? warn_slowpath_common+0x7b/0xc0 > [] ? __disk_unblock_eve

Re: [PATCH 2/5] ib_srp: removed superfluous warning in send timeout case

On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > From: Dongsu Park > > Signed-off-By: Sebastian Riemer > --- > drivers/infiniband/ulp/srp/ib_srp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/infiniband/ulp/srp/ib_srp.c > b/drivers/infiniband/ulp/srp/ib_srp.c > inde

Re: [PATCH 1/5] ib_srp: free memory correctly in srp_free_iu()

On 08/31/12 20:00, dongsu.p...@profitbricks.com wrote: > From: Dongsu Park > > As a potential fix for a race condition in srp_free_iu(), > hold a mutex in srp_free_target_ib() before calling srp_free_iu(). > > In addition, also clear rx/tx ring after freeing memory. > Both rx_ring[] and tx_ring[