Re: v3.7: Unloading ib_ipoib triggers circular locking dependency complaint

2012-11-26 Thread Or Gerlitz
On Fri, Nov 23, 2012 at 2:10 PM, Bart Van Assche wrote: > Apparently unloading the ib_ipoib kernel module triggers a circular locking > dependency complaint. Has anyone already been looking into this ? Yes, I see that this happens here e.g when doing hot-unplug to the underlying HW driver, seems

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: Once we know we have an issue with the QP, there is no point trying to send anything else down the pipe. This also allows us to consolidate code in the SCSI EH path. [ ... ] @@ -1683,7 +1681,7 @@ static int srp_send_tsk_mgmt(struct srp_target_port *targe

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: > From: Bart Van Assche > > Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from > inside scsi_remove_host() (see also the sd_shutdown() call in > sd_remove()). Make sure that these commands have a chance to reach > the SCSI device. > > Signed-o

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: The state of the target has several conditions that overlap, making it easier to model as a bit-field of exceptional conditions rather than an enum of all possible states. Bart Van Assche did the hard work of identifying the states that can be removed, and

Re: v3.7: Unloading ib_ipoib triggers circular locking dependency complaint

2012-11-26 Thread Roland Dreier
> Does anyone has an idea where the "s_active" lock is defined and what > is its role? Look in fs/sysfs/sysfs.h and how dep_map is used in fs/sysfs -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH V3 3/3] {NET,IB}/mlx4: 64 byte CQE/EQE support

2012-11-26 Thread Or Gerlitz
Hi Roland, I see that you picked this, good! not sure how it happened but Eli's signature was missing from V3 which you took, can you somehow add this there?! Signed-off-by: Eli Cohen -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@v

Re: [PATCH] Remove bashisms from infiniband-diags

2012-11-26 Thread Ira Weiny
On Sun, 11 Nov 2012 11:05:32 -0800 Garrett Cooper wrote: > Signed-off-by: Garrett Cooper Thanks applied, Ira -- Ira Weiny Member of Technical Staff Lawrence Livermore National Lab 925-423-8008 wei...@llnl.gov -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the bod

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> This series compiles, but is otherwise UNTESTED. I'll be working on that > over the next few days, with an eye on getting as much of Bart's work > into 3.8 as possible. Hi Dave, Great to have you back. Certainly I'd like to get this stuff into 3.8 too. A couple of comments: - I think the

Re: [PATCH] UAPI: (Scripted) Disintegrate include/rdma

2012-11-26 Thread Roland Dreier
Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/11] IB/srp: destroy and recreate QP and CQs on each connection

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: From: Ishai Rabinovitz HW QP FATAL errors persist over a reset operation, but we can recover from that by recreating the QP and associated CQs for each connection. Creating a new QP/CQ also completely forecloses any possibility of getting stale completions

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread James Bottomley
On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > - I think the srp_transport stuff should go through linux-scsi / > James B. >instead of my tree, esp. since it's shared with the IBM vscsi stuff > (I think) > - I see Bart had a few comments about a few of your patches, I'll > wait >

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Roland Dreier
> I'm amenable to that, but we do need an agreed patch set, as Roland > says. I also hate to apply the pressure, but I suspect -rc7 was the > last -rc, so I'm expecting the merge window to open on 2/12. I think the srp_transport bits are all simple and non-controversial. So at least from my persp

RE: Dapltest test error DAT_CONN_QUAL_IN_USE

2012-11-26 Thread Davis, Arlin R
dapltest server will start with port 45278 and increase by client thread count during each new client connection. If you never restart the server it will continue to increase the listen port based on new clients connecting. If you restart dapltest it will restart back at port 45278. I am not fam

Re: [PATCH] Remove bashisms from infiniband-diags

2012-11-26 Thread Garrett Cooper
On Mon, Nov 26, 2012 at 10:33 AM, Ira Weiny wrote: > On Sun, 11 Nov 2012 11:05:32 -0800 > Garrett Cooper wrote: > >> Signed-off-by: Garrett Cooper > > Thanks applied, Thanks! -Garrett -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@

Re: Dapltest test error DAT_CONN_QUAL_IN_USE

2012-11-26 Thread Steve Wise
Perhaps the port is in use by the host TCP stack? On 11/26/2012 1:30 PM, Davis, Arlin R wrote: dapltest server will start with port 45278 and increase by client thread count during each new client connection. If you never restart the server it will continue to increase the listen port based o

linux-next: manual merge of the net-next tree with the infiniband tree

2012-11-26 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/mellanox/mlx4/en_rx.c between commit 08ff32352d6f ("mlx4: 64-byte CQE/EQE support") from the infiniband tree and commit f1d29a3fa68b ("mlx4_en: Remove remnants of LRO support") from the net-next tree. I f

mellanox mlx4_core and SR-IOV

2012-11-26 Thread Zhangxiaofeng
Hello, I tried to use SR-IOV virtualization for Mellanox ConnectX2 card with kernel 3.6.7. I met some problem as below: lspci -v shows: 04:00.0 InfiniBand: Mellanox Technologies MT26428 [ConnectX VPI PCIe 2.0 5GT/s - IB QDR / 10GigE] (rev b0) Subsystem: Mellanox Technologies Device 0036

Re: mellanox mlx4_core and SR-IOV

2012-11-26 Thread Jon Stanley
On Mon, Nov 26, 2012 at 8:05 PM, Zhangxiaofeng wrote: > Hello, > I tried to use SR-IOV virtualization for Mellanox ConnectX2 card with kernel > 3.6.7. I'm not 100% sure, but I don't think that the CX2 supports SR-IOV - I think you need the CX3 for that. -- To unsubscribe from this list: send th

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:43 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > From: Bart Van Assche > > > > Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from > > inside scsi_remove_host() (see also the sd_shutdown() call in > > sd_remove()). Make sure that

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:17 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > Once we know we have an issue with the QP, there is no point trying to > > send anything else down the pipe. This also allows us to consolidate > > code in the SCSI EH path. > After I posted the

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 10:46 +0100, Bart Van Assche wrote: > On 11/26/12 05:44, David Dillow wrote: > > The state of the target has several conditions that overlap, making it > > easier to model as a bit-field of exceptional conditions rather than an > > enum of all possible states. > > > > Bart Van

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 23:15 +0400, James Bottomley wrote: > On Mon, 2012-11-26 at 10:50 -0800, Roland Dreier wrote: > > - I think the srp_transport stuff should go through linux-scsi / > > James B. > >instead of my tree, esp. since it's shared with the IBM vscsi stuff > > (I think) > > - I se

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread David Dillow
On Mon, 2012-11-26 at 09:57 +0200, Or Gerlitz wrote: > On Mon, Nov 26, 2012 at 6:44 AM, David Dillow wrote: > > One may also pull this series from github: > > git pull git://github.com/dillow/srp-initiator.git ha-merge-v1 > > Hi Dave, > > The kernel maintainers file specifies the followi

Re: mellanox mlx4_core and SR-IOV

2012-11-26 Thread Albert Strasheim
Hello TLDR: get firmware 2.9.1200 and wait for 3.7. On Tue, Nov 27, 2012 at 4:30 AM, Jon Stanley wrote: > On Mon, Nov 26, 2012 at 8:05 PM, Zhangxiaofeng > wrote: > >> Hello, >> I tried to use SR-IOV virtualization for Mellanox ConnectX2 card with kernel >> 3.6.7. > > I'm not 100% sure, but I d

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-26 Thread Or Gerlitz
On 27/11/2012 06:04, David Dillow wrote: We can push it through James's tree if need be, but Bart's code is pretty self-contained, and going through the SCSI tree will introduce merge dependencies. It'd be much easier to push it all through the RDMA tree Yep, this makes sense to me even witho

Re: linux-next: manual merge of the net-next tree with the infiniband tree

2012-11-26 Thread Or Gerlitz
On 27/11/2012 02:47, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/ethernet/mellanox/mlx4/en_rx.c between commit 08ff32352d6f ("mlx4: 64-byte CQE/EQE support") from the infiniband tree and commit f1d29a3fa68b ("mlx4_en: Remove remnant