Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Jack Morgenstein
On Monday 25 February 2013 19:23, Roland Dreier wrote: > On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > > I'm finally noticing that this is in the build_mlx_header() function, > > which is pretty much a slow path. Certainly another compare isn't > > going to change performance given all

Re: linux-next: manual merge of the infiniband tree with Linus' tree

2013-02-25 Thread Or Gerlitz
On 26/02/2013 02:45, Stephen Rothwell wrote: Hi all, Today's linux-next merge of the infiniband tree got a conflict in drivers/net/ethernet/mellanox/mlx4/mlx4.h between commit 23537b732f5d ("net/mlx4_core: Use firmware driven flow steering hash mode") from Linus' tree and commit e448834e3545 ("m

linux-next: manual merge of the infiniband tree with Linus' tree

2013-02-25 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the infiniband tree got a conflict in drivers/net/ethernet/mellanox/mlx4/mlx4.h between commit 23537b732f5d ("net/mlx4_core: Use firmware driven flow steering hash mode") from Linus' tree and commit e448834e3545 ("mlx4_core: Enable memory windows in {INIT, QUERY

infiniband-diags maintainership notice

2013-02-25 Thread Ira Weiny
I have accepted a position with Intel and will be leaving LLNL. I'm still working on IB and will continue maintaining the infiniband-diags and libibmad packages. I will maintain access to the mailing list through the transition and will update my maintainers information when I have access to i

Re: [PATCH] Add fix to _do_madrpc to set the errno after umad_recv.

2013-02-25 Thread Sarat Kakarla
FOlks, Just a gentle reminder, whenever you get a chance please review the following fix. Thanks Sarat On 2/18/2013 2:10 PM, Sarat Kakarla wrote: _do_madrpc() (in libibmad-1.3.3/src/rpc.c) sends the mad request through umad_send() and waits for a response from umad_recv() with the timeou

Re: [PATCH infiniband-diags] Adding support for Debian packaging

2013-02-25 Thread Roland Dreier
On Fri, Feb 22, 2013 at 8:14 AM, Narayan Desai wrote: > Ah, sorry. I was speaking imprecisely; while the a bunch of the ib > libraries are pretty well maintained in debian/ubuntu, the management > tools are ancient. (this is why i built my PPA for ubuntu) > > I think there would be a lot of value

Re: [PATCH for-next 00/10] mlx4: Add Memory Windows support

2013-02-25 Thread Roland Dreier
OK, I went through the MW patches and they all look fine, so they're in my for-next now. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: srptools ("Virtual" ibnetdiscover command fails)

2013-02-25 Thread Bart Van Assche
On 02/06/13 11:40, Sebastian Riemer wrote: On 06.02.2013 11:20, Or Gerlitz wrote: On 06/02/2013 12:04, Mathis GAVILLON wrote: Just a last question : is that possible VFs lid to be different from PF one ? NO, we've implemented a "shared port" model, so all functions on the same IB port use the

[PATCH] libibumad: add UMAD_SA_STATUS_PRI_SUGGESTED to SA status.

2013-02-25 Thread Ira Weiny
Per: A13.5.2 Subnet Administration Status Values (QoS) Signed-off-by: Ira Weiny --- include/infiniband/umad_sa.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/infiniband/umad_sa.h b/include/infiniband/umad_sa.h index 5d6efe1..aaf2ac1 100644 --- a/include/in

Re: [PATCH for-next 00/10] mlx4: Add Memory Windows support

2013-02-25 Thread Roland Dreier
On Fri, Feb 22, 2013 at 4:17 AM, Or Gerlitz wrote: > I see now that you've picked five of the patches from this series into > for-next, anything which needs clarification or fixup in the other > five patches? No, I think the patches are probably fine. I just wanted to get the generic/easy-to-mer

[PATCH/RFC] IPoIB: Free ipoib neigh on path record failure so path rec queries are retried

2013-02-25 Thread Roland Dreier
From: Roland Dreier If IPoIB fails to look up a path record (eg if it tries during an SM failover when one SM is dead but the new one hasn't taken over yet), the driver ends up with a neighbour structure but no address handle (AH). There's no mechanism to recover from this: any further packets se

Re: [PATCH v4 0/4] IB/srp fixes

2013-02-25 Thread Or Gerlitz
On Mon, Feb 25, 2013 at 7:36 PM, Or Gerlitz wrote: > On Mon, Feb 25, 2013 at 7:32 PM, Roland Dreier wrote: >> All look good, applied for 3.9, thanks. > Roland, could you add a CC to -stable so they can get to 3.8-stable too? Oh, I see its just there, thanks! -- To unsubscribe from this list: se

Re: [PATCH v4 0/4] IB/srp fixes

2013-02-25 Thread Or Gerlitz
On Mon, Feb 25, 2013 at 7:32 PM, Roland Dreier wrote: > > All look good, applied for 3.9, thanks. Roland, could you add a CC to -stable so they can get to 3.8-stable too? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v4 0/4] IB/srp fixes

2013-02-25 Thread Roland Dreier
All look good, applied for 3.9, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mlx4: Remove redundant NULL check before kfree

2013-02-25 Thread Roland Dreier
Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Mon, Feb 25, 2013 at 8:54 AM, Roland Dreier wrote: > I'm finally noticing that this is in the build_mlx_header() function, > which is pretty much a slow path. Certainly another compare isn't > going to change performance given all the other stuff we do there. > > Let me look at the patches tha

Re: [PATCH v2] IB/mlx4: silence GCC warning

2013-02-25 Thread Roland Dreier
On Sun, Feb 24, 2013 at 4:34 AM, Jack Morgenstein wrote: > However, this approach does add the line below to processing for an IB port > (ETH/RoCE port stays same, more or less). > Processing time is therefore increased (at least on the IB side) relative to > just living with the warning. > > Ro

[PATCH] opensm: make osm_pr_rcv_get_end_points, osm_pr_rcv_process_pair, osm_pr_rcv_process_half public

2013-02-25 Thread Ira Weiny
Also change their name to from osm_pr_rcv_* to osm_pr_* Signed-off-by: Ira Weiny --- include/opensm/osm_sa.h | 25 + opensm/osm_sa_path_record.c | 22 +++--- 2 files changed, 36 insertions(+), 11 deletions(-) diff --git a/include/opensm/osm_sa.h

[PATCH] opensm: make osm_get_path_params public

2013-02-25 Thread Ira Weiny
Signed-off-by: Ira Weiny --- include/opensm/osm_sa.h | 21 + opensm/osm_sa_multipath_record.c | 10 -- opensm/osm_sa_path_record.c |9 - 3 files changed, 21 insertions(+), 19 deletions(-) diff --git a/include/opensm/osm_sa.h b/include/o