Re: [PATCH 03/14] IB/srp: Avoid that srp_reset_host() is skipped after a TL error

2013-06-13 Thread Sebastian Riemer
On 12.06.2013 15:23, Bart Van Assche wrote: > The SCSI error handler assumes that the transport layer is > operational if an eh_abort_handler() returns SUCCESS. Hence let > srp_abort() only return SUCCESS if sending the ABORT TASK task > management function succeeded. This patch avoids that the SCS

Re: [PATCH 04/14] IB/srp: Skip host settle delay

2013-06-13 Thread Sebastian Riemer
On 12.06.2013 15:24, Bart Van Assche wrote: > The SRP initiator implements host reset by reconnecting to the SRP > target. That means that communication with the target is possible > as soon as host reset finished. Hence skip the host settle delay. > > Signed-off-by: Bart Van Assche > Cc: Roland

Re: [PATCH 03/14] IB/srp: Avoid that srp_reset_host() is skipped after a TL error

2013-06-13 Thread Bart Van Assche
On 06/13/13 11:30, Sebastian Riemer wrote: On 12.06.2013 15:23, Bart Van Assche wrote: The SCSI error handler assumes that the transport layer is operational if an eh_abort_handler() returns SUCCESS. Hence let srp_abort() only return SUCCESS if sending the ABORT TASK task management function suc

Re: [PATCH] infiniband-diags: ibstat fix strncpy coverity check and -l bug

2013-06-13 Thread Hal Rosenstock
On 6/13/2013 12:15 AM, Ira Weiny wrote: > > Changes since V1: > Fix port parameter usage. > > Signed-off-by: Ira Weiny > --- > src/ibstat.c | 11 +++ > 1 files changed, 3 insertions(+), 8 deletions(-) > > diff --git a/src/ibstat.c b/src/ibstat.c > index 665bb0a..37f2361 100644

Re: [PATCH 04/14] IB/srp: Skip host settle delay

2013-06-13 Thread Or Gerlitz
On 13/06/2013 12:53, Sebastian Riemer wrote: On 12.06.2013 15:24, Bart Van Assche wrote: The SRP initiator implements host reset by reconnecting to the SRP target. That means that communication with the target is possible as soon as host reset finished. Hence skip the host settle delay. Signed-

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Sebastian Riemer
Hi Bart, thanks for picking up the idea not to use this 'add_target' file for manual reconnects. I have only small remarks but basically you've got my Acked-by and Tested-by. Please find the remarks in-line. Cheers, Sebastian On 12.06.2013 15:25, Bart Van Assche wrote: > An SRP target is requir

Re: [PATCH] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Sebastian Riemer
Bart's version also has the printing of the connection string if the double login fails. So forget about this version here. On 12.06.2013 13:51, Sebastian Riemer wrote: > Hi all, > > as proposed by Or, let's discuss this on the mailing list. > > This is a fundamental change required for everyth

[PATCH for-next 2/4] IB/mlx4: RoCE IP based GID addressing

2013-06-13 Thread Or Gerlitz
From: Moni Shoua Currently, the mlx4 driver set RoCE (IBoE) gids to encode related Ethernet netdevice interface MAC address and possibly VLAN id. Change this scheme such that gids encode interface IP addresses (both IP4 and IPv6). Signed-off-by: Moni Shoua Signed-off-by: Or Gerlitz --- drive

[PATCH for-next 0/4] IP based RoCE GID Addressing

2013-06-13 Thread Or Gerlitz
Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as they encode related Ethernet net-device interface MAC address and possibly VLAN id. This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6) of the that Ethernet interface, under the following reasoning: 1. There are e

[PATCH for-next 3/4] IB/core: Infra-structure to support verbs extensions through uverbs

2013-06-13 Thread Or Gerlitz
From: Igor Ivanov Add Infra-structure to support extended uverbs capabilities in a forward/backward manner. Uverbs command opcodes which are based on the verbs extensions approach should be greater or equal to IB_USER_VERBS_CMD_THRESHOLD. They have new header format and processed a bit differen

[PATCH for-next 1/4] IB/core: RoCE IP based GID addressing

2013-06-13 Thread Or Gerlitz
From: Moni Shoua Currently, the IB core assume RoCE (IBoE) gids encode related Ethernet netdevice interface MAC address and possibly VLAN id. Change gids to be treated as they encode interface IP address. Since Ethernet layer 2 address parameters are not longer encoded within gids, had to exten

[PATCH for-next 4/4] IB/core: Add RoCE IP based addressing extensions towards user space

2013-06-13 Thread Or Gerlitz
From: Matan Barak Add support for RoCE (IBoE) IP based addressing extensions towards user space. Extend INIT_QP_ATTR and QUERY_ROUTE ucma commands. Extend MODIFY_QP and CREATE_AH uverbs commands. Signed-off-by: Matan Barak Signed-off-by: Or Gerlitz --- drivers/infiniband/core/ucma.c

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Bart Van Assche
On 06/13/13 15:57, Sebastian Riemer wrote: > You've only changed the style of this function. Functionality is still > the same. Fine for me. > > But why do you put it that high in the source code? > Do you (still) need it for something else? > > I would put it directly in front of srp_create_targ

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Sebastian Riemer
On 13.06.2013 17:07, Bart Van Assche wrote: [...] > The "%.*s" should only copy the data provided by the user, even if it > is not '\0' terminated. Stripping the trailing newline is probably > possible with something like the (untested) code below (will only work > if there is only one newline in t

recommend setting for dev_loss_tmo and fast_io_fail_tmo

2013-06-13 Thread Vasiliy Tolstov
Hello. I'm using 3.9.5 and ib_srp_backport from github. What is recommended setting for dev_loss_tmo and fast_io_fail_tmo ? Now i have dev_loss_tmo = 60 fast_io_fail_tmo = 40 Does it right? I need to wait no more 100 seconds for failed path. (i'm use some xen vm on this host and it linux kernels

Re: [PATCH for-next 0/4] IP based RoCE GID Addressing

2013-06-13 Thread Jason Gunthorpe
On Thu, Jun 13, 2013 at 06:01:40PM +0300, Or Gerlitz wrote: > Currently, the IB stack (core + drivers) handle RoCE (IBoE) gids as > they encode related Ethernet net-device interface MAC address and > possibly VLAN id. > > This series changes RoCE GIDs to encode IP addresses (IPv4 + IPv6) > of the

Re: [PATCH for-next 4/4] IB/core: Add RoCE IP based addressing extensions towards user space

2013-06-13 Thread Jason Gunthorpe
On Thu, Jun 13, 2013 at 06:01:44PM +0300, Or Gerlitz wrote: > From: Matan Barak > > Add support for RoCE (IBoE) IP based addressing extensions towards > user space. > > Extend INIT_QP_ATTR and QUERY_ROUTE ucma commands. > > Extend MODIFY_QP and CREATE_AH uverbs commands. This is a really big p

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Vu Pham
Hello Bart, +/** + * srp_conn_unique() - check whether the connection to a target is unique + */ +static bool srp_conn_unique(struct srp_host *host, + struct srp_target_port *target) +{ + struct srp_target_port *t; + bool ret = false; + + if (target->s

Re: recommend setting for dev_loss_tmo and fast_io_fail_tmo

2013-06-13 Thread Bart Van Assche
On 06/13/13 17:52, Vasiliy Tolstov wrote: Hello. I'm using 3.9.5 and ib_srp_backport from github. What is recommended setting for dev_loss_tmo and fast_io_fail_tmo ? Now i have dev_loss_tmo = 60 fast_io_fail_tmo = 40 Does it right? I need to wait no more 100 seconds for failed path. (i'm use so

RE: [PATCH] infiniband-diags: ibstat fix strncpy coverity check and -l bug

2013-06-13 Thread Weiny, Ira
> -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Subject: Re: [PATCH] infiniband-diags: ibstat fix strncpy coverity check and > -l > bug > > On 6/13/2013 12:15 AM, Ira Weiny wrote: > > > > Changes since V1: > > Fix port parameter usage. > > > > Signed-off

Re: recommend setting for dev_loss_tmo and fast_io_fail_tmo

2013-06-13 Thread Vasiliy Tolstov
2013/6/13 Bart Van Assche : > Hello Vasily, > Hello, Bart. > The default value for the reconnect_delay parameter in that version of the > SRP initiator is 10 seconds. So if you want to give the SRP initiator a > chance to try once to reconnect before failing I/O fast you can set the > fast_io_fai

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Bart Van Assche
On 06/13/13 19:50, Vu Pham wrote: Hello Bart, +/** + * srp_conn_unique() - check whether the connection to a target is unique + */ +static bool srp_conn_unique(struct srp_host *host, +struct srp_target_port *target) +{ +struct srp_target_port *t; +bool ret = false; + +

Re: [PATCH] infiniband-diags: ibstat fix strncpy coverity check and -l bug

2013-06-13 Thread Hal Rosenstock
On 6/13/2013 2:20 PM, Weiny, Ira wrote: >> -Original Message- >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> Subject: Re: [PATCH] infiniband-diags: ibstat fix strncpy coverity check and >> -l >> bug >> >> On 6/13/2013 12:15 AM, Ira Weiny wrote: >>> >>> Changes since V1: >>>

Re: [PATCH 07/14] scsi_transport_srp: Add transport layer error handling

2013-06-13 Thread Vu Pham
Hello Bart, +What: /sys/class/srp_remote_ports/port-:/dev_loss_tmo +Date: September 1, 2013 +KernelVersion: 3.11 +Contact: linux-s...@vger.kernel.org, linux-rdma@vger.kernel.org +Description: Number of seconds the SCSI layer will wait after a transport + layer e

Re: [PATCH] mm: Revert pinned_vm braindamage

2013-06-13 Thread Andrew Morton
Let's try to get this wrapped up? On Thu, 6 Jun 2013 14:43:51 +0200 Peter Zijlstra wrote: > > Patch bc3e53f682 ("mm: distinguish between mlocked and pinned pages") > broke RLIMIT_MEMLOCK. I rather like what bc3e53f682 did, actually. RLIMIT_MEMLOCK limits the amount of memory you can mlock().

[PATCH 1/2] ibsim: Remove parse corner case with full ibnetdiscover output

2013-06-13 Thread Albert Chu
When feeding in ibnetdiscover full output (i.e. -f option), ibsim would not parse the lid and lmc of ports correctly. Signed-off-by: Albert L. Chu --- ibsim/sim_net.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/ibsim/sim_net.c b/ibsim/sim_net.c index 13c3b8c..10820ba

[PATCH 2/2] ibsim: Add support for fabric VL Cap in network definition file

2013-06-13 Thread Albert Chu
Signed-off-by: Albert L. Chu --- ibsim/sim.h |1 + ibsim/sim_mad.c |2 ++ ibsim/sim_net.c | 28 ++-- 3 files changed, 29 insertions(+), 2 deletions(-) diff --git a/ibsim/sim.h b/ibsim/sim.h index daeecec..831b4a5 100644 --- a/ibsim/sim.h +++ b/ibsim/sim.h @@

[PATCH 1/2] ibnetdiscover: Add missing -f option to manpage

2013-06-13 Thread Albert Chu
Signed-off-by: Albert L. Chu --- doc/man/ibnetdiscover.8.in |3 +++ doc/rst/ibnetdiscover.8.in.rst |3 +++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/doc/man/ibnetdiscover.8.in b/doc/man/ibnetdiscover.8.in index 18c353d..0c3d8a4 100644 --- a/doc/man/ibnetdiscover.8

[PATCH 2/2] ibnetdiscover: Output vlcap in full output format

2013-06-13 Thread Albert Chu
The additional vlcap information is useful when simulating a fabric in ibsim and fabric VL information is needed. Signed-off-by: Albert L. Chu --- doc/man/ibnetdiscover.8.in |2 +- doc/rst/ibnetdiscover.8.in.rst |2 +- src/ibnetdiscover.c| 10 +++--- 3 files changed

Re: [PATCH 05/14] IB/srp: Maintain a single connection per I_T nexus

2013-06-13 Thread Vu Pham
Bart Van Assche wrote: On 06/13/13 19:50, Vu Pham wrote: Hello Bart, +/** + * srp_conn_unique() - check whether the connection to a target is unique + */ +static bool srp_conn_unique(struct srp_host *host, +struct srp_target_port *target) +{ +struct srp_target_port *t; +

[Trivial PATCH 11/33] infiniband: Convert use of typedef ctl_table to struct ctl_table

2013-06-13 Thread Joe Perches
This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/infiniband/core/ucma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 5ca44cd..9416280 100644 --- a/drivers/in

[Trivial PATCH 00/33] Remove uses of typedef ctl_table

2013-06-13 Thread Joe Perches
It's clearer to use struct ctl_table instead Joe Perches (33): arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table frv: Convert use of typedef ctl_table to struct ctl_table ia64: crash: Convert use of typedef ctl_table to struct ctl_table mips: lasat: sysctl: Convert use