Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Jack Morgenstein
On Thursday 04 July 2013 17:17, Joe Perches wrote: > Not the vertical spacing, the newline inside the quotes. > ie: "unknown status code\n" should be "unknown status code" > You're right! I misunderstood, and did not notice the newline char. Good catch! While I was at it, though, I eliminated th

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Joe Perches
On Thu, 2013-07-04 at 16:26 +0300, Jack Morgenstein wrote: > On Wednesday 03 July 2013 23:29, Joe Perches wrote: > > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > > From: Eli Cohen > > > > trivial comments: > > > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > > > b/

Re: [PATCH V2 5/9] IB/mlx5: Mellanox Connect-IB, IB driver part 1/5

2013-07-04 Thread Jack Morgenstein
On Thursday 04 July 2013 16:15, Jack Morgenstein wrote: > > > +   *inlen = sizeof **cqb + sizeof *(*cqb)->pas * ncont; > > > > sizeof always uses parentheses > I'll fix this, too. -Jack -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...

Re: [PATCH V2 7/9] IB/mlx5: Mellanox Connect-IB, IB driver part 3/5

2013-07-04 Thread Jack Morgenstein
On Thursday 04 July 2013 00:10, Joe Perches wrote: > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > From: Eli Cohen > > More trivia: > > > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h > > b/drivers/infiniband/hw/mlx5/mlx5_ib.h > [] > > +#define mlx5_ib_dbg(dev, format, arg...)

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Jack Morgenstein
On Wednesday 03 July 2013 23:29, Joe Perches wrote: > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > From: Eli Cohen > > trivial comments: > > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > > b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > [] > > +static const char *

Re: [PATCH V2 5/9] IB/mlx5: Mellanox Connect-IB, IB driver part 1/5

2013-07-04 Thread Jack Morgenstein
On Wednesday 03 July 2013 23:59, Joe Perches wrote: > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > From: Eli Cohen > > diff --git a/drivers/infiniband/hw/mlx5/ah.c > > b/drivers/infiniband/hw/mlx5/ah.c > [] > > +struct ib_ah *create_ib_ah(struct ib_ah_attr *ah_attr, > > +

[PATCH V3 4/4] RDMA/cxgb4: Add support for active and passive open connection with IPv6 address

2013-07-04 Thread Vipul Pandya
Add new cpl messages, cpl_act_open_req6 and cpl_t5_act_open_req6, for initiating active open connections. Use LLD api cxgb4_create_server and cxgb4_create_server6 for initiating passive open connections. Similarly use cxgb4_remove_server to remove the passive open connections in place of listen_st

[PATCH V3 2/4] cxgb4: Add routines to create and remove listening IPv6 servers

2013-07-04 Thread Vipul Pandya
Add cxgb4_create_server6 and cxgb4_remove_server routines to create and remove listening IPv6 servers. Return success (0) from cxgb4_create_server in case of ctrl queue congestion since in case of congestion, passive open request gets queued and gets processed later. If non zero value is returned

[PATCH V3 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-07-04 Thread Vipul Pandya
From: Steve Wise This patch modifies the type of local_addr and remote_addr fields in struct iw_cm_id from struct sockaddr_in to struct sockaddr_storage to hold IPv6 and IPv4 addresses uniformly. It changes the references of local_addr and remote_addr in RDMA/cxgb4, RDMA/cxgb3, RDMA/nes and amso

[PATCH V3 3/4] cxgb4: Add CLIP support to store compressed IPv6 address

2013-07-04 Thread Vipul Pandya
The Compressed LIP region is used to hold a limited number of Local IPv6 addresses. This region is primarily used to reduce the TCAM space consumed for an IPv6 offloaded connection. A 128-bit LIP will be reduced to 13-bit and stored in the TCAM if there is a match between the IPv6 tuple's LIP and t

[PATCH V3 0/4] Add IPv6 support for iWARP

2013-07-04 Thread Vipul Pandya
Hi All, This patch series adds IPv6 support for iWARP. It enables Chelsio's T4 and T5 adapters to transmitt RDMA traffic over IPv6 address. It adds new apis and cpl messages in cxgb4 to support IPv6 operations and uses them in RDMA/cxgb4. The patch series modifies the type of local_addr and remo

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-04 Thread Bart Van Assche
On 07/04/13 10:01, Bart Van Assche wrote: On 07/03/13 20:57, David Dillow wrote: And I'm getting the strong sense that the answer to my question about fast_io_fail_tmo >= 0 when dev_loss_tmo is that we should not allow that combination, even if it doesn't break the kernel. If it doesn't make sen

Re: [PATCH v3 07/13] scsi_transport_srp: Add transport layer error handling

2013-07-04 Thread Bart Van Assche
On 07/03/13 20:57, David Dillow wrote: And I'm getting the strong sense that the answer to my question about fast_io_fail_tmo >= 0 when dev_loss_tmo is that we should not allow that combination, even if it doesn't break the kernel. If it doesn't make sense, there is no reason to create an opportu