Re: [PATCH V2 for-next 2/4] IB/core: Infra-structure to support verbs extensions through uverbs

2013-07-15 Thread Or Gerlitz
On Tue, Jul 9, 2013 at 6:00 PM, Tzahi Oved wrote: > On 26/06/2013 16:05, Roland Dreier wrote: > >> I don't understand what "extended capabilities" are or why we need > to change the header format. > > First let me clarify the target of *this* patch - allow extending > uverbs new commands input an

Re: [PATCH for-next 0/4] IP based RoCE GID Addressing

2013-07-15 Thread Or Gerlitz
Devesh Sharma wrote: [...] > What will happen to those devices which does not suppot IP based RoCE, How > connection management will happen with those if Native RoCE support is > removed. There may be other devices/implementations which does not support > IP Base RoCE. RoCE GIDs is something pro

Re: [PATCH V7 libibverbs 0/7] Add extension and XRC QP support

2013-07-15 Thread Jason Gunthorpe
On Mon, Jul 15, 2013 at 03:40:47PM +0300, Yishai Hadas wrote: > Hi Jason, > > Let me clarify the place holder reservation mentioned in the cover > letter. The entries I was referring to are not proprietary vendor > verbs but rather user space verbs who are on their way to be > submitted upstream

RE: [PATCH] RDMA/cma: silence GCC warning

2013-07-15 Thread Hefty, Sean
> 1) Perhaps a better way to silence GCC is to drop "port" entirely, and > assign to "id_priv->id.port_num" directly. Would that be acceptable? Yes, this would work. - Sean

Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-15 Thread Tim Gardner
On 07/15/2013 09:52 AM, Randy Dunlap wrote: > On 07/15/13 07:56, Tim Gardner wrote: >> Cc: Eli Cohen Signed-off-by: Tim Gardner >> > > I reported this last week and Eli wrote: > > "I have this fixed in my tree and we run the driver on i386. I will > check on Sunday why it is not in the patches

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-15 Thread Bart Van Assche
On 15/07/2013 7:29, Sagi Grimberg wrote: srp_daemon is a package designated for the customer to automatically detect targets in the IB fabric. From our experience here in Mellanox, customers/users like automatic "plug&play" tools. They are reluctant to build their own scriptology to enhance perfo

Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

2013-07-15 Thread Vu Pham
Bart Van Assche wrote: If the transport layer is offline it is more appropriate to let srp_abort() return FAST_IO_FAIL instead of SUCCESS. Signed-off-by: Bart Van Assche Reported-by: Sebastian Riemer Cc: David Dillow Cc: Roland Dreier Cc: Vu Pham --- drivers/infiniband/ulp/srp/ib_srp.c |

Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

2013-07-15 Thread Vu Pham
Bart Van Assche wrote: If the transport layer is offline it is more appropriate to let srp_abort() return FAST_IO_FAIL instead of SUCCESS. Signed-off-by: Bart Van Assche Reported-by: Sebastian Riemer Cc: David Dillow Cc: Roland Dreier Cc: Vu Pham --- drivers/infiniband/ulp/srp/ib_srp.c |

Re: ibdiagnet: ibdiagnet /tmp clobbering vulnerability

2013-07-15 Thread Pramod Gunjikar
Copying Rajkumar. Rajkumar is also in on this alias. Thanks Pramod Sending this on behalf of Rajkumar Sivaprakasam. Pramod <--> The diff of the proposed changes for fixing the CVE 2013-2561 is in the a

Re: [PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-15 Thread Randy Dunlap
On 07/15/13 07:56, Tim Gardner wrote: > Cc: Eli Cohen > Signed-off-by: Tim Gardner I reported this last week and Eli wrote: "I have this fixed in my tree and we run the driver on i386. I will check on Sunday why it is not in the patches submitted." Anyway, the patch works for me. Acked-by: R

[PATCH 3.11-rc1] mlx5 core: Fix __udivdi3 when compiling for 32 bit arches

2013-07-15 Thread Tim Gardner
Cc: Eli Cohen Signed-off-by: Tim Gardner --- drivers/net/ethernet/mellanox/mlx5/core/debugfs.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c index 4273c06..9c7194b 1006

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-15 Thread Eli Cohen
Hi Dan, thanks for cathing this. I will fix this an a subsequent patch. Currently we can consider this non critical as we don't use commands from interrupt context. On Wed, Jul 10, 2013 at 01:55:38PM +0300, Dan Carpenter wrote: > Hello Eli Cohen, > > The patch e126ba97dba9: "mlx5: Add driver for

Repeated Stale Connection errors on successive reconnect attempt with new cmid/QPs..

2013-07-15 Thread lokesh agarwal
Hello, I am using rdmacm as my connection manager and I have N processes trying to establish a complete mesh of connections over RC protocol. I am receiving Connection rejected event with error 10. As per the IBTA, the Connection Server is rejecting the connection requests thinking that it is a s

Re: rtnl_lock deadlock on 3.10

2013-07-15 Thread Shawn Bohrer
On Wed, Jul 03, 2013 at 08:26:11PM +0300, Or Gerlitz wrote: > On 03/07/2013 20:22, Shawn Bohrer wrote: > >On Wed, Jul 03, 2013 at 07:33:07AM +0200, Hannes Frederic Sowa wrote: > >>On Wed, Jul 03, 2013 at 07:11:52AM +0200, Hannes Frederic Sowa wrote: > >>>On Tue, Jul 02, 2013 at 01:38:26PM +, Co

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-15 Thread Or Gerlitz
On 10/07/2013 13:55, Dan Carpenter wrote: Hello Eli Cohen, The patch e126ba97dba9: "mlx5: Add driver for Mellanox Connect-IB adapters" from Jul 7, 2013, leads to the following Smatch warning: "drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822 mlx5_alloc_cmd_msg() warn: use 'flags' here

[PATCH infiniband-diags] infiniband-diags: Eliminate unneeded clean_nodedesc calls

2013-07-15 Thread Hal Rosenstock
in ibroute and dump_fts clean_nodedesc is called if needed within remap_node_name Signed-off-by: Hal Rosenstock --- diff --git a/src/dump_fts.c b/src/dump_fts.c index 89f0dce..5383c9d 100644 --- a/src/dump_fts.c +++ b/src/dump_fts.c @@ -154,7 +154,7 @@ void dump_multicast_tables(ibnd_node_t * no

Re: [PATCH] libibverbs: Add the use of IBV_SEND_INLINE to example pingpong programs

2013-07-15 Thread Jeff Squyres (jsquyres)
Bump. On Jul 10, 2013, at 4:32 PM, Jeff Squyres wrote: > If the send size is less than the cap.max_inline_data reported by the > qp, use the IBV_SEND_INLINE flag. This now only shows the example of > using ibv_query_qp(), it also reduces the latency time shown by the > pingpong programs when th

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-15 Thread Jeff Squyres (jsquyres)
Bump. On Jul 10, 2013, at 8:14 AM, Jeff Squyres (jsquyres) wrote: > On Jul 8, 2013, at 1:26 PM, Jason Gunthorpe > wrote: > >> Jeff's patch doesn't break old binaries, old binaries, running with >> normal IB MTUs work fine. The structure layouts all stay the same, >> etc. > > > FWIW, I did a

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-15 Thread Sagi Grimberg
On 7/15/2013 2:06 PM, Bart Van Assche wrote: On 14/07/2013 3:43, Sagi Grimberg wrote: On 7/3/2013 3:58 PM, Bart Van Assche wrote: Several InfiniBand HCA's allow to configure the completion vector per queue pair. This allows to spread the workload created by IB completion interrupts over multipl

Re: [PATCH V7 libibverbs 0/7] Add extension and XRC QP support

2013-07-15 Thread Yishai Hadas
Hi Jason, Let me clarify the place holder reservation mentioned in the cover letter. The entries I was referring to are not proprietary vendor verbs but rather user space verbs who are on their way to be submitted upstream for inclusion in libibverbs/libmlx4. Two of these verbs are the userspac

Re: [PATCH v3 11/13] IB/srp: Make HCA completion vector configurable

2013-07-15 Thread Bart Van Assche
On 14/07/2013 3:43, Sagi Grimberg wrote: On 7/3/2013 3:58 PM, Bart Van Assche wrote: Several InfiniBand HCA's allow to configure the completion vector per queue pair. This allows to spread the workload created by IB completion interrupts over multiple MSI-X vectors and hence over multiple CPU co

[PATCH] RDMA/cma: silence GCC warning

2013-07-15 Thread Paul Bolle
Building cma.o triggers this GCC warning: drivers/infiniband/core/cma.c: In function ‘rdma_resolve_addr’: drivers/infiniband/core/cma.c:465:23: warning: ‘port’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/infiniband/core/cma.c:426:5: note: ‘port’ was decla