Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-11 Thread Or Gerlitz
On 12/09/2013 00:07, Upinder Malhi (umalhi) wrote: Hi Or, The GRH is emulated by software. That is, when the app receives a packet, the first 40 bytes contain the GRH. I was asking what protocol you are using in the Ethernet MAC header on the wire? Or. On Sep 11, 2013, at 12:19

Re: [PATCH V4 9/9] IB/mlx4: Enable mlx4_ib support for MODIFY_QP_EX

2013-09-11 Thread Devesh Sharma
Hi Or, I don't see any patches to librdmacm/libibverbs git to call _EX version of uverbs commands. The patch you have pointed in v4-0 patch still seems to be incomplete. Are these broken? On Tue, Sep 10, 2013 at 8:11 PM, Or Gerlitz wrote: > From: Matan Barak > > mlx4_ib driver should indicate t

Re: [PATCH 8/8] IB/srp: Make queue size configurable

2013-09-11 Thread David Dillow
On Tue, 2013-09-10 at 19:44 +0200, Bart Van Assche wrote: > If this name was not yet in use in any interface that is visible in user > space, I would agree that we should come up with a better name. However, > the SCSI mid-layer already uses that name today to export the queue > size. To me this

Re: [PATCH V2 2/4] IB/usnic: Cisco VIC - driver part 1/3

2013-09-11 Thread Upinder Malhi (umalhi)
Hi Or, The GRH is emulated by software. That is, when the app receives a packet, the first 40 bytes contain the GRH. Upinder On Sep 11, 2013, at 12:19 PM, Or Gerlitz wrote: > So you are supporting UD QPs but these QPs don't generate IBTA UD > headers nor iWARP headers, correct? -- To

[PATCH librdmacm] man/rstream.1: Update man page to be consistent with rstream -h

2013-09-11 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/man/rstream.1 b/man/rstream.1 index 29aa66b..f53679f 100644 --- a/man/rstream.1 +++ b/man/rstream.1 @@ -4,8 +4,8 @@ rstream \- streaming over RDMA ping-pong test. .SH SYNOPSIS .sp .nf -\fIrstream\fR [-s server_address] [-b bind_address] [-B buffer

[PATCH librdmacm] rstream.c: Indicate when specified address family is unknown

2013-09-11 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock >h...@mellanox.com> --- diff --git a/examples/rstream.c b/examples/rstream.c index 278437f..cf84716 100644 --- a/examples/rstream.c +++ b/examples/rstream.c @@ -586,6 +586,8 @@ int main(int argc, char **argv) rai_hints.ai_flags = RAI_NU

[PATCH librdmacm] man/rdma_create_id.3: Add RDMA_PS_IB port space description

2013-09-11 Thread Hal Rosenstock
Signed-off-by: Hal Rosenstock --- diff --git a/man/rdma_create_id.3 b/man/rdma_create_id.3 index da333fb..81acc9b 100644 --- a/man/rdma_create_id.3 +++ b/man/rdma_create_id.3 @@ -47,6 +47,8 @@ port space provides message, not stream, based communication. .IP RDMA_PS_UDP Provides unreliable, con

RE: [PATCH krping 0/2] krping fixes to work with latest kernels

2013-09-11 Thread Alex Tabachnik
Hi, Also credit should be given to Roi Dayan (r...@mellanox.com) - it was our joint work. Thank you, Alex -Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Wednesday, September 11, 2013 5:50 PM To: Or Gerlitz Cc: linux-rdma@vger.kernel.org; realrichardsha..

Re: [PATCH krping 0/2] krping fixes to work with latest kernels

2013-09-11 Thread Steve Wise
On 9/11/2013 9:20 AM, Or Gerlitz wrote: Hi Steve, This little series from Alex makes krping from git://git.openfabrics.org/~swise/krping.git usable for latest upstream kernels, something we find very useful for testing the upstream RDMA stack when developing variuos features. Or. Alex Tabachn

Re: [PATCH krping 0/2] krping fixes to work with latest kernels

2013-09-11 Thread Or Gerlitz
On 11/09/2013 17:32, Steve Wise wrote: What HW did you test on? Connect-IB HW, mlx5 driver -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs

2013-09-11 Thread Or Gerlitz
On 11/09/2013 17:04, Yann Droneaud wrote: [...] + int i; + int kern_attr_size; + + if (out_len < sizeof(resp)) + return -ENOSPC; + + if (copy_from_user(&cmd, buf, sizeof(cmd))) + return -EFAULT; + + if (cmd.comp_mask) + retu

Re: [PATCH V4 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs

2013-09-11 Thread Yann Droneaud
Le 11.09.2013 17:10, Or Gerlitz a écrit : On 11/09/2013 17:04, Yann Droneaud wrote: [...] + int i; + int kern_attr_size; + + if (out_len < sizeof(resp)) + return -ENOSPC; + + if (copy_from_user(&cmd, buf, sizeof(cmd))) + return -EFAULT; + +

Re: [PATCH krping 0/2] krping fixes to work with latest kernels

2013-09-11 Thread Steve Wise
On 9/11/2013 9:20 AM, Or Gerlitz wrote: Hi Steve, This little series from Alex makes krping from git://git.openfabrics.org/~swise/krping.git usable for latest upstream kernels, something we find very useful for testing the upstream RDMA stack when developing variuos features. Or. Alex Tabachn

[PATCH krping 0/2] krping fixes to work with latest kernels

2013-09-11 Thread Or Gerlitz
Hi Steve, This little series from Alex makes krping from git://git.openfabrics.org/~swise/krping.git usable for latest upstream kernels, something we find very useful for testing the upstream RDMA stack when developing variuos features. Or. Alex Tabachnik (2): Fixes and changes to support lat

[PATCH krping 1/2] Fixes and changes to support latest kernels

2013-09-11 Thread Or Gerlitz
From: Alex Tabachnik Allow to build on latest upstream kernels Signed-off-by: Alex Tabachnik --- krping.c | 33 +++-- 1 files changed, 19 insertions(+), 14 deletions(-) diff --git a/krping.c b/krping.c index 67381af..59900ab 100644 --- a/krping.c +++ b/krping.c @

[PATCH krping 2/2] Update Makefile

2013-09-11 Thread Or Gerlitz
From: Alex Tabachnik To allow standalone compilation with latest 3.x kernels Signed-off-by: Alex Tabachnik --- Makefile | 33 +++-- 1 files changed, 3 insertions(+), 30 deletions(-) diff --git a/Makefile b/Makefile index abfaeb1..47fa0c0 100644 --- a/Makefile +++

Re: [PATCH V4 for-next 3/4] IB/core: Export ib_create/destroy_flow through uverbs

2013-09-11 Thread Yann Droneaud
Le mercredi 28 août 2013 à 15:47 +0300, Matan Barak a écrit : > From: Hadar Hen Zion > > Implement ib_uverbs_create_flow and ib_uverbs_destroy_flow to > support flow steering for user space applications. > > Change-Id: I0bc6dbe26f4776d00f95b6200ff43ccb24000e31 > Signed-off-by: Hadar Hen Zion >

[PATCH fixes-3.12 03/15] IB/mlx5: Fix memory leak in mlx5_ib_create_srq

2013-09-11 Thread Or Gerlitz
From: Moshe Lazer The patch fixes the rollback in case of failure in creating SRQ. Signed-off-by: Moshe Lazer Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/srq.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/srq.c b/drivers/in

[PATCH fixes-3.12 13/15] IB/mlx5: Fix eq names to display nicely in /proc/interrupts

2013-09-11 Thread Or Gerlitz
From: Sagi Grimberg It is normal for a device to display the pci slot name along with it's IRQs, so the user which will check /proc/interrupts will see the pci slot of the device. Signed-off-by: Sagi Grimberg Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/main.c|6 +++

[PATCH fixes-3.12 00/15] Mellanox mlx5 driver fixes

2013-09-11 Thread Or Gerlitz
Hi Roland, This series from Eli and Co contains batch of bug fixes to mlx5 issues we've stumbled on during various regression tests. Few other fixes which are more of cleanups and enhancements will be sent for-next/3.13 once this series gets into 3.12 One or two patches need to go into -stabl

[PATCH fixes-3.12 01/15] IB/mlx5: Fix send work queue size calculation

2013-09-11 Thread Or Gerlitz
From: Eli Cohen 1. Make sure wqe_cnt does not exceed the limit published by firmware. 2. There is no requirement that the number of outstanding work requests will be a power of two. Remove the ilog2 in the calculation of sq.max_post to fix that. 3. Add case for IB_QPT_XRC_TGT in sq_overhead a

[PATCH fixes-3.12 06/15] IB/mlx5: Avoid async events on invalid port number

2013-09-11 Thread Or Gerlitz
From: Eli Cohen On a single ported Connect-IB, its possible for the firmware to issue events on the non-existing 2nd port. Make sure to ignore events generated for such ports. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/main.c |5 + 1 files changed, 5 insertions(+), 0 delet

[PATCH fixes-3.12 07/15] mlx5: Keep polling to reclaim pages while any returned

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Change mlx5_reclaim_startup_pages() to keep polling while any pages are returned. If none are returned, keep polling for five more seconds before exiting with an error message. Signed-off-by: Eli Cohen --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 16 ++

[PATCH fixes-3.12 05/15] IB/mlx5: Decrease memory consumption of mr caches

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Change the logic so we do not allocate memory nor map the device before actually posting to the REG_UMR QP. In addition, unmap and free the memory after we get completion. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/mr.c | 57 +++---

[PATCH fixes-3.12 11/15] IB/mlx5: Fix opt param mask according to firmware spec

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Failed to configure opt mask to configure rre from init to rtr. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/qp.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index

[PATCH fixes-3.12 09/15] IB/mlx5: Disable atomic operations

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Currently Atomic operations don't work properly. Disable them for the time being. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/main.c |5 +-- drivers/infiniband/hw/mlx5/qp.c | 48 +++- 2 files changed, 6 insertions(+), 47 delet

[PATCH fixes-3.12 15/15] IB/mlx5: Ensure proper synchronization accessing memory

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Call mlx5_ib_populate_pas() before mapping the DMA buffer to ensure the hardware reads the values written by the CPU. Found by: Haggai Eran Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/mr.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

[PATCH fixes-3.12 02/15] IB/mlx5: Flush cache workqueue before destroying it

2013-09-11 Thread Or Gerlitz
From: Moshe Lazer Destroying the workqueue without flushing it first can lead to a case in which the kernel tries to push a delayed work to the workqueue which does not exist anymore. Signed-off-by: Moshe Lazer Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/mr.c |6 +- 1 file

[PATCH fixes-3.12 14/15] IB/mlx5: Fix alignment of reg umr gather buffers

2013-09-11 Thread Or Gerlitz
From: Eli Cohen The hardware requires that gather buffers for UMR work requests be aligned to 2K. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/mr.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband

[PATCH fixes-3.12 12/15] mlx5: Fix error code translation from firmware to driver

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Limits exceeded should be translated to ENOMEM. Signed-off-by: Eli Cohen --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/ml

[PATCH fixes-3.12 08/15] mlx5: Fix layout of struct mlx5_init_seg

2013-09-11 Thread Or Gerlitz
From: Eli Cohen The layout of struct health_buffer was not according to firmware specification. Fix it to comply. Signed-off-by: Eli Cohen --- include/linux/mlx5/device.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/mlx5/device.h b/include/linux/mlx5/

[PATCH fixes-3.12 04/15] mlx5: Remove checksum on command interface commands

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Checksum calculations consume CPU resources and can be significant to the rate of resource creation/destruction. Signed-off-by: Eli Cohen --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 26 --- drivers/net/ethernet/mellanox/mlx5/core/main.c | 21 +++

[PATCH fixes-3.12 10/15] mlx5: Fix opt param mask for sq err to rts transition

2013-09-11 Thread Or Gerlitz
From: Eli Cohen Add missing entry in the table for UC transport. Signed-off-by: Eli Cohen --- drivers/infiniband/hw/mlx5/qp.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c index 10b077d..546d3e9 100644

[PATCH opensm] Use after free in osm_prtn_delete

2013-09-11 Thread Hal Rosenstock
From: Vladimir Koushnir Signed-off-by: Vladimir Koushnir Signed-off-by: Hal Rosenstock --- opensm/osm_prtn.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/opensm/osm_prtn.c b/opensm/osm_prtn.c index ca7703d..24a1fe3 100644 --- a/opensm/osm_prtn.c +++ b/opensm/osm_pr

[PATCH opensm] Use trap number defines rather than actual trap numbers

2013-09-11 Thread Hal Rosenstock
Trap number defines were added in ib_types.h as part of: commit ae9d7e7f4e2f62eabad4cf9d60cd5b68a8295147 Author: Line Holen Date: Thu May 30 18:16:43 2013 + Add trap details to notice log message Signed-off-by: Line Holen Signed-off-by: Hal Rosenstock Signed-off-by: Hal

Re: [PATCH V4 7/9] IB/core: Add RoCE IP based addressing extensions for uverbs

2013-09-11 Thread Yann Droneaud
Le 11.09.2013 13:38, Or Gerlitz a écrit : On 11/09/2013 13:06, m...@meuh.org wrote: @@ -672,6 +821,15 @@ struct ib_uverbs_create_ah { struct ib_uverbs_ah_attr attr; }; +struct ib_uverbs_create_ah_ex { +__u32 comp_mask; This create a hole or introduced unaligned access depending on

Re: [PATCH V4 8/9] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-09-11 Thread Yann Droneaud
Le 11.09.2013 13:32, Or Gerlitz a écrit : On 11/09/2013 12:52, Yann Droneaud wrote: Le 10.09.2013 16:41, Or Gerlitz a écrit : +static ssize_t ucma_init_qp_attr_ex(struct ucma_file *file, +const char __user *inbuf, +int in_len, int out_len) +{ +struct

Re: [PATCH V4 7/9] IB/core: Add RoCE IP based addressing extensions for uverbs

2013-09-11 Thread Or Gerlitz
On 11/09/2013 13:06, m...@meuh.org wrote: @@ -672,6 +821,15 @@ struct ib_uverbs_create_ah { struct ib_uverbs_ah_attr attr; }; +struct ib_uverbs_create_ah_ex { +__u32 comp_mask; This create a hole or introduced unaligned access depending on the 64bits ABI. Matan is OOO for couple

Re: [PATCH V4 8/9] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-09-11 Thread Or Gerlitz
On 11/09/2013 12:52, Yann Droneaud wrote: Le 10.09.2013 16:41, Or Gerlitz a écrit : +static ssize_t ucma_init_qp_attr_ex(struct ucma_file *file, +const char __user *inbuf, +int in_len, int out_len) +{ +struct rdma_ucm_init_qp_attr_ex cmd; +struct i

Re: [PATCH V4 7/9] IB/core: Add RoCE IP based addressing extensions for uverbs

2013-09-11 Thread meuh
Le 10.09.2013 16:41, Or Gerlitz a écrit : From: Matan Barak Add uverbs support for RoCE (IBoE) IP based addressing extensions towards user space libraries. Under ip based gid addressing, for RC QPs, QP attributes should contain the Ethernet L2 destination. Until now, indicatings GID was suffi

Re: [PATCH V4 8/9] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-09-11 Thread Yann Droneaud
Le 10.09.2013 16:41, Or Gerlitz a écrit : From: Matan Barak Add rdma_ucm support for RoCE (IBoE) IP based addressing extensions towards librdmacm Extend INIT_QP_ATTR and QUERY_ROUTE ucma commands. INIT_QP_ATTR_EX uses struct ib_uverbs_qp_attr_ex QUERY_ROUTE_EX uses struct rdma_ucm_query_rout