smatch warnings on the IB core

2013-10-27 Thread Or Gerlitz
Hi Dan, With the latest smatch I still see these hits on the IB core, basically, I would be happy to see the IB stack free from such warnings and then we can easily require each new patch not to introduce them... can you shed some light on the problem and possible solutions?

Re: [PATCH V4 8/9] IB/core: Add RoCE IP based addressing extensions for rdma_ucm

2013-10-27 Thread Tzahi Oved
On 22/09/2013 10:32, Matan Barak wrote: On 18/9/2013 1:07 PM, Yann Droneaud wrote: Hi, Le 18.09.2013 10:40, Matan Barak a écrit : On 17/9/2013 6:43 PM, Yann Droneaud wrote: Le 17.09.2013 17:13, Matan Barak a écrit : On 17/9/2013 1:25 PM, Yann Droneaud wrote: Hi, Le 17.09.2013 12:02, Matan

[PATCH 0/8] Fix minor address type errors

2013-10-27 Thread Ben Hutchings
Various bits of code are mixing making assumptions about the size of dma_addr_t or resource_size_t, or mixing up pointer and integer types. All these fixes are based on compiler warnings and so far as I can see the bugs are practically harmless. Ben. Ben Hutchings (8): IB/cxgb4: Fix

[PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Ben Hutchings
Physical addresses may be wider than virtual addresses (e.g. on i386 with PAE) and must not be formatted with %p. Compile-tested only. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- The resource could also be printed using '%pR' or '%pr', but that makes a bigger change to the output.

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: Physical addresses may be wider than virtual addresses (e.g. on i386 with PAE) and must not be formatted with %p. %pa works. %pa also prefixes with 0x. diff --git a/drivers/infiniband/hw/cxgb4/device.c

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Ben Hutchings
On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: Physical addresses may be wider than virtual addresses (e.g. on i386 with PAE) and must not be formatted with %p. %pa works. %pa also prefixes with 0x. Only as long as

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:02 +, Ben Hutchings wrote: On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: Physical addresses may be wider than virtual addresses (e.g. on i386 with PAE) and must not be formatted with %p. %pa

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Ben Hutchings
On Sun, 2013-10-27 at 15:14 -0700, Joe Perches wrote: On Sun, 2013-10-27 at 22:02 +, Ben Hutchings wrote: On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: Physical addresses may be wider than virtual addresses (e.g. on i386

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:26 +, Ben Hutchings wrote: I don't think so. This doesn't find anything: git grep '[ (]*pci_resource_start' and I was able to build drivers/{net,pci,scsi}/ successfully with pci_resource_start() changed to an inline function. Hi again Ben. You're right. It