On 10/30/2013 5:55 PM, Or Gerlitz wrote:
On 30/10/2013 17:20, Hefty, Sean wrote:
The team here enhanced krping to fully cover (and test...) the proposed
>API and driver implementation, its (free) under
>git://beany.openfabrics.org/~sgrimberg/krping.git
>
>We'd like to see this landing in 3.13 su
This commit takes care of the generated signature
error cqe generated by the HW (if happened). The
underlying mlx5 driver will handle signature error
completions and will mark the relevant memory region
as dirty.
Once the user will get the completion for the transaction
he must check for signature
This commit introduces verbs for creating/destoying memory
regions which will allow new types of memory key operations such
as protected memory registration.
Indirect memory registration is registering several (one
of more) pre-registered memory regions in a specific layout.
The Indirect region ma
This patch implements IB_WR_REG_SIG_MR posted by the user.
Baisically this WR involvs 3 WQEs in order to prepare and properly
register the signature layout:
1. post UMR WR to register the sig_mr in one of two possible ways:
* In case the user registered a single MR for data so the UMR data se
This commit Introduces the Verbs Interface for signature related
operations. A signature handover operation shall configure the
layouts of data and protection attributes both in memory and wire
domains.
Signature operations are:
- INSERT
Generate and insert protection information when handing ov
get_umr_flags helper function might be used for types
of access modes other than ACCESS_MODE_MTT, such as
ACCESS_MODE_KLM. so remove it from helper and caller
will add it's own access mode flag.
This commit does not add/change functionality.
Signed-off-by: Sagi Grimberg
---
drivers/infiniband/h
Currently support only T10-DIF types of signature
handover operations (typs 1|2|3).
Signed-off-by: Sagi Grimberg
---
drivers/infiniband/hw/mlx5/main.c |9 +
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers/infiniband/hw/mlx5/
If user requested signature enable we Initialize
relevant mlx5_ib_qp members. we mark the qp as sig_enable
we initiatlize empty sig_err_list, and we increase qp size.
Signed-off-by: Sagi Grimberg
---
drivers/infiniband/hw/mlx5/mlx5_ib.h |3 +++
drivers/infiniband/hw/mlx5/qp.c |5 +++
As a preliminary step for signature feature which will
reuqire posting multiple (3) WQEs for a single WR, we
break post_send routine WQE indexing into begin and
finish routines.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg
---
drivers/infiniband/hw/mlx5/qp.c | 95
This will be useful when processing signature errors
on a specific key. The mlx5 driver will lookup the
matching mlx5 memory region structure and mark it as
dirty (contains signature errors).
Signed-off-by: Sagi Grimberg
---
drivers/net/ethernet/mellanox/mlx5/core/main.c |1 +
drivers/net/et
This patchset Introduces Verbs level support for signature handover
feature. Siganture is intended to implement end-to-end data integrity
on a transactional basis in a completely offloaded manner.
There are several end-to-end data integrity methods used today in various
applications and/or upper l
Support create_mr and destroy_mr verbs.
Creating ib_mr may be done for either ib_mr that will
register regular page lists like alloc_fast_reg_mr routine,
or indirect ib_mr's that can register other (pre-registered)
ib_mr's in an indirect manner.
In addition user may request signature enable, that
On 10/31/2013 01:24 PM, Sagi Grimberg wrote:
> Support create_mr and destroy_mr verbs.
> Creating ib_mr may be done for either ib_mr that will
> register regular page lists like alloc_fast_reg_mr routine,
> or indirect ib_mr's that can register other (pre-registered)
> ib_mr's in an indirect manner
Hi Sagi,
I wander what's the performance overhead with this DIF support?
And is there a roadmap for support SRP/ISER and target side for DIF?
Regards,
Jack
On 10/31/2013 01:24 PM, Sagi Grimberg wrote:
> This patchset Introduces Verbs level support for signature handover
> feature. Siganture is
On 10/31/2013 2:52 PM, Jack Wang wrote:
On 10/31/2013 01:24 PM, Sagi Grimberg wrote:
Support create_mr and destroy_mr verbs.
Creating ib_mr may be done for either ib_mr that will
register regular page lists like alloc_fast_reg_mr routine,
or indirect ib_mr's that can register other (pre-register
On 10/31/2013 01:24 PM, Sagi Grimberg wrote:
> +{
> + struct ib_mr *sig_mr = wr->wr.sig_handover.sig_mr;
> + u32 sig_key = sig_mr->rkey;
> +
> + memset(seg, 0, sizeof(*seg));
> +
> + seg->status = 0x4; /*set free*/
> + seg->flags = get_umr_flags(wr->wr.sig_handover.access_flags)
On 10/31/2013 2:55 PM, Jack Wang wrote:
Hi Sagi,
I wander what's the performance overhead with this DIF support?
And is there a roadmap for support SRP/ISER and target side for DIF?
Regards,
Jack
Well, all DIF operations are fully offloaded by the HCA so we don't expect
any performance degrad
Hi Roland,
Here are some some fixes to mlx4 and mlx5 driver for the 3.13 merge window.
Thanks,
Eli
Eli Cohen (6):
IB/mlx5: Remove dead code
IB/core: Encorce MR access rights rules on kernel consumers
IB/mlx5: Fix list_del of empty list
IB/mlx4: Fix device max capabilities check
IB/mlx4
Enforce the rule that when requesting remote write or atomic permissions, local
write must be indicated as well. See IB spec 11.2.8.2.
Spotted by: Hagay Abramovsky
Signed-off-by: Eli Cohen
---
drivers/infiniband/core/uverbs_cmd.c | 10 +++---
drivers/infiniband/core/verbs.c | 14 +
The value of the local variable index is never used in reg_mr_callback().
Signed-off-by: Eli Cohen
---
drivers/infiniband/hw/mlx5/mr.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
index 2c4626f..2fa54d1 100644
--- a/dri
For archs with pages size of 4K, when the chunk is freed, fwp is not in the
list so avoid attempting to delete it.
Signed-off-by: Eli Cohen
---
drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/
When creating a CQ, we must use mlx5 adapter page shift.
Signed-off-by: Eli Cohen
---
drivers/infiniband/hw/mlx5/cq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/cq.c b/drivers/infiniband/hw/mlx5/cq.c
index 2834477..b726274 100644
--- a/drivers/
When calling get_sw_cqe() we need pass the consumer_index and not the masked
value. Failure to do so will cause incorrect result of get_sw_cqe() possibly
leading to endless loop.
This problem was reported and analyzed by Michael Rice from HP.
Issue: 346608
Signed-off-by: Eli Cohen
---
drivers/
Move the check on max supported CQEs after the final number of entries is
evaluated.
Signed-off-by: Eli Cohen
---
drivers/infiniband/hw/mlx4/cq.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
index d5e6
On 10/31/2013 02:20 PM, Sagi Grimberg wrote:
> On 10/31/2013 2:55 PM, Jack Wang wrote:
>> Hi Sagi,
>>
>> I wander what's the performance overhead with this DIF support?
>> And is there a roadmap for support SRP/ISER and target side for DIF?
>>
>> Regards,
>> Jack
>
> Well, all DIF operations are f
Fix the below "make W=1" build warning we have on the mlx4_ib
drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’:
drivers/infiniband/hw/mlx4/qp.c:2463: warning: comparison of unsigned
expression < 0 is always false
Signed-off-by: Or Gerlitz
---
drivers/infiniband/hw/mlx4/qp.c |
Hi Roland,
This little patch set removes the current "make W=1" build warnings from the IB
core
and the mlx4_ib driver, which would help when we examine new patches to make
sure they
don't add any warnings..
Or.
Or Gerlitz (2):
IB/core: Fix build warnings
IB/mlx4: Fix build warnings
driv
Fix the below few "make W=1" build warnings we have on the IB core.
drivers/infiniband/core/sysfs.c: In function ‘state_show’:
drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression
>= 0 is always true
drivers/infiniband/core/verbs.c: In function ‘ib_modify_qp_is_ok’:
dri
On 31/10/2013 9:21, Or Gerlitz wrote:
Fix the below few "make W=1" build warnings we have on the IB core.
drivers/infiniband/core/sysfs.c: In function ‘state_show’:
drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression
>= 0 is always true
drivers/infiniband/core/verbs.
> diff --git a/drivers/infiniband/core/iwcm.c
> b/drivers/infiniband/core/iwcm.c
> index c47c203..ab8ebf8 100644
> --- a/drivers/infiniband/core/iwcm.c
> +++ b/drivers/infiniband/core/iwcm.c
> @@ -327,7 +327,6 @@ static void destroy_cm_id(struct iw_cm_id *cm_id)
> {
> struct iwcm_id_private
On Thu, 2013-10-31 at 10:02 -0700, Bart Van Assche wrote:
> On 31/10/2013 9:21, Or Gerlitz wrote:
> > --- a/drivers/infiniband/core/sysfs.c
> > +++ b/drivers/infiniband/core/sysfs.c
> > @@ -104,7 +104,7 @@ static ssize_t state_show(struct ib_port *p, struct
> > port_attribute *unused,
> >
On Thu, Oct 31, 2013 at 7:59 PM, Hefty, Sean wrote:
> removing 'ret' is one thing, removing the call to destroy_listen() is another.
sure, I will fix and resubmit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More m
32 matches
Mail list logo
