[PATCH v1 04/13] IB/iser: Keep IB device attributes under iser_device

2014-02-27 Thread Sagi Grimberg
For T10-PI offload support, we will need to know the device signature offload capability upon every connection establishment. This patch does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iscsi_iser.h |1 + drivers/

[PATCH v1 02/13] IB/iser: Push the desicion what memory key to use into fast_reg_mr routine

2014-02-27 Thread Sagi Grimberg
This is a preparation step for T10-PI offload support. We prefer to push the desicion of which mkey to use (global or fastreg) to iser_fast_reg_mr. We choose to do this since it in T10-PI we may need to register for protection buffers and in this case we wish to simplify iser_fast_reg_mr instead of

[PATCH v1 06/13] IB/iser: Generalize iser_unmap_task_data and finalize_rdma_unaligned_sg

2014-02-27 Thread Sagi Grimberg
This routines operates on data buffers and may also work with protection infomation buffers. So we generalize them to handle an iser_data_buf which can be the command data or command protection information. This patch does not change any functionality. Signed-off-by: Sagi Grimberg --- drivers/i

[PATCH v1 12/13] IB/iser: Implement check_protection

2014-02-27 Thread Sagi Grimberg
Once the iSCSI transaction is completed we must imeplement check_protection in order to notify on DIF errors that may have occured. The routine boils down to calling ib_check_mr_status to get the signature status of the transaction. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik ---

[PATCH v1 03/13] IB/iser: Move fast_reg_descriptor initialization to a function

2014-02-27 Thread Sagi Grimberg
fastreg descriptor will include protection information context. In order to place the logic in one place we introduce iser_create_fr_desc function. This patch does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iser_verb

[PATCH v1 08/13] IB/iser: Introduce pi_enable, pi_guard module parameters

2014-02-27 Thread Sagi Grimberg
From: Alex Tabachnik Use modparams to activate protection information support. pi_enable bool: Based on this parameter iSER will know if it should support T10-PI. We don't want to do this by default as it requires to allocate and initiatlize extra resources. In case pi_enable=N, iSER won't publi

[PATCH v1 05/13] IB/iser: Replace fastreg descriptor valid bool with indicators container

2014-02-27 Thread Sagi Grimberg
In T10-PI support we will have memory keys for protection buffers and signature transactions. We prefer to compact indicators rather than keeping multiple bools. This commit does not change any functionality. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp

[PATCH v1 10/13] IB/iser: Support T10-PI operations

2014-02-27 Thread Sagi Grimberg
Add logic to initialize protection information entities. Upon each iSCSI task, we keep the scsi_cmnd in order to query the scsi protection operations and reference to protection buffers. Modify iser_fast_reg_mr to receive indication weather it is registering the data or protection buffers. In add

[PATCH v1 11/13] SCSI/libiscsi: Add check_protection callback for transports

2014-02-27 Thread Sagi Grimberg
iSCSI needs to be at least aware that a task involves protection information. In case it does, after the transaction completed libiscsi will ask the transport to check the protection status of the transaction. Unlike transport errors, DIF errors should not prevent successful completion of the tran

[PATCH v1 07/13] IB/iser: Generalize fall_to_bounce_buf routine

2014-02-27 Thread Sagi Grimberg
Unaligned SG-lists may also happen for protection information. Genrelize bounce buffer routine to handle any iser_data_buf which may be data and/or protection. This patch does not change any functionality. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iser_memory.c | 53 +++

[PATCH v1 00/13] T10-PI support for iSER initiator

2014-02-27 Thread Sagi Grimberg
Hey Roland, Nic and Co This patchset adds T10 protection information offload support over RDMA signature verbs API. This set, along with the iSER target set, allow end-to-end protection information passthrough and validation. The patchset was tested against Linux SCSI target with iSER DIF support

[PATCH v1 09/13] IB/iser: Initialize T10-PI resources

2014-02-27 Thread Sagi Grimberg
From: Alex Tabachnik During connection establishment we also initiatlize T10-PI resources (QP, PI contexts) in order to support SCSI's protection operations. Signed-off-by: Alex Tabachnik Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.h | 21 - drivers/infin

[PATCH v1 13/13] IB/iser: Publish T10-PI support to SCSI midlayer

2014-02-27 Thread Sagi Grimberg
After allocating a scsi_host we set protection types and guard type supported. Signed-off-by: Sagi Grimberg Signed-off-by: Alex Tabachnik --- drivers/infiniband/ulp/iser/iscsi_iser.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/drivers/infiniba

[PATCH v1 01/13] IB/iser: Avoid FRWR notation, use fastreg instead

2014-02-27 Thread Sagi Grimberg
FRWR stands for "fast registration work request". We want to avoid calling the fastreg pool with that name, instead we name it fastreg which stands for "fast registration". This pool will include more elements in the future, so it is a good idea to generalize the name. Signed-off-by: Sagi Grimber

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-02-27 Thread Sagi Grimberg
On 2/24/2014 5:24 PM, Bart Van Assche wrote: On 02/24/14 15:30, Sagi Grimberg wrote: When unmapping request data, it is unsafe automatically decrement req->nfmr regardless of it's value. This may happen since IO and reconnect flow may run concurrently resulting in req->nfmr = -1 and falsely call

Re: [PATCH v1 3/3] IB/srp: Protect free_tx iu list from concurrent flows

2014-02-27 Thread Sagi Grimberg
On 2/24/2014 5:38 PM, Bart Van Assche wrote: On 02/24/14 15:30, Sagi Grimberg wrote: From: Vu Pham srp_reconnect_rport() serializes calls of srp_rport_reconnect() with srp_queuecommand(), srp_abort(), srp_reset_device(), srp_reset_host() via rport->mutex and also blocks srp_queuecommand(); how

[PATCH opensm] osm_sw_info_rcv.c: Add check of switch mcast_cap

2014-02-27 Thread Hal Rosenstock
From: Ilya Nelkenbaum Signed-off-by: Ilya Nelkenbaum --- opensm/osm_sw_info_rcv.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/opensm/osm_sw_info_rcv.c b/opensm/osm_sw_info_rcv.c index 77c5be7..ce747a9 100644 --- a/opensm/osm_sw_info_rcv.c +++ b/opensm/osm_sw_info_

[PATCH] ibsim: allocate mft according to number of switch ports

2014-02-27 Thread Daniel Klein
From: Eli Dorfman calculate number of port masks according to number of switch ports and allocate MFT accordingly Signed-off-by: Eli Dorfman Signed-off-by: Alex Netes --- ibsim/sim.h |5 ++--- ibsim/sim_mad.c |5 +++-- ibsim/sim_net.c |5 +++-- 3 files changed, 8 insertions(+)

Re: [PATCH 3/6] IB/srp: Fail SCSI commands silently

2014-02-27 Thread Bart Van Assche
On 02/27/14 06:48, David Dillow wrote: > I don't see where the block level is printing messages about the failed > requests -- but maybe I'm missing it. I see scsi_done() -> > blk_complete_request() -> blk_done_softirq() -> scsi_softirq_done() -> > scsi_finish_command() -> scsi_io_completion() > >

Re: [PATCH v1 3/3] IB/srp: Protect free_tx iu list from concurrent flows

2014-02-27 Thread Bart Van Assche
On 02/27/14 12:51, Sagi Grimberg wrote: > Regarding in_scsi_eh, can you end-up still posting a send if you are in > an interrupt context? > it's just that we have a *very* rare case (not easy to reproduce) in > RH6.5 where we end-up posting on a just destroyed QP > (race right in between destroy_qp

RE: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

2014-02-27 Thread Steve Wise
> > > -static int allow_db_fc_on_t5; > > -module_param(allow_db_fc_on_t5, int, 0644); > > -MODULE_PARM_DESC(allow_db_fc_on_t5, > > -"Allow DB Flow Control on T5 (default = 0)"); > > - > > -static int allow_db_coalescing_on_t5; > > -module_param(allow_db_coalescing_on_t5, int, 0644); >

dapltest and listening endpoints.

2014-02-27 Thread Steve Wise
Hey Arlin, I'm trying to clean up the dapl/iwarp/cxgb4 issues, and I'm seeing something strange. Each time I run a transaction test, I see that listening endpoints are leaked or left around by the dapltest server. Q: after a completed test, should the dapltest server process have destroyed all of

Re: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

2014-02-27 Thread David Miller
From: "Steve Wise" Date: Thu, 27 Feb 2014 11:11:49 -0600 >> >> > -static int allow_db_fc_on_t5; >> > -module_param(allow_db_fc_on_t5, int, 0644); >> > -MODULE_PARM_DESC(allow_db_fc_on_t5, >> > - "Allow DB Flow Control on T5 (default = 0)"); >> > - >> > -static int allow_db_coalescing_o

RE: dapltest and listening endpoints.

2014-02-27 Thread Steve Wise
> -Original Message- > From: Steve Wise [mailto:sw...@opengridcomputing.com] > Sent: Thursday, February 27, 2014 11:36 AM > To: 'arlin.r.da...@intel.com' > Cc: 'linux-rdma@vger.kernel.org' > Subject: dapltest and listening endpoints. > > Hey Arlin, I'm trying to clean up the dapl/iwarp/cx

Re: [PATCH net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes.

2014-02-27 Thread Stephen Hemminger
On Thu, 27 Feb 2014 13:05:44 -0500 (EST) David Miller wrote: > From: "Steve Wise" > Date: Thu, 27 Feb 2014 11:11:49 -0600 > > >> > >> > -static int allow_db_fc_on_t5; > >> > -module_param(allow_db_fc_on_t5, int, 0644); > >> > -MODULE_PARM_DESC(allow_db_fc_on_t5, > >> > - "Allow

Query regarding HCR mellanox mlx4

2014-02-27 Thread Bob Biloxi
I was looking to understand the mlx4 driver for the Mellanox adapter. I just had a query which I was not able to resolve on my own. Can anyone please help me understand that: does the HCR(HCA Configuration Register) reside in the Config Space or MMIO space? I guess the kernel uses ioremap for a