In case of error while accessing to userspace memory,
function nes_create_qp() returns NULL instead of an error
code wrapped through ERR_PTR().
But NULL is not expected by ib_uverbs_create_qp(), as it
check for error with IS_ERR().
As page 0 is likely not mapped, it is going to trigger an
Oops wh
Commit c804f07248895ff9c moved qib_assign_ctxt() to
do_qib_user_sdma_queue_create() but dropped the braces
around the statements.
This was spotted by coccicheck (coccinelle/spatch):
$ make C=2 CHECK=scripts/coccicheck drivers/infiniband/hw/qib/
CHECK drivers/infiniband/hw/qib/qib_file_ops.c
Hi all,
Please find small but important fixes on InfiniBand/iWARP RDMA drivers for
problems found while using coccinelle (spatch) or coccicheck.
I'm trying to patch callers of ib_copy_{from,to}_udata() to use the error
code returned by functions using a semantic patch to be applied with
coccinell
In case of error when writing to userspace, function
ehca_create_cq() do not set an error code before
following its error path.
This patch set error code to -EFAULT when ib_copy_to_udata()
fail.
This was caught when using spatch (aka. coccinelle)
to rewrite call to ib_copy_{from,to}_udata().
Lin
On Thu, 2014-03-06 at 16:05 +0200, sagi grimberg wrote:
> On 3/6/2014 12:04 AM, Nicholas A. Bellinger wrote:
> > On Wed, 2014-03-05 at 14:12 +0200, Sagi Grimberg wrote:
> >> On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote:
> >>> On Tue, 2014-03-04 at 17:17 +0200, Sagi Grimberg wrote:
> On 3/4
On Mon, 2014-03-10 at 23:43 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 03/10/2014 08:08 PM, Hariprasad Shenai wrote:
> > From: Steve Wise
> > We cannot save the mapped length using the rdma max_page_list_len field
> > of the ib_fast_reg_page_list struct because the core code uses it. This
> >
Hello.
On 03/10/2014 08:08 PM, Hariprasad Shenai wrote:
From: Steve Wise
We cannot save the mapped length using the rdma max_page_list_len field
of the ib_fast_reg_page_list struct because the core code uses it. This
results in an incorrect unmap of the page list in c4iw_free_fastreg_pbl()
From: Kleber Sacilotto de Souza
Date: Fri, 7 Mar 2014 19:48:25 -0300
> The call to mlx5_health_cleanup() in the module init function can never
> be reached. Removing it.
>
> Signed-off-by: Kleber Sacilotto de Souza
Applied to net-next, thank you.
--
To unsubscribe from this list: send the lin
On Wed, Mar 5, 2014 at 7:43 PM, Sagi Grimberg wrote:
> Hey Roland, Nic, Mike and Co
>
> This patchset adds T10 protection information offload support over
> RDMA signature verbs API. This set, along with the iSER target set,
> allow end-to-end protection information passthrough and validation.
> T
>
> >Dropped patch "cxgb4: use spinlock_irqsave/spinlock_irqrestore
for db
> lock".
> >save/restore spinlock variants are not required - thanks to
review by
> >David Miller.
>
> That is absolutely not what I said.
>
> I said that specific instances of the transformation were not corr
From: Hariprasad Shenai
Date: Mon, 10 Mar 2014 22:38:05 +0530
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c
> b/drivers/infiniband/hw/cxgb4/cm.c
> index 360807e..74a2250 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -3350,10 +3350,9 @@ static int
From: Hariprasad Shenai
Date: Mon, 10 Mar 2014 22:37:57 +0530
>Dropped patch "cxgb4: use spinlock_irqsave/spinlock_irqrestore for db
> lock".
>save/restore spinlock variants are not required - thanks to review by
>David Miller.
That is absolutely not what I said.
I said that specif
From: Kumar Sanghvi
Based on original work by Casey Leedom
Signed-off-by: Kumar Sanghvi
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 +
drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 106 +++
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 3 +
3 files chang
From: Steve Wise
40G devices need a bigger windows, so default 40G devices to snd 512K
rcv 1024K.
Fixed a bug that shows up with recv window sizes that exceed the size of
the RCV_BUFSIZ field in opt0 (>= 1024K :). If the recv window exceeds
this, then we specify the max possible in opt0, add ad
From: Steve Wise
Need to do an sfence after both the WC and regular PIDX DB write.
Otherwise the host might reorder things and cause work request corruption
(seen with NFSRDMA).
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/t4.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletion
From: Kumar Sanghvi
We'd come in with SGE_FL_BUFFER_SIZE[0] and [1] both equal to 64KB and the
extant logic would flag that as an error.
Based on original work by Casey Leedom
Signed-off-by: Kumar Sanghvi
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 12 ++--
1 file changed, 10 inse
Hi All,
This patch series provides miscelleneous fixes for Chelsio T4/T5 adapters
related to cxgb4 related to sge and mtu. And includes DB Drop avoidance
and other misc. fixes on iw-cxgb4.
The patches series is created against David Miller's 'net-next' tree.
And includes patches on cxgb4 and iw_c
From: Steve Wise
1) timedout endpoint processing can be starved. If there is continual
CPL messages flowing into the driver, the endpoint timeout processing
can be starved. This condition exposed the other bugs below.
Solution: In process_work(), call process_timedout_eps() after each CPL
is pr
From: Steve Wise
The current logic suffers from a slow response time to disable user DB
usage, and also fails to avoid DB FIFO drops under heavy load. This commit
fixes these deficiencies and makes the avoidance logic more optimal.
This is done by more efficiently notifying the ULDs of potential
From: Steve Wise
find_route() must treat loopback as a valid
egress interface.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index d286bde.
From: Steve Wise
If cxgb4_ofld_send() returns < 0, then send_fw_pass_open_req() must
free the request skb and the saved skb with the tcp header.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/in
From: Kumar Sanghvi
Commit 0034b29 ("cxgb4: Don't assume LSO only uses SGL path in t4_eth_xmit()")
introduced a regression where-in length was calculated wrongly for LSO path,
causing chip hangs.
So, correct the calculation of len.
Fixes: 0034b29 ("cxgb4: Don't assume LSO only uses SGL path in t
From: Steve Wise
There is a race between ULP threads doing an accept/reject, and the
ingress processing thread handling close/abort for the same connection.
The accept/reject path needs to hold the lock to serialize these paths.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c |
Signed-off-by: Hariprasad Shenai
---
drivers/infiniband/hw/cxgb4/resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/resource.c
b/drivers/infiniband/hw/cxgb4/resource.c
index d9bc9ba..67df71a 100644
--- a/drivers/infiniband/hw/cxgb4/reso
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/device.c | 41 +-
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 2 ++
drivers/infiniband/hw/cxgb4/qp.c | 59 +---
drivers/infiniband/hw/cxgb4/t4.h | 62 ++
From: Steve Wise
Based on original work by Anand Priyadarshee .
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c| 24
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 +
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/
From: Kumar Sanghvi
Based on original work by Casey Leedom
Signed-off-by: Kumar Sanghvi
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 9 ++-
drivers/net/ethernet/chelsio/cxgb4/sge.c | 90 --
2 files changed, 79 insertions(+), 20 deletions(-)
diff --git a/dri
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index 88de3aa..c0673ac 100644
--- a/drivers/infiniband/hw/cxgb4/cq.c
+++ b/driv
From: Steve Wise
Always release the neigh entry in rx_pkt().
Based on original work by Santosh Rastapur .
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniba
From: Steve Wise
Added some missing debug stats.
Use uninitialized_var().
Initialize reserved fields in a FW work request.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cq.c | 2 +-
drivers/infiniband/hw/cxgb4/mem.c | 6 +-
drivers/infiniband/hw/cxgb4/qp.c |
From: Steve Wise
There is a race when moving a QP from RTS->CLOSING where a SQ work
request could be posted after the FW receives the RDMA_RI/FINI WR.
The SQ work request will never get processed, and should be completed
with FLUSHED status. Function c4iw_flush_sq(), however was dropping
the old
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 1 +
drivers/infiniband/hw/cxgb4/qp.c | 6 --
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
index c
From: Steve Wise
When processing an MPA Start Request, if the listening
endpoint is DEAD, then abort the connection.
If the IWCM returns an error, then we must abort the connection and
release resources. Also abort_connection() should not post a CLOSE
event, so clean that up too.
Signed-off-by
From: Steve Wise
To avoid racing with other threads doing close/flush/whatever, rx_data()
should hold the endpoint mutex.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/cx
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index c63dfe5..899be48 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/
From: Steve Wise
Some HW platforms can reorder read operations, so we must rmb() after
we see a valid gen bit in a CQE but before we read any other fields
from the CQE.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/t4.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/in
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/device.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/device.c
b/drivers/infiniband/hw/cxgb4/device.c
index 9ba3012..73d6226 100644
--- a/drivers/infiniband/hw/cx
From: Kumar Sanghvi
Based on original work by Casey Leedom
Signed-off-by: Kumar Sanghvi
---
drivers/net/ethernet/chelsio/cxgb4/sge.c | 18 +-
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 6 ++
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/n
From: Steve Wise
Based on original work from Jay Hernandez
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index c0673ac..59f7601 100644
-
From: Steve Wise
The max depth of a fastreg mr depends on whether the device supports DSGL or
not. So
compute it dynamically based on the device support and the module use_dsgl
option.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/provider.c | 2 +-
drivers/infiniband/hw/cxgb4/
From: Steve Wise
We cannot save the mapped length using the rdma max_page_list_len field
of the ib_fast_reg_page_list struct because the core code uses it. This
results in an incorrect unmap of the page list in c4iw_free_fastreg_pbl().
I found this with dma map debugging enabled in the kernel.
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f6891b8..95b3c01 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniban
From: Steve Wise
These are generated by HW in some error cases and need to be
silently discarded.
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cq.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/driv
From: Steve Wise
Signed-off-by: Steve Wise
---
drivers/infiniband/hw/cxgb4/cm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f4a9ebe..e7c6dfd 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband
On Mon, Mar 10, 2014 at 04:02:13PM +0100, Yann Droneaud wrote:
> Hi,
>
> Le lundi 10 mars 2014 à 15:26 +0100, Bart Van Assche a écrit :
> > On 03/10/14 14:33, Yann Droneaud wrote:
> > > Le lundi 10 mars 2014 à 13:22 +0100, Bart Van Assche a écrit :
> > >> Suppress the following sparse warning:
> >
From: Daniel Klein
Date: Thu, 6 Mar 2014 16:33:21 +0200
Update local copy of node info when it receives node info for existing
node.
Signed-off-by: Daniel Klein
Signed-off-by: Hal Rosenstock
---
opensm/osm_node_info_rcv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Alex Netes
Date: Tue, 7 Aug 2012 10:58:16 +0300
Signed-off-by: Alex Netes
Signed-off-by: Hal Rosenstock
---
opensm/osm_node_info_rcv.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/opensm/osm_node_info_rcv.c b/opensm/osm_node_info_rcv.c
index 499d9cb..622
From: Eli Dorfman
Date: Wed, 24 Nov 2010 11:18:44 +0200
Clear first time sweep even after subnet initialization error.
Wait sweep interval between heavy sweeps after subnet init error.
Signed-off-by: Eli Dorfman
Signed-off-by: Alex Netes
Signed-off-by: Hal Rosenstock
---
opensm/osm_state_mgr
Hi,
Le lundi 10 mars 2014 à 15:26 +0100, Bart Van Assche a écrit :
> On 03/10/14 14:33, Yann Droneaud wrote:
> > Le lundi 10 mars 2014 à 13:22 +0100, Bart Van Assche a écrit :
> >> Suppress the following sparse warning:
> >> include/rdma/ib_addr.h:187:24: warning: cast removes address space of
>
On 03/10/14 14:33, Yann Droneaud wrote:
> Le lundi 10 mars 2014 à 13:22 +0100, Bart Van Assche a écrit :
>> Suppress the following sparse warning:
>> include/rdma/ib_addr.h:187:24: warning: cast removes address space of
>> expression
>
> You should explain why there's a warning here, and why is i
Le lundi 10 mars 2014 à 13:22 +0100, Bart Van Assche a écrit :
> Suppress the following sparse warning:
>
> include/rdma/ib_addr.h:187:24: warning: cast removes address space of
> expression
>
You should explain why there's a warning here, and why is it safe to
cast. (I believe it's related to
Suppress the following sparse warning:
include/rdma/ib_addr.h:187:24: warning: cast removes address space of expression
Signed-off-by: Bart Van Assche
Cc: Moni Shoua
Cc: Or Gerlitz
Cc: Roland Dreier
---
include/rdma/ib_addr.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Avoid that srp_unmap_data() can get invoked concurrently by
srp_terminate_io() and from the error path in srp_queuecommand()
if srp_post_send() fails.
Signed-off-by: Bart Van Assche
Cc: Sagi Grimberg
Cc: Sebastian Riemer
Cc: Roland Dreier
---
drivers/infiniband/ulp/srp/ib_srp.c | 46 +
If a cable is pulled while srp_connect_target() is in progress
that can result in that function never to return. That makes the
process, e.g. srp_daemon, that invoked this function unkillable.
Avoid this by letting srp_connect_target() finish if the event
IB_CM_TIMEWAIT_EXIT is received. This patch
Avoid that stopping srp_daemon takes unusually long due to a cable
pull by making writing into the "add_target" sysfs attribute
interruptible.
Signed-off-by: Bart Van Assche
Cc: Sagi Grimberg
Cc: Sebastian Riemer
Cc: Roland Dreier
---
drivers/infiniband/ulp/srp/ib_srp.c | 10 --
1 fil
The connection uniqueness check is performed before a new connection
is added to the target list. This patch protects both actions by a
mutex such that simultaneous writes from two different threads into the
"add_target" variable do not result in duplicate connections.
Signed-off-by: Bart Van Assc
Log sgid and dgid when reporting that a login has been rejected or when
a host has been added. This makes it easy to figure out which initiator
and target ports these messages apply to.
Signed-off-by: Bart Van Assche
Cc: Sagi Grimberg
Cc: Sebastian Riemer
Cc: Roland Dreier
---
drivers/infinib
From: Sagi Grimberg
Detected by Coverity.
Signed-off-by: Sagi Grimberg
Signed-off-by: Bart Van Assche
---
drivers/infiniband/ulp/srp/ib_srp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/drivers/infiniband/ulp/srp/ib_srp.c
index
This patch fixes the following two kernel-doc warnings:
Warning(drivers/scsi/scsi_transport_srp.c:819): No description found for
parameter 'rport'
Warning(include/scsi/scsi_transport_srp.h:75): Excess struct/union/enum/typedef
member 'deleted' description in 'srp_rport'
Signed-off-by: Bart Van
Hello Roland,
Please consider this patch series for kernel 3.15.
Changes compared to v1:
- Added a patch from Sagi Grimberg ("Check ib_query_gid() return
value").
- Left out a patch to give Dave Dillow a chance to rework it as a SCSI
core patch ("IB/srp: Fail SCSI commands silently").
These
Avoid that sparse reports the following warning for the mlx4 driver:
$ make M=drivers/infiniband C=2 CF=-D__CHECK_ENDIAN__
drivers/infiniband/hw/mlx4/qp.c:1885:31: warning: restricted __be16 degrades to
integer
Signed-off-by: Bart Van Assche
Cc: Moni Shoua
Cc: Or Gerlitz
Cc: Roland Dreier
--
Thanks Roland,
My response is inline below.
-Regards
Devesh
-Original Message-
From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of
Roland Dreier
Sent: Saturday, March 08, 2014 1:02 AM
To: Devesh Sharma
Cc: Nicholas A. Bellinger; Or Gerlitz; Hefty Sean; linux-rdma; M
62 matches
Mail list logo
