[PATCH for v3.14 2/5] IB/mthca: returns an error on ib_copy_to_udata() failure

2014-03-11 Thread Yann Droneaud
In case of error when writing to userspace, function mthca_create_cq() do not set an error code before following its error path. This patch set error code to -EFAULT when ib_copy_to_udata() fail. This was caught when using spatch (aka. coccinelle) to rewrite call to ib_copy_{from,to}_udata().

[PATCH for v3.14 5/5] IB/qib: fixup indentation in qib_ib_rcv()

2014-03-11 Thread Yann Droneaud
Commit af061a644a0e4d4778 add some code in qib_ib_rcv() which trigger a warning from coccicheck (coccinelle/spatch): $ make C=2 CHECK=scripts/coccicheck drivers/infiniband/hw/qib/ CHECK drivers/infiniband/hw/qib/qib_verbs.c drivers/infiniband/hw/qib/qib_verbs.c:679:5-32: code aligned with

Re: [PATCH 0/6] iser-target: Fix active I/O shutdown related issues

2014-03-11 Thread Sagi Grimberg
On 3/11/2014 12:00 AM, Nicholas A. Bellinger wrote: On Thu, 2014-03-06 at 16:05 +0200, sagi grimberg wrote: On 3/6/2014 12:04 AM, Nicholas A. Bellinger wrote: On Wed, 2014-03-05 at 14:12 +0200, Sagi Grimberg wrote: On 3/5/2014 2:06 AM, Nicholas A. Bellinger wrote: On Tue, 2014-03-04 at 17:17

[PATCH for-next] IB/mad: Check and handle potential DMA mapping errors

2014-03-11 Thread Or Gerlitz
From: Yan Burman y...@mellanox.com Running over a kernel built with DMA_API_DEBUG and not checking for DMA mapping error triggers a kernel stack trace with DMA-API: device driver failed to check map error message. So adding it here, for the sake of being more robust and eliminating the

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Sagi Grimberg
On 3/7/2014 10:13 AM, Bart Van Assche wrote: On 03/06/14 17:10, Sagi Grimberg wrote: So I took Roland latest 3.14-rc1 and tried to reproduce this issue using HCA with no FMRs support and was *NOT* able to reproduce this issue. This issue reproduced for me on RH6 backported srp and I can't tell

RE: [PATCH for v3.14 4/5] IB/qib: add missing braces in do_qib_user_sdma_queue_create()

2014-03-11 Thread Marciniszyn, Mike
Subject: [PATCH for v3.14 4/5] IB/qib: add missing braces in do_qib_user_sdma_queue_create() Signed-off-by: Yann Droneaud ydrone...@opteya.com Thanks for the patch! Tested-by: Mike Marciniszyn mike.marcinis...@intel.com Acked-by: Mike Marciniszyn mike.marcinis...@intel.com -- To unsubscribe

RE: [PATCH for v3.14 5/5] IB/qib: fixup indentation in qib_ib_rcv()

2014-03-11 Thread Marciniszyn, Mike
Subject: [PATCH for v3.14 5/5] IB/qib: fixup indentation in qib_ib_rcv() Signed-off-by: Yann Droneaud ydrone...@opteya.com Thanks for the patch! Tested-by: Mike Marciniszyn mike.marcinis...@intel.com Acked-by: Mike Marciniszyn mike.marcinis...@intel.com -- To unsubscribe from this list:

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Bart Van Assche
On 03/11/14 14:38, Sagi Grimberg wrote: And before the SCSI host lock push-down the SCSI host lock was held around the srp_queuecommand() invocation. In other words, holding a spin lock around the srp_post_send() call in srp_queuecommand() is neither new nor disallowed by the RDMA API

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Sagi Grimberg
On 3/11/2014 3:51 PM, Bart Van Assche wrote: On 03/11/14 14:38, Sagi Grimberg wrote: And before the SCSI host lock push-down the SCSI host lock was held around the srp_queuecommand() invocation. In other words, holding a spin lock around the srp_post_send() call in srp_queuecommand() is neither

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Bart Van Assche
On 03/11/14 15:07, Sagi Grimberg wrote: On 3/11/2014 3:51 PM, Bart Van Assche wrote: On 03/11/14 14:38, Sagi Grimberg wrote: I see... will assigning scmnd = NULL only if srp_post_send will fail, and restore the assignment as before help? Sorry but I'm not enthusiast about that approach

Re: [PATCH for-next] IB/iser: Suppress completion for fast registration work requests

2014-03-11 Thread Or Gerlitz
On 23/01/2014 12:31, Or Gerlitz wrote: From: Sagi Grimberg sa...@mellanox.com In case iSER uses fast registration method, it should not request for successful completions on fast registration nor local invalidate. We color wr_id with ISER_FRWR_LI_WRID in order to correctly consume error

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Bart Van Assche
On 03/11/14 15:48, Sagi Grimberg wrote: But I think this lock can be taken conditionally. I mean in the sunny-day scenario we don't expect srp_terminate_io to race with srp_post_send. That can happen only when rport state transitions to FAIL_FAST right? and also in some strange case when the

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Sagi Grimberg
On 3/11/2014 4:29 PM, Bart Van Assche wrote: On 03/11/14 15:07, Sagi Grimberg wrote: On 3/11/2014 3:51 PM, Bart Van Assche wrote: On 03/11/14 14:38, Sagi Grimberg wrote: I see... will assigning scmnd = NULL only if srp_post_send will fail, and restore the assignment as before help? Sorry but

Re: [PATCH v1 1/3] IB/srp: Fix crash when unmapping data loop

2014-03-11 Thread Sagi Grimberg
On 3/11/2014 5:00 PM, Bart Van Assche wrote: On 03/11/14 15:48, Sagi Grimberg wrote: But I think this lock can be taken conditionally. I mean in the sunny-day scenario we don't expect srp_terminate_io to race with srp_post_send. That can happen only when rport state transitions to FAIL_FAST

[ANNOUNCE] libcxgb4-1.3.3 released

2014-03-11 Thread Steve Wise
The libcxgb4 package contains a userspace driver for Chelsio T4 and T5 iWARP RNICs. It is a plug-in module for libibverbs that allows programs to use Chelsio hardware directly from userspace. A new release is available from: http://www.openfabrics.org/downloads/cxgb4/libcxgb4-1.3.3.tar.gz

[PATCH 1/2] RDMA/nes: Fixes for the MPA V2 implementation

2014-03-11 Thread Tatyana Nikolova
Fixes to enable the negotiation of the supported ird/ord sizes with the peer when exchanging MPA V2 messages in connection establishment Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c | 119 +++-

[PATCH 2/2] RDMA/nes: Fix for passing a valid QP pointer to the user space library

2014-03-11 Thread Tatyana Nikolova
Fix for passing a valid QP pointer to the user space library Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c|2 +- drivers/infiniband/hw/nes/nes_user.h |5 +++-- drivers/infiniband/hw/nes/nes_verbs.c |2 ++

[Patch 0/2] IB/mlx5: Add PCI error handler support for mlx5

2014-03-11 Thread clsoto
The following series add PCI error handler support for mlx5 driver and improvements in the mlx5 remove_one function to make sure that it can execute all the functions to tear down the resources. IB/mlx5: Implementation of PCI error handler IB/mlx5: Free resources during PCI error

[Patch 1/2] IB/mlx5: Implementation of PCI error handler

2014-03-11 Thread clsoto
This patch is to add PCI error handler function support for mlx5. Created the functions for error_detected and slot_rest, plus will send a port down event to users when the driver error_detected function is invoked. This is to prevent a hang seeing in mcast_remove_one at the time

[Patch 2/2] IB/mlx5: Free resources during PCI error

2014-03-11 Thread clsoto
This patch is to make sure that during a pci error, the remove_one function frees the resources even though the hardware command failed to avoid memory leaks when the adapter recovers. Also make sure that remove_one function goes thru all the functions like disable all irqs and disable pci so