[PATCH 4/8] iw_cxgb4: Max fastreg depth depends on DSGL support

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise The max depth of a fastreg mr depends on whether the device supports DSGL or not. So compute it dynamically based on the device support and the module use_dsgl option. Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/provider.c | 2 +- drivers/infiniband/hw/cxgb4/qp.

[PATCH 2/8] iw_cxgb4: rmb() after reading valid gen bit

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise Some HW platforms can reorder read operations, so we must rmb() after we see a valid gen bit in a CQE but before we read any other fields from the CQE. Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/t4.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/

[PATCH 1/8] iw_cxgb4: endpoint timeout fixes

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise 1) timedout endpoint processing can be starved. If there is continual CPL messages flowing into the driver, the endpoint timeout processing can be starved. This condition exposed the other bugs below. Solution: In process_work(), call process_timedout_eps() after each CPL is pr

[PATCH 6/8] iw_cxgb4: Initialize reserved fields in a FW work request

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/qp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 0af82af..e865fa4 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband

[PATCH 0/8] Endpoint timeout fix, SQ flush and other misc. fixes for iw_cxgb4

2014-03-26 Thread Hariprasad Shenai
Hi All, This patch series provides fixes related to endpoint timeout, one fix related to SQ flushing and other miscelleneous fixes for Chelsio T4/T5 adapters on iw_cxgb4. The patches series is created against 'infiniband' tree, 'for-next' branch. And includes patches on iw_cxgb4 driver. These

[PATCH 5/8] iw_cxgb4: Use pr_warn_ratelimited

2014-03-26 Thread Hariprasad Shenai
Signed-off-by: Hariprasad Shenai --- drivers/infiniband/hw/cxgb4/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/resource.c b/drivers/infiniband/hw/cxgb4/resource.c index cdef4d7..94b5fd9 100644 --- a/drivers/infiniband/hw/cxgb4/reso

[PATCH 8/8] iw_cxgb4: Use uninitialized_var()

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/cq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c index e17b155..cfaa56a 100644 --- a/drivers/infiniband/hw/cxgb4/cq.c +++ b/driv

[PATCH 3/8] iw_cxgb4: SQ flush fix

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise There is a race when moving a QP from RTS->CLOSING where a SQ work request could be posted after the FW receives the RDMA_RI/FINI WR. The SQ work request will never get processed, and should be completed with FLUSHED status. Function c4iw_flush_sq(), however was dropping the old

[PATCH 7/8] iw_cxgb4: Add missing debug stats

2014-03-26 Thread Hariprasad Shenai
From: Steve Wise Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/mem.c | 6 +- drivers/infiniband/hw/cxgb4/resource.c | 6 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c index a5db3

Re: [PATCH 8/8] iw_cxgb4: Use uninitialized_var()

2014-03-26 Thread Yann Droneaud
Le mercredi 26 mars 2014 à 18:53 +0530, Hariprasad Shenai a écrit : > From: Steve Wise > What for ? Please describe the reason to use uninitialized_var() > Signed-off-by: Steve Wise > --- > drivers/infiniband/hw/cxgb4/cq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

RE: [PATCH 8/8] iw_cxgb4: Use uninitialized_var()

2014-03-26 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On > Behalf Of Yann Droneaud > Sent: Wednesday, March 26, 2014 9:34 AM > To: Hariprasad Shenai > Cc: linux-rdma@vger.kernel.org; rol...@purestorage.com; > sw...@opengridcomputing.co

[PATCH] RDMA/cxgb4: set error code on kmalloc() failure

2014-03-26 Thread Yann Droneaud
If kmalloc() fails in c4iw_alloc_ucontext(), the function leaves but does not set an error code in ret variable: it will return 0 to the caller. This patch set ret to -ENOMEM in such case. Cc: Steve Wise Cc: Steve Wise Signed-off-by: Yann Droneaud --- drivers/infiniband/hw/cxgb4/provider.c |

FW: [PATCH] RDMA/cxgb4: set error code on kmalloc() failure

2014-03-26 Thread Steve Wise
Acked-by: Steve Wise Note: This fix applies only to net-next because the commit that introduced this is still pending in net-next: commit 05eb23893c2cf9502a9cec0c32e7f1d1ed2895c8 Author: Steve Wise Date: Fri Mar 14 21:52:08 2014 +0530 cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes

Re: [PATCH net-next 2/2] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes

2014-03-26 Thread Yann Droneaud
Le vendredi 14 mars 2014 à 21:52 +0530, Hariprasad Shenai a écrit : > From: Steve Wise [...] > Signed-off-by: Steve Wise > --- > drivers/infiniband/hw/cxgb4/device.c| 177 > ++-- > drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 9 +- > drivers/infiniband/h

RE: [PATCH net-next 2/2] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes

2014-03-26 Thread Steve Wise
> > + uresp.status_page_size = PAGE_SIZE; > > + > > + spin_lock(&context->mmap_lock); > > + uresp.status_page_key = context->key; > > + context->key += PAGE_SIZE; > > + spin_unlock(&context->mmap_lock); > > + > > Is it really necessary to spinloc

[PATCH for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-26 Thread Or Gerlitz
From: Moni Shoua The code that resolves the passive side source mac within the rdma_cm connection request handler was both redundant and buggy, remove it. It was redundant since later, when an RC QP is modified to RTR state the resolution will take place in the ib_core module. It was buggy b/c

Re: [PATCH for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-26 Thread Yann Droneaud
Hi, Le mercredi 26 mars 2014 à 18:23 +0200, Or Gerlitz a écrit : > From: Moni Shoua > > The code that resolves the passive side source mac within the rdma_cm > connection request handler was both redundant and buggy, remove it. > > It was redundant since later, when an RC QP is modified to RTR

Re: Kernel oops/panic with NFS over RDMA mount after disrupted Infiniband connection

2014-03-26 Thread Chuck Lever
On Mar 26, 2014, at 6:20 AM, rafael.reiter wrote: > Hello, > > I am looking into a problem with NFS/RDMA with openSuse 12.3 and the 3.10.17 > kernel. The following kernel oops, followed by a kernel panic, occurs on > the client computer after 5-30 seconds when the connection between NFS server

Re: [PATCH for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-26 Thread Or Gerlitz
On Wed, Mar 26, 2014 at 6:23 PM, Or Gerlitz wrote: > --- > Hi Roland, we're post 3.14-rc8 and hence I assume will go to 3.15-rc1 > and once there we will post it to -stable to it gets into 3.14.y So we have here some warnings on unused variables, I forgot to amend that, sorry, will send V1 for

Re: [PATCH for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-26 Thread Or Gerlitz
On Wed, Mar 26, 2014 at 7:10 PM, Yann Droneaud wrote: > Is that a revert of some patch ? Its not a full revents, but I will pick what you are probably suggesting and mention in the V1 change-log which commit this fixes, thanks > Just add Cc: sta...@vger.kernel.org I know that but preferns to

[PATCH opensm 1/2] All SA queries should validate the requester port under lock

2014-03-26 Thread Hal Rosenstock
It might collide with the sweep operations. Signed-off-by: Alex Netes Signed-off-by: Hal Rosenstock --- opensm/osm_sa_guidinfo_record.c | 69 +++-- opensm/osm_sa_informinfo.c |9 +++-- opensm/osm_sa_lft_record.c |5 ++- opensm/osm_sa_link_

[PATCH opensm 2/2] osm_sa_service_record.c: Improve locking

2014-03-26 Thread Hal Rosenstock
From: Alex Netes Date: Tue, 25 Mar 2014 12:01:56 +0200 Read lock should be sufficient when treating GET method. Signed-off-by: Alex Netes Signed-off-by: Hal Rosenstock --- opensm/osm_sa_service_record.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/opensm/osm_sa_se

[PATCH V1 for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-26 Thread Or Gerlitz
From: Moni Shoua The code that resolves the passive side source mac within the rdma_cm connection request handler was both redundant and buggy, remove it. It was redundant since later, when an RC QP is modified to RTR state the resolution will take place in the ib_core module. It was buggy b/c

[PATCH 3/3] RDMA/cxgb4: Add support for iWARP Port Mapper user space service (Version 2)

2014-03-26 Thread Tatyana Nikolova
From: Steve Wise Add support for iWarp Port Mapper (Version 2) Based on original work by Vipul Pandya. Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/cm.c | 180 ++-- drivers/infiniband/hw/cxgb4/device.c | 81 -- drivers/infiniba

[PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-03-26 Thread Tatyana Nikolova
Hello All, This patch series adds iWARP Port Mapper (IWPM) Version 2 support in RDMA/core, RDMA/nes driver and RDMA/cxgb4 driver. The iWARP Port Mapper implementation is based on the port mapper specification section in the Sockets Direct Protocol paper - http://www.rdmaconsortium.org/home/draft-

[PATCH 2/3] RDMA/nes: Add support for iWARP Port Mapper user space service (Version 2)

2014-03-26 Thread Tatyana Nikolova
Add support for iWarp Port Mapper (Version 2) Signed-off-by: Tatyana Nikolova --- drivers/infiniband/hw/nes/nes.c| 25 +++- drivers/infiniband/hw/nes/nes.h|3 + drivers/infiniband/hw/nes/nes_cm.c | 320 +--- drivers/infiniband/hw/nes/nes_cm.h | 1