Re: [PATCH 11/16] ibacm: Add thread to monitor IP address changes

2014-03-27 Thread Bart Van Assche
On 03/28/14 06:50, sean.he...@intel.com wrote: > + while ((len = recv(sock, buffer, NL_MSG_BUF_SIZE, 0)) > 0) { > + nlh = (struct nlmsghdr *)buffer; > + while ((NLMSG_OK(nlh, len)) && (nlh->nlmsg_type != NLMSG_DONE)) > { > + struct ifaddrmsg *ifa = (

[PATCH 15/16] ibacm: remove acm_if_iter_sys function

2014-03-27 Thread sean . hefty
From: Ira Weiny The use of this function and the callback mechanism it used is now unnecessary since ib_acme does not scan for IP's Signed-off-by: Ira Weiny --- src/acm.c | 102 +++- src/acm_util.c | 84 ---

[PATCH 13/16] ibacm: fix handling of aliased IPoIB devices

2014-03-27 Thread sean . hefty
From: Ira Weiny ibX:Y devices don't have sysfs files directly. They use the "base" interface of ibX. The ioctl calls however include the full aliased name. Netlink does not have this problem as the interface name is reported as it appears in sysfs. Signed-off-by: Ira Weiny --- src/acm_util.

[PATCH 06/16] ibacm: move acm_if_iter_sys to acm_util.c

2014-03-27 Thread sean . hefty
From: Ira Weiny Signed-off-by: Ira Weiny --- linux/acme_linux.c | 80 --- src/acm_util.c | 81 2 files changed, 81 insertions(+), 80 deletions(-) diff --git a/linux/acme_linux.c b/linux

[PATCH 08/16] ibacm: add separate acm_ep_insert_addr function

2014-03-27 Thread sean . hefty
From: Ira Weiny This is in preparation for netlink support which will do this dynamically. Signed-off-by: Ira Weiny --- src/acm.c | 73 1 files changed, 58 insertions(+), 15 deletions(-) diff --git a/src/acm.c b/src/acm.c index 5d

[PATCH 09/16] ibacm: read system IP's into endpoints at startup

2014-03-27 Thread sean . hefty
From: Ira Weiny ibacm_addr.cfg is read after system is read which can add endpoints which are not active at start up. ibacm_addr.cfg can still specify names for end points Signed-off-by: Ira Weiny --- Makefile.am|2 +- src/acm.c | 66

[PATCH 14/16] ibacm: ib_acme remove IP addresses from ibacm_addr.cfg file generation

2014-03-27 Thread sean . hefty
From: Ira Weiny Signed-off-by: Ira Weiny --- Makefile.am|3 +- linux/acme_linux.c | 95 man/ib_acme.1 |3 +- src/acme.c | 12 ++- 4 files changed, 5 insertions(+), 108 deletions(-) delete mode 100644 linu

[PATCH 07/16] ibacm: convert logging in acm_util.c to acm_log

2014-03-27 Thread sean . hefty
From: Ira Weiny ib_acme build defines ACME_PRINTS which overrides acm_log to printf Signed-off-by: Ira Weiny --- Makefile.am|2 +- src/acm.c |6 ++ src/acm_util.c | 21 + src/acm_util.h | 12 4 files changed, 24 insertions(+), 17 deleti

[PATCH 04/16] ibacm: move sysfs helper functions to acm_util 'module'

2014-03-27 Thread sean . hefty
From: Ira Weiny This is in preparation for these functions to be included ib both ibacm and ib_acme build. Also rename to more global appropriate name acm_if_* Signed-off-by: Ira Weiny --- Makefile.am|7 ++- linux/acme_linux.c | 87 +--- src/a

[PATCH 03/16] ibacm: use sysfs (in acm_if_is_ib) rather than ioctl(... SIOCGIFHWADDR ...) to read interface type

2014-03-27 Thread sean . hefty
From: Ira Weiny Getting an interface type from sysfs is easier than using an ioctl when an interface name is readily available (as is the case with netlink.) In preparation for netlink support create a function which uses sysfs and use it instead of ioctls. Signed-off-by: Ira Weiny --- linux/

[PATCH 01/16] ibacm: get_devaddr remove unused variable from signature

2014-03-27 Thread sean . hefty
From: Ira Weiny --- linux/acme_linux.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/linux/acme_linux.c b/linux/acme_linux.c index ef5b107..6978db7 100644 --- a/linux/acme_linux.c +++ b/linux/acme_linux.c @@ -102,7 +102,7 @@ get_sgid(struct ifreq *ifr, union ibv_gid

[PATCH 05/16] ibacm: Move calling of helper functions out of get_devaddr

2014-03-27 Thread sean . hefty
From: Ira Weiny Again this is in prep for sharing this code with ibacm and ib_acme get_devaddr uses globals which are specific to ib_acme. Move toward this function being ib_acme specific while the code in get_addr_ip becomes generic. Signed-off-by: Ira Weiny --- linux/acme_linux.c | 64 ++

[PATCH 10/16] ibacm: add locking around end point address arrays

2014-03-27 Thread sean . hefty
From: Ira Weiny Signed-off-by: Ira Weiny --- src/acm.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/acm.c b/src/acm.c index c5da791..ebb48f4 100644 --- a/src/acm.c +++ b/src/acm.c @@ -92,7 +92,7 @@ enum acm_addr_preload { }; /* - * Nested locking order

[PATCH 12/16] ibacm: add/remove addr's in EP's when added/removed from the system.

2014-03-27 Thread sean . hefty
From: Ira Weiny This builds on the previous patch by reacting to the IP address changes monitored there. Signed-off-by: Ira Weiny --- src/acm.c | 112 +++- 1 files changed, 110 insertions(+), 2 deletions(-) diff --git a/src/acm.c b/src/

[PATCH 00/16] ibacm: Implement dynamic IP support

2014-03-27 Thread sean . hefty
From: Sean Hefty The following patch series implements dynamic system IP address updates for ibacm. System IP's are read at start up and Netlink is monitored to respond to system IP address changes. IP's are no longer required or supported in ibacm_addr.cfg after this series. Support for ibacm_

[PATCH 16/16] ibacm: remove processing of IP's from ibacm_addr.cfg

2014-03-27 Thread sean . hefty
From: Ira Weiny Flag an error and do not process IP's which may appear in this file. Signed-off-by: Ira Weiny --- src/acm.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/acm.c b/src/acm.c index 651ccdd..c8a90ad 100644 --- a/src/acm.c +++ b/src/acm.c @@ -

[PATCH 11/16] ibacm: Add thread to monitor IP address changes

2014-03-27 Thread sean . hefty
From: Ira Weiny Currently only reports events to the log Signed-off-by: Ira Weiny --- src/acm.c | 86 + 1 files changed, 86 insertions(+), 0 deletions(-) diff --git a/src/acm.c b/src/acm.c index ebb48f4..a23e953 100644 --- a/src/ac

[PATCH 02/16] ibacm: pass interface name rather than 'struct ifreq' to get_devaddr, get_sgid, and get_pkey

2014-03-27 Thread sean . hefty
From: Ira Weiny Signed-off-by: Ira Weiny --- linux/acme_linux.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/linux/acme_linux.c b/linux/acme_linux.c index 6978db7..201ff19 100644 --- a/linux/acme_linux.c +++ b/linux/acme_linux.c @@ -47,13 +47,13 @@ ex

[PATCH opensm] osm_torus.c: Fix torus crash when actual topology is not torus

2014-03-27 Thread Hal Rosenstock
From: Shlomi Nimrodi Date: Thu, 27 Mar 2014 18:52:49 +0200 Torus crashes when it is configured in a way but actual topology has nothing to do with torus or the configuration, changed it to fail without crash Signed-off-by: Shlomi Nimrodi Reviewed-by: Jim Schutt Signed-off-by: Hal Rosenstock -

[PATCH] RDMA/cxgb4: Disable DSGL use.

2014-03-27 Thread Steve Wise
Current hardware doesn't correctly support DSGL. Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/mem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c index 0989871a..bad9268 100644 ---

Re: Kernel oops/panic with NFS over RDMA mount after disrupted Infiniband connection

2014-03-27 Thread Chuck Lever
Hi- On Mar 27, 2014, at 12:53 AM, Reiter Rafael wrote: > On 03/26/2014 07:15 PM, Chuck Lever wrote: >> >> Hi Rafael- >> >> I’ll take a look. Can you report your HCA and how you reproduce this issue? > > The HCA is Mellanox Technologies MT26428. > > Reproduction: > 1) Mount a directory via N

[Patch 3/3] IB/ib_cm: hang in cm_destroy_id during PCI error injection

2014-03-27 Thread clsoto
This patch is to avoid this hang: kernel: Call Trace: kernel: [c003ea9faa70] [c00144f0] .__switch_to+0x1c0/0x390 kernel: [c003ea9fab20] [c06d5528] .__schedule+0x328/0x920 kernel: [c003ea9fada0] [c06d2da4] .schedule_timeout+0x244/0x2e0 kernel: [c003ea9fae

[Patch 2/3] IB: hang in mcast_remove_one during PCI error injection

2014-03-27 Thread clsoto
This patch is to avoid this hang: kernel: Call Trace: kernel: [C000FF9E34D0] [C000FF9E3560] 0xc000ff9e3560 (unreliable) kernel: [C000FF9E36A0] [C001070C] .__switch_to+0x124/0x148 kernel: [C000FF9E3730] [C03E6D30] .schedule+0xc10/0xdc4 kernel: [C000FF9E3840] [

[Patch 1/3] IB/mlx4: send a IB_EVENT_DEVICE_FATAL to users during PCI error injection

2014-03-27 Thread clsoto
If the cards hits a pci error, then notify users that the device is not in good shape. Send IB_EVENT_DEVICE_FATAL to IB users. Signed-off-by: Carol Soto --- drivers/net/ethernet/mellanox/mlx4/main.c |6 ++ 1 file changed, 6 insertions(+) Index: b/drivers/net/ethernet/mellanox/mlx4/mai

[Patch 0/3] Hangs with IPoIB when doing PCI error injection

2014-03-27 Thread clsoto
This patch is to resolve some hangs we are seeing when doing PCI error injection to Mellanox Infiniband cards. With this patch we make mlx4 driver send an IB_EVENT_DEVICE_FATAL to the users and added this event to event handlers to avoid these hangs. If IPoIB is in connected mode, then added to

[PATCH] IB: allows build of hw/ and ulp/ subdirectory independently

2014-03-27 Thread Yann Droneaud
It is not possible to build only drivers/infiniband/hw/ (and ulp/) subdirectory with command such as: $ make ARCH=x86_64 O=./obj-x86_64/ drivers/infiniband/hw/ This fails with following error messages: make[2]: Nothing to be done for `all'. make[2]: Nothing to be done for `relocs'.

[PATCH V2 for-next] IB/core: Don't resolve passive side RoCE L2 address in cma req handler

2014-03-27 Thread Or Gerlitz
From: Moni Shoua The code that resolves the passive side source mac within the rdma_cm connection request handler was both redundant and buggy, remove it. It was redundant since later, when an RC QP is modified to RTR state the resolution will take place in the ib_core module. It was buggy b/c

Re: [PATCH] librdmacm: lazy initialization for ib devices]

2014-03-27 Thread Or Gerlitz
On 27/03/2014 10:23, Shamir Rabinovith wrote: So what exact capability is under the spot here? and how it's related to a certain HCA driver and not to the kernel uverbs layer? - End forwarded message - ibv_open_device fail when opening the hca many times. sorry, but you didn't provide a

Re: [PATCH] librdmacm: lazy initialization for ib devices]

2014-03-27 Thread Shamir Rabinovith
- Forwarded message from Or Gerlitz - So what exact capability is under the spot here? and how it's related to a certain HCA driver and not to the kernel uverbs layer? - End forwarded message - ibv_open_device fail when opening the hca many times. ucma_init call this api a-prior

Re: Kernel oops/panic with NFS over RDMA mount after disrupted Infiniband connection

2014-03-27 Thread Reiter Rafael
On 03/26/2014 07:15 PM, Chuck Lever wrote: > > Hi Rafael- > > I’ll take a look. Can you report your HCA and how you reproduce this issue? The HCA is Mellanox Technologies MT26428. Reproduction: 1) Mount a directory via NFS/RDMA mount -t nfs -o port=20049,rdma,vers=4.0,timeo=900 172.16.100.2:/ /