Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-04-30 Thread Or Gerlitz
On 01/05/2014 02:28, Doug Ledford wrote: This seems like driving a thumb tack with a sledge hammer. No doubt the correct path here is to get the proper flag added to verbs multicast attach command. Or, do you still have a patch that does this the right way? Did the one from 2008 do it the righ

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Shirley Ma
On 04/30/2014 04:58 PM, Doug Ledford wrote: On 04/302014 Shirley Ma wrote: On 04/30/2014 01:00 PM, Or Gerlitz wrote: On Wed, Apr 30, 2014 at 10:47 PM, Chuck Lever If I understood Yan, he is trying to use NFS/RDMA in guests (kvm?). We are pretty sure that is not working at the moment, can

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-04-30 Thread Doug Ledford
- Original Message - > We need this option for many hosts to avoid backflow of multicast > packages. Could we get that merged? > > > > From 18ceae090b02b3055382e11c305dcb334d938122 Mon Sep 17 00:00:00 > 2001 > From: Or Gerlitz > Date: Tue, 4 Mar 2014 17:20:00 +0200 > Subject: [PATCH] IB

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Doug Ledford
On 04/302014 Shirley Ma wrote: > On 04/30/2014 01:00 PM, Or Gerlitz wrote: > > On Wed, Apr 30, 2014 at 10:47 PM, Chuck Lever > > > > > >> If I understood Yan, he is trying to use NFS/RDMA in guests > >> (kvm?). We > >> are pretty sure that is not working at the moment, > > can you provide a short

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-04-30 Thread Christoph Lameter
On Wed, 30 Apr 2014, Or Gerlitz wrote: > On Tue, Apr 29, 2014 at 8:32 PM, Christoph Lameter wrote: > > > Ok I saw the ODP patches. But where are the multicast block patches? Is > > there any way to move this forward? > > We can try, earlier on this thread I wrote > > "Roland, how you prefer to mo

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Shirley Ma
On 04/30/2014 01:00 PM, Or Gerlitz wrote: On Wed, Apr 30, 2014 at 10:47 PM, Chuck Lever If I understood Yan, he is trying to use NFS/RDMA in guests (kvm?). We are pretty sure that is not working at the moment, can you provide a short 1-2 liner why/what is broken there? the only thing which I

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Or Gerlitz
On Wed, Apr 30, 2014 at 10:47 PM, Chuck Lever > If I understood Yan, he is trying to use NFS/RDMA in guests (kvm?). We > are pretty sure that is not working at the moment, can you provide a short 1-2 liner why/what is broken there? the only thing which I can think of to be not-supported over ml

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Chuck Lever
Hi Or- On Apr 30, 2014, at 3:39 PM, Or Gerlitz wrote: > On Wed, Apr 30, 2014 at 10:16 PM, Shirley Ma wrote: > [...] >> 3. Upstream NFSoRDMA status: > > > So does it currently works...? I understand that Yan tried it out > today, and @ least one side just crashed. > > Chuck, I assume there is

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-04-30 Thread Or Gerlitz
On Tue, Apr 29, 2014 at 8:32 PM, Christoph Lameter wrote: > Ok I saw the ODP patches. But where are the multicast block patches? Is > there any way to move this forward? We can try, earlier on this thread I wrote "Roland, how you prefer to move on here? we can come up with quick patch that just

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Or Gerlitz
On Wed, Apr 30, 2014 at 10:16 PM, Shirley Ma wrote: [...] > 3. Upstream NFSoRDMA status: So does it currently works...? I understand that Yan tried it out today, and @ least one side just crashed. Chuck, I assume there is a configuration which basically works for you and allow you to develop th

[PATCH V3 14/17] xprtrdma: Limit work done by completion handler

2014-04-30 Thread Chuck Lever
Sagi Grimberg points out that a steady stream of CQ events could starve other work because of the boundless loop pooling in rpcrdma_{send,recv}_poll(). Instead of a (potentially infinite) while loop, return after collecting a budgeted number of completions. Signed-off-by: Chuck Lever Acked-by:

[PATCH V3 15/17] xprtrdma: Reduce the number of hardway buffer allocations

2014-04-30 Thread Chuck Lever
While marshaling an RPC/RDMA request, the inline_{rsize,wsize} settings determine whether an inline request is used, or whether read or write chunks lists are built. The current default value of these settings is 1024. Any RPC request smaller than 1024 bytes is sent to the NFS server completely inl

[PATCH V3 17/17] xprtrdma: Remove Tavor MTU setting

2014-04-30 Thread Chuck Lever
Clean up. Remove HCA-specific clutter in xprtrdma, which is supposed to be device-independent. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/verbs.c | 14 -- 1 files changed, 0 insertions(+), 14 deletions(-) diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/ver

[PATCH V3 16/17] xprtrdma: Ensure ia->ri_id->qp is not NULL when reconnecting

2014-04-30 Thread Chuck Lever
Devesh Sharma reports that after a disconnect, his HCA is failing to create a fresh QP, leaving ia_ri->ri_id->qp set to NULL. But xprtrdma still allows RPCs to wake up and post LOCAL_INV as they exit, causing an oops. rpcrdma_ep_connect() is allowing the wake-up by leaking the QP creation error c

[PATCH V3 12/17] xprtrmda: Reduce lock contention in completion handlers

2014-04-30 Thread Chuck Lever
Skip the ib_poll_cq() after re-arming, if the provider knows there are no additional items waiting. (Have a look at commit ed23a727 for more details). Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/verbs.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git

[PATCH V3 13/17] xprtrmda: Reduce calls to ib_poll_cq() in completion handlers

2014-04-30 Thread Chuck Lever
Change the completion handlers to grab up to 16 items per ib_poll_cq() call. No extra ib_poll_cq() is needed if fewer than 16 items are returned. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/verbs.c | 56 ++- net/sunrpc/xprtrdma/xprt_rdma.h |4

[PATCH V3 11/17] xprtrdma: Split the completion queue

2014-04-30 Thread Chuck Lever
The current CQ handler uses the ib_wc.opcode field to distinguish between event types. However, the contents of that field are not reliable if the completion status is not IB_WC_SUCCESS. When an error completion occurs on a send event, the CQ handler schedules a tasklet with something that is not

[PATCH V3 08/17] xprtrdma: mount reports "Invalid mount option" if memreg mode not supported

2014-04-30 Thread Chuck Lever
If the selected memory registration mode is not supported by the underlying provider/HCA, the NFS mount command reports that there was an invalid mount option, and fails. This is misleading. Reporting a problem allocating memory is a lot closer to the truth. Signed-off-by: Chuck Lever --- net/

[PATCH V3 09/17] xprtrdma: Simplify rpcrdma_deregister_external() synopsis

2014-04-30 Thread Chuck Lever
Clean up: All remaining callers of rpcrdma_deregister_external() pass NULL as the last argument, so remove that argument. Signed-off-by: Chuck Lever Tested-by: Steve Wise --- net/sunrpc/xprtrdma/rpc_rdma.c |2 +- net/sunrpc/xprtrdma/transport.c |2 +- net/sunrpc/xprtrdma/verbs.c |

[PATCH V3 10/17] xprtrdma: Make rpcrdma_ep_destroy() return void

2014-04-30 Thread Chuck Lever
Clean up: rpcrdma_ep_destroy() returns a value that is used only to print a debugging message. rpcrdma_ep_destroy() already prints debugging messages in all error cases. Make rpcrdma_ep_destroy() return void instead. Signed-off-by: Chuck Lever Tested-by: Steve Wise --- net/sunrpc/xprtrdma/tra

[PATCH V3 05/17] xprtrdma: Remove MEMWINDOWS registration modes

2014-04-30 Thread Chuck Lever
The MEMWINDOWS and MEMWINDOES_ASYNC memory registration modes were intended as stop-gap modes before the introduction of FRMR. They are now considered obsolete. MEMWINDOWS_ASYNC is also considered unsafe because it can leave client memory registered and exposed for an indeterminant time after each

[PATCH V3 06/17] xprtrdma: Remove REGISTER memory registration mode

2014-04-30 Thread Chuck Lever
All kernel RDMA providers except amso1100 support either MTHCAFMR or FRMR, both of which are faster than REGISTER. amso1100 can continue to use ALLPHYSICAL. The only other ULP consumer in the kernel that uses the reg_phys_mr verb is Lustre. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/r

[PATCH V3 07/17] xprtrdma: Fall back to MTHCAFMR when FRMR is not supported

2014-04-30 Thread Chuck Lever
An audit of in-kernel RDMA providers that do not support the FRMR memory registration shows that several of them support MTHCAFMR. Prefer MTHCAFMR when FRMR is not supported. If MTHCAFMR is not supported, only then choose ALLPHYSICAL. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/verbs.c

[PATCH V3 04/17] xprtrdma: Remove BOUNCEBUFFERS memory registration mode

2014-04-30 Thread Chuck Lever
Clean up: This memory registration mode is slow and was never meant for use in production environments. Remove it to reduce implementation complexity. Signed-off-by: Chuck Lever Tested-by: Steve Wise --- net/sunrpc/xprtrdma/rpc_rdma.c |8 net/sunrpc/xprtrdma/transport.c | 13 --

[PATCH V3 03/17] xprtrdma: RPC/RDMA must invoke xprt_wake_pending_tasks() in process context

2014-04-30 Thread Chuck Lever
An IB provider can invoke rpcrdma_conn_func() in an IRQ context, thus rpcrdma_conn_func() cannot be allowed to directly invoke generic RPC functions like xprt_wake_pending_tasks(). Signed-off-by: Chuck Lever Tested-by: Steve Wise --- net/sunrpc/xprtrdma/rpc_rdma.c | 22 +++--

[PATCH V3 02/17] nfs-rdma: Fix for FMR leaks

2014-04-30 Thread Chuck Lever
From: Allen Andrews Two memory region leaks were found during testing: 1. rpcrdma_buffer_create: While allocating RPCRDMA_FRMR's ib_alloc_fast_reg_mr is called and then ib_alloc_fast_reg_page_list is called. If ib_alloc_fast_reg_page_list returns an error it bails out of the routine dropping th

[PATCH V3 00/17] NFS/RDMA client-side patches

2014-04-30 Thread Chuck Lever
Changes since V2: - Rebased on v3.15-rc3 - "enable pad optimization" dropped. Testing showed Linux NFS/RDMA server does not support pad optimization yet. - "ALLPHYSICAL CONFIG" dropped. There is a lack of consensus on this one. Christoph would like ALLPHYSICAL removed, but the HPC co

[PATCH V3 01/17] xprtrdma: mind the device's max fast register page list depth

2014-04-30 Thread Chuck Lever
From: Steve Wise Some rdma devices don't support a fast register page list depth of at least RPCRDMA_MAX_DATA_SEGS. So xprtrdma needs to chunk its fast register regions according to the minimum of the device max supported depth or RPCRDMA_MAX_DATA_SEGS. Signed-off-by: Steve Wise Reviewed-by: C

NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Shirley Ma
Attendees: Jeff Beck (NASA) Yan Burman (Mellanox) Phil Cayton (Intel) Susan Coulter (LANL) Chuck Lever (Oracle) Shirley Ma (Oracle) Anna Schumaker (Net App) Devesh Sharma (Emulex) Steve Wise (OpenGridComputing, Chelsio) Moderate: Shirley Ma (Oracle) 4/30/2014 meeting summaries: NFSoRDMA develope

[PATCH opensm] osm_console_io.c: Handle return value of function setsockopt

2014-04-30 Thread Hal Rosenstock
From: Tomer Cohen Found by Coverity Signed-off-by: Tomer Cohen Signed-off-by: Hal Rosenstock --- opensm/osm_console_io.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/opensm/osm_console_io.c b/opensm/osm_console_io.c index dfc903f..2426b84 100644 --- a/ope

[PATCH opensm] osm_sa_[mcmember path]_record.c: Optimize clearing of SA record items

2014-04-30 Thread Hal Rosenstock
From: Tomer Cohen Signed-off-by: Tomer Cohen Signed-off-by: Hal Rosenstock --- opensm/osm_sa_mcmember_record.c |2 +- opensm/osm_sa_path_record.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/opensm/osm_sa_mcmember_record.c b/opensm/osm_sa_mcmember_record.c

[PATCH opensm] osm_log.c: Fix wrong hour and date display in log when CL_ASSERT fail

2014-04-30 Thread Hal Rosenstock
From: Tomer Cohen using gettimeofday function instead of cl_get_time_stamp Signed-off-by: Tomer Cohen Signed-off-by: Hal Rosenstock --- opensm/osm_log.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/opensm/osm_log.c b/opensm/osm_log.c index 3460cc5..29e80e4 1006