[PATCH libmlx4 V2 0/2] Add support for UD QPs under RoCE IP addressing

2014-05-07 Thread Or Gerlitz
Hi Yishai, This is just a rebased-port of the series which adds support for Ethernet L2 address resolution for UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. Matan and Or. changes from V1: - rebased aga

[PATCH libmlx4 V2 1/2] Add RoCE IP based addressing support for UD QPs

2014-05-07 Thread Or Gerlitz
From: Matan Barak In order to implement IP based addressing for UD QPs, we need a way to resolve the addresses internally. The L2 params are passed to the provider driver using an extension verbs - drv_ibv_create_ah_ex. libmlx4 gets the extra mac and vid params from libibverbs and sets mlx4_ah re

[PATCH libmlx4 V2 2/2] Add ibv_query_port_ex support

2014-05-07 Thread Or Gerlitz
From: Matan Barak This patch adds the new extended support for query_port. The purpose of this is: 1. Request fields that aren't availible by today's ibv_query_port 2. Don't fetch fields that the user doesn't need. Hence, there is more chance to optimize. 3. Cache link layer's type in mlx4_con

[PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

2014-05-07 Thread Or Gerlitz
From: Matan Barak In order to implement RoCE IP based addressing for UD QPs, without introducing uverbs changes, we need a way to resolve the L2 Ethernet addresses from user-space. This is done with netlink through libnl, and in libibverbs such that multiple vendor provider libraries can use th

[PATCH libibverbs V3 0/3] Add support for UD QPs under RoCE IP addressing

2014-05-07 Thread Or Gerlitz
Hi Roland, This series adds support for Ethernet L2 address resolution for RoCE UD QPs, whose L2 address-handles, unlike RC/UC/XRC/etc QPs are set from user space without going through uverbs and the kernel IB core. The code is also compatible both with old kernels that don't run IP based addressi

[PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

2014-05-07 Thread Or Gerlitz
From: Matan Barak This patch adds extended support for ibv_query_port. This allows to request fields that aren't availible by the current ibv_query_port API and avoid fetching from vendor library fields that the user doesn't need, which gives more room for optimizations. Signed-off-by: Matan Ba

[PATCH libibverbs V3 1/3] Add ibv_port_cap_flags

2014-05-07 Thread Or Gerlitz
From: Matan Barak Add an enum that describes ibv_port_cap_flags that complies with the respective kernel enum. This value could be fetched when using ibv_query_port in port_cap_flags. Signed-off-by: Matan Barak Signed-off-by: Or Gerlitz --- include/infiniband/verbs.h | 22 +

[PATCH v2 2/5] ib/mad: update module to [pr|dev]_* style print messages

2014-05-07 Thread ira . weiny
From: Ira Weiny Use dev_* style print when struct device is available. Also combine previously line broken user-visible strings as per Documentation/CodingStyle "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." Reviewed-by: S

[PATCH v2 3/5] ib/mad: Add dev_notice messages for various umad/mad registration failures

2014-05-07 Thread ira . weiny
From: Ira Weiny Registration failures can be difficult to debug from userspace. This gives more visibility. Reviewed-by: Sean Hefty Reviewed-by: Hal Rosenstock Signed-off-by: Ira Weiny --- drivers/infiniband/core/mad.c | 58 -- drivers/infiniband/cor

[PATCH v2 1/5] ib/umad: update module to [pr|dev]_* style print messages

2014-05-07 Thread ira . weiny
From: Ira Weiny Use dev_* style print when struct device is available. Also combine previously line broken user-visible strings as per Documentation/CodingStyle "However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them." Reviewed-by: S

Re: [ANNOUNCE] libibverbs 1.1.8 is released

2014-05-07 Thread Roland Dreier
On Wed, May 7, 2014 at 1:48 AM, Or Gerlitz wrote: > Roland, due to a mistake I made in the rebased flow-steering patch I handed > you -- I was nominated as the author instead of Matan, our flow-steering > maintainer.. can you please git reword this commit in your libibverbs clone, > I don't think

[ANNOUNCE] libmlx4 1.0.6 is released

2014-05-07 Thread Roland Dreier
libmlx4 is a library that allows programs to use RDMA "verbs" for direct access to RDMA (currently InfiniBand and iWARP) hardware from userspace. The new stable release, 1.0.6, is available from http://www.openfabrics.org/downloads/mlx4/libmlx4-1.0.6.tar.gz with sha1sum ee22cc20f537b5e7

Re: [PATCH] mellanox: Logging message cleanups

2014-05-07 Thread David Miller
Joe, please get rid of the initial empty line you're adding to fw.c and resubmit with Amir's ACK. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.ht

[PATCH v2 opensm] osm_subnet.c: Enhance opensm conf file documentation for PerfMgr options

2014-05-07 Thread Hal Rosenstock
Reviewed-by: Ira Weiny Signed-off-by: Hal Rosenstock --- Change from version 1: Formatted properly for posting to linux-rdma diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index f30d852..8ee62d9 100644 --- a/opensm/osm_subnet.c +++ b/opensm/osm_subnet.c @@ -2628,28 +2628,35 @@ int osm_s

[PATCH opensm] osm_subnet.c: Enhance opensm conf file documentation for PerfMgr options

2014-05-07 Thread Hal Rosenstock
Reviewed-by: Ira Weiny Signed-off-by: Hal Rosenstock --- diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c index f30d852..8ee62d9 100644 --- a/opensm/osm_subnet.c +++ b/opensm/osm_subnet.c @@ -2628,28 +2628,35 @@ int osm_subn_output_conf(FILE *out, IN osm_subn_opt_t * p_opts) fprin

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 5:59 PM, Bart Van Assche wrote: On 05/07/14 13:34, Sagi Grimberg wrote: +module_param(prefer_fr, bool, 0444); +MODULE_PARM_DESC(prefer_fr, + "Whether to use FR if both FMR and FR are supported"); Will it be better to make it a per-target attribute? Hello Sagi, The only rea

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 5:11 PM, Bart Van Assche wrote: On 05/07/14 12:50, Sagi Grimberg wrote: On 5/6/2014 3:54 PM, Bart Van Assche wrote: -static void srp_free_req_data(struct srp_target_port *target) +static void srp_free_req_data(struct srp_target_port *target, + struct srp_request *re

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Sagi Grimberg
On 5/7/2014 4:52 PM, Bart Van Assche wrote: On 05/07/14 12:37, Sagi Grimberg wrote: On 5/6/2014 3:51 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parsc

Re: [PATCH 2/5] ib/mad: update module to pr_* style print messages

2014-05-07 Thread Jason Gunthorpe
On Wed, May 07, 2014 at 02:30:04PM +, Weiny, Ira wrote: > > > > On Mon, May 05, 2014 at 09:44:47PM -0400, ira.we...@intel.com wrote: > > > From: Ira Weiny > > > > > > Also combine previously line broken user-visible strings as per > > > Documentation/CodingStyle > > > > These seem like nice

Re: [PATCH 4/5] ib/mad: add new ioctl to user space to support new registration options

2014-05-07 Thread Jason Gunthorpe
On Wed, May 07, 2014 at 02:39:26PM +, Weiny, Ira wrote: > > On Mon, May 05, 2014 at 09:44:49PM -0400, ira.we...@intel.com wrote: > > > > > +struct ib_user_mad_reg_req2 { > > > + __u32 id; > > > + __u32 qpn; > > > + __u8mgmt_class; > > > + __u8mgmt_class_version; > > > + __u16 res

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Bart Van Assche
On 05/07/14 13:34, Sagi Grimberg wrote: >> +module_param(prefer_fr, bool, 0444); >> +MODULE_PARM_DESC(prefer_fr, >> + "Whether to use FR if both FMR and FR are supported"); > > Will it be better to make it a per-target attribute? Hello Sagi, The only reason I introduced this kernel modul

RE: [PATCH 4/5] ib/mad: add new ioctl to user space to support new registration options

2014-05-07 Thread Weiny, Ira
> > On Mon, May 05, 2014 at 09:44:49PM -0400, ira.we...@intel.com wrote: > > > +struct ib_user_mad_reg_req2 { > > + __u32 id; > > + __u32 qpn; > > + __u8mgmt_class; > > + __u8mgmt_class_version; > > + __u16 res; > > + __u32 flags; > > + __u64 method_mask[2]; > > +

RE: [PATCH 3/5] ib/mad: Add pr_notice messages for various umad/mad registration failures

2014-05-07 Thread Weiny, Ira
> > On Mon, May 05, 2014 at 09:44:48PM -0400, ira.we...@intel.com wrote: > > From: Ira Weiny > > An empty commit message is not good enough for the mainline kernel, > please describe motivation at least. Will do. > > I am worried about log DOS potential here, it looks like many of these > mes

RE: [PATCH 2/5] ib/mad: update module to pr_* style print messages

2014-05-07 Thread Weiny, Ira
> > On Mon, May 05, 2014 at 09:44:47PM -0400, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Also combine previously line broken user-visible strings as per > > Documentation/CodingStyle > > These seem like nice cleanups, however it would be much nicer to use the > dev_* versions when a

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Bart Van Assche
On 05/07/14 12:50, Sagi Grimberg wrote: > On 5/6/2014 3:54 PM, Bart Van Assche wrote: >> -static void srp_free_req_data(struct srp_target_port *target) >> +static void srp_free_req_data(struct srp_target_port *target, >> + struct srp_request *req_ring) >> { >> struct ib_dev

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Bart Van Assche
On 05/07/14 12:37, Sagi Grimberg wrote: > On 5/6/2014 3:51 PM, Bart Van Assche wrote: >> This patch does not change any functionality. >> >> Signed-off-by: Bart Van Assche >> Cc: Roland Dreier >> Cc: David Dillow >> Cc: Sagi Grimberg >> Cc: Vu Pham >> Cc: Sebastian Parschauer >> --- >> driv

[PATCH opensm] osm_port_info_rcv.c: Fixed calculation of min_data_vls

2014-05-07 Thread Hal Rosenstock
From: Tomer Cohen Date: Sun, 13 Apr 2014 15:26:47 +0300 Bug description: opensm is not using future value of op_vls when calculating subnet's minimal op_vl. opensm calculates minimal op_vls (sm->p_subn->min_data_vl) when receiving pi mads, and the linkmgr might update that

Re: [PATCH 9/9] IB/srp: Add fast registration support

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:56 PM, Bart Van Assche wrote: Certain HCA types (e.g. Connect-IB) and certain configurations (e.g. ConnectX VF) support FR but not FMR. Hence add FR support. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschaue

Re: [PATCH 7/9] IB/srp: Avoid triggering an infinite loop if memory mapping fails

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:55 PM, Bart Van Assche wrote: Only request the SCSI mid-layer to retry a SCSI command after a temporary mapping failure (-ENOMEM) but not after a permanent mapping failure. This patch avoids that SCSI commands are retried indefinitely if a permanent memory mapping failure occurs. S

Re: [PATCH 6/9] IB/srp: Make srp_alloc_req_data() reallocate request data

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:54 PM, Bart Van Assche wrote: This patch is needed by the patch that adds fast registration support. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschauer --- drivers/infiniband/ulp/srp/ib_srp.c | 41 +++

Re: [PATCH 5/9] IB/srp: Introduce srp_finish_mapping()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:53 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschauer --- drivers/infiniband/ulp/srp/ib_srp.c | 37 +---

Re: [PATCH 4/9] IB/srp: Introduce srp_map_fmr()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:53 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschauer --- drivers/infiniband/ulp/srp/ib_srp.c | 77 ++--

Re: [PATCH 3/9] IB/srp: Introduce srp_alloc_fmr_pool()

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:52 PM, Bart Van Assche wrote: Introduce the srp_alloc_fmr_pool() function. Only set srp_dev->fmr_max_size if FMR pool creation succeeded. This change is safe since that variable is only used if FMR pool creation succeeded. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: Davi

Re: [PATCH 2/9] IB/srp: Introduce an additional local variable

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:51 PM, Bart Van Assche wrote: This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschauer --- drivers/infiniband/ulp/srp/ib_srp.c | 9 - 1 file changed, 4 ins

Re: [PATCH 1/9] IB/srp: Fix kernel-doc warnings

2014-05-07 Thread Sagi Grimberg
On 5/6/2014 3:50 PM, Bart Van Assche wrote: Avoid that the kernel-doc tool warns about missing argument descriptions for the ib_srp.[ch] source files. Signed-off-by: Bart Van Assche Cc: Roland Dreier Cc: David Dillow Cc: Sagi Grimberg Cc: Vu Pham Cc: Sebastian Parschauer --- drivers/infi

Re: [ANNOUNCE] libibverbs 1.1.8 is released

2014-05-07 Thread Or Gerlitz
On 05/05/2014 22:19, Roland Dreier wrote: Matan Barak (1): Add general definitions to support uverbs extensions Or Gerlitz (1): Add receive flow steering support Roland, due to a mistake I made in the rebased flow-steering patch I handed you -- I was nominated as the author inst