[PATCH 1/1] IPoIB: Improve parent interface p_key handling.

2014-06-05 Thread Alex Estrin
Resending as there was a typo in Subject line. -- With reference to commit c2904141696ee19551f155396f23cdd5d95e. It was noticed that parent interface keeps sending broadcast group join requests if p_key index 0 is invalid. That creates unnecessary noise on a fabric: ib0:

Re: [PATCH 1/2] libiscsi, iser: Adjust data_length to include protection information

2014-06-05 Thread Sagi Grimberg
On 6/4/2014 1:18 AM, Martin K. Petersen wrote: "Mike" == Mike Christie writes: Mike> On 06/01/2014 11:19 AM, Sagi Grimberg wrote: +/* + * data integrity helpers + */ +static inline unsigned +iscsi_prot_len(unsigned data_len, unsigned sector_size) +{ + switch (sector_size) { + case 512: + retur

Re: [PATCH 1/2] libiscsi, iser: Adjust data_length to include protection information

2014-06-05 Thread Sagi Grimberg
On 6/3/2014 7:11 PM, Mike Christie wrote: On 06/01/2014 11:19 AM, Sagi Grimberg wrote: /** + * iscsi_adjust_dl - Adjust SCSI data length to include PI + * @sc: scsi command. + * @data_length: command data length. + * + * Adjust the data length to account for how much data + * is actually on th

Re: [PATCH 0/2] Include protection information in iscsi header

2014-06-05 Thread Sagi Grimberg
On 6/3/2014 9:16 AM, Roland Dreier wrote: On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Why? Because they break wire compatibility? I hate

Re: [PATCH 2/2] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire

2014-06-05 Thread Sagi Grimberg
On 6/2/2014 7:54 PM, Martin K. Petersen wrote: "Sagi" == Sagi Grimberg writes: Sagi, Sagi> In various areas of the code, it is assumed that Sagi> se_cmd-> data_length describes pure data. In case Sagi> that protection information exists over the wire (protect bits is Sagi> are on) the target c

[PATCH 1/1] IPoOB: Improve parent interface p_key handling.

2014-06-05 Thread Alex Estrin
With reference to commit c2904141696ee19551f155396f23cdd5d95e. It was noticed that parent interface keeps sending broadcast group join requests if p_key index 0 is invalid. That creates unnecessary noise on a fabric: ib0: multicast join failed for ff12:401b:8000:::::, stat

RE: [PATCH V2] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread Steve Wise
> -Original Message- > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > Sent: Thursday, June 05, 2014 11:14 AM > To: Steve Wise > Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org; > t...@opengridcomputing.com > Subject: Re: [PATCH V2] svcrdma: Fence LOCAL_INV work requests

Re: [PATCH V2] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread J. Bruce Fields
On Thu, Jun 05, 2014 at 09:54:31AM -0500, Steve Wise wrote: > This applies on top of: > > commit e5a070216356dbcb03607cb264cc3104e17339b3 > Author: Steve Wise > Date: Wed May 28 15:12:01 2014 -0500 > > svcrdma: refactor marshalling logic Sorry, I lost track--was th

Re: [PATCH] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread Steve Wise
On 6/5/2014 8:55 AM, Steve Wise wrote -Original Message- From: Bart Van Assche [mailto:bvanass...@acm.org] Sent: Thursday, June 05, 2014 2:23 AM To: Steve Wise; bfie...@fieldses.org Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org; t...@opengridcomputing.com Subject: Re: [PATCH]

[PATCH opensm] osm_trap_rcv.c: Lock released without locking in some cases of trap processing

2014-06-05 Thread Hal Rosenstock
Signed-off-by: Vladimir Koushnir Signed-off-by: Hal Rosenstock --- opensm/osm_trap_rcv.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/opensm/osm_trap_rcv.c b/opensm/osm_trap_rcv.c index ce26efa..2aef40e 100644 --- a/opensm/osm_trap_rcv.c +++ b/opensm/osm_trap_r

[PATCH V2] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread Steve Wise
This applies on top of: commit e5a070216356dbcb03607cb264cc3104e17339b3 Author: Steve Wise Date: Wed May 28 15:12:01 2014 -0500 svcrdma: refactor marshalling logic Fencing forces the invalidate to only happen after all prior send work requests have been com

RE: [PATCH] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread Steve Wise
> -Original Message- > From: Bart Van Assche [mailto:bvanass...@acm.org] > Sent: Thursday, June 05, 2014 2:23 AM > To: Steve Wise; bfie...@fieldses.org > Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org; > t...@opengridcomputing.com > Subject: Re: [PATCH] svcrdma: Fence LOCAL_IN

Re: [PATCHv1 4/4] RDMA/cxgb4: add missing padding at end of struct c4iw_alloc_ucontext_resp

2014-06-05 Thread Yann Droneaud
Hi Roland, Le jeudi 22 mai 2014 à 08:21 +0200, Yann Droneaud a écrit : > Le lundi 05 mai 2014 à 19:35 +0200, Yann Droneaud a écrit : > > i386 ABI disagree with most other ABIs regarding alignment > > of data type larger than 4 bytes: on most ABIs a padding must > > be added at end of the structure

Re: [PATCHv1 2/4] RDMA/mlx5: add missing padding at end of struct mlx5_ib_create_srq

2014-06-05 Thread Yann Droneaud
Hi, Le dimanche 11 mai 2014 à 10:12 +0300, Eli Cohen a écrit : > Acked by: Eli Cohen This Acked-by: tag was not applied on commit 43bc889380c2, in for-next branch (HEAD at ca846ce98ca3). PS: Eli, you've made a typo in your Acked-by :) Regards. -- Yann Droneaud OPTEYA -- To unsubscribe from

Re: [PATCHv1 1/4] RDMA/mlx5: add missing padding at end of struct mlx5_ib_create_cq

2014-06-05 Thread Yann Droneaud
Hi Roland, Le dimanche 11 mai 2014 à 10:10 +0300, Eli Cohen a écrit : > Acked by: Eli Cohen > This Acked-by: tag was not applied on commit a8237b32a3fa, in for-next branch (HEAD at ca846ce98ca3). PS: Eli, you've made a typo in your Acked-by :) Regards. -- Yann Droneaud OPTEYA -- To unsubs

Re: [PATCH] svcrdma: Fence LOCAL_INV work requests

2014-06-05 Thread Bart Van Assche
On 06/02/14 19:14, Steve Wise wrote: > Fencing forces the invalidate to only happen after all subsequent send > work requests have been completed. Shouldn't that read "prior" instead of "subsequent" ? Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a