Re: mlx4: using dma_sync_single_for_cpu/dma_sync_single_for_cpu for writing MTT instead of WRITE_MTT hcr command

2014-07-10 Thread Jack Morgenstein
On Wed, 9 Jul 2014 18:40:46 +0530 Bob Biloxi iambobbil...@gmail.com wrote: Hi, I was going through the mr.c file as part of understanding WRITE_MTT command in the mlx4 code. I could see that instead of issuing the WRITE_MTT HCR command, in case of SRIOV, we're directly accessing the ICM

[PATCH v7 26/33] net: ipoib - set name assign type

2014-07-10 Thread Tom Gundersen
When naming a device based on a combination of the parent device, and the upsr-supplied key, inherit the name assign type from the parent. Signed-off-by: Tom Gundersen t...@jklm.no Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Cc: Hal Rosenstock hal.rosenst...@gmail.com

[PATCH v7 25/33] net: infiniband - steal ifname label

2014-07-10 Thread Tom Gundersen
Use the same assign type, as the name we are basing our new name on. Signed-off-by: Tom Gundersen t...@jklm.no Cc: Tom Tucker t...@opengridcomputing.com Cc: Steve Wise sw...@opengridcomputing.com Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Cc: Hal Rosenstock

Re: mlx4: using dma_sync_single_for_cpu/dma_sync_single_for_cpu for writing MTT instead of WRITE_MTT hcr command

2014-07-10 Thread Bob Biloxi
Hi Jack, Thanks so much for the response.. This is really helpful! Best Regards, Marc On Thu, Jul 10, 2014 at 1:25 PM, Jack Morgenstein ja...@dev.mellanox.co.il wrote: On Wed, 9 Jul 2014 18:40:46 +0530 Bob Biloxi iambobbil...@gmail.com wrote: Hi, I was going through the mr.c file as part

Re: [PATCH v2 15/21] xprtrdma: Disable completions for LOCAL_INV Work Requests

2014-07-10 Thread Shirley Ma
That would significantly reduce the interrupts rate. I will run some performance test. Would these unsignaled SENDs be possible to stall? Shirley On 07/09/2014 09:58 AM, Chuck Lever wrote: Instead of relying on a completion to change the state of an FRMR to FRMR_IS_INVALID, set it in

[PATCH 0/2] NFS/RDMA server patches for 3.17

2014-07-10 Thread Chuck Lever
Hi Steve- Can you include these two potential 3.17 candidate patches in your testing branch? --- Chuck Lever (2): svcrdma: Remove extra writeargs sanity check for NFSv2/3 svcrdma: Increase credit limit to 32 fs/nfsd/nfs3xdr.c | 15 +-- fs/nfsd/nfsxdr.c

[PATCH 1/2] svcrdma: Increase credit limit to 32

2014-07-10 Thread Chuck Lever
Signed-off-by: Chuck Lever chuck.le...@oracle.com --- include/linux/sunrpc/svc_rdma.h |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h index 5cf99a0..975da75 100644 --- a/include/linux/sunrpc/svc_rdma.h

[PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
The server should comply with RFC 5667, and handle WRITE payloads that may not have a zero pad on the end (XDR length round-up). Fixes: f34b9568 (The NFSv2/NFSv3 server does not handle zero...) BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=246 Signed-off-by: Chuck Lever

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: The server should comply with RFC 5667, Where's the relevant language? (I took a quick look but didn't see it.) and handle WRITE payloads that may not have a zero pad on the end (XDR length round-up). Fixes: f34b9568 (The

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
On Jul 10, 2014, at 2:19 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: The server should comply with RFC 5667, Where's the relevant language? (I took a quick look but didn't see it.) Sorry, I listed the wrong RFC when I wrote

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: On Jul 10, 2014, at 2:19 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: The server should comply with RFC 5667, Where's the relevant language? (I took a quick

Re: [PATCH 0/2] NFS/RDMA server patches for 3.17

2014-07-10 Thread Steve Wise
Done! (my email is sw...@opengridcomputing.com) Steve. On 7/10/2014 12:44 PM, Chuck Lever wrote: Hi Steve- Can you include these two potential 3.17 candidate patches in your testing branch? --- Chuck Lever (2): svcrdma: Remove extra writeargs sanity check for NFSv2/3 svcrdma:

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
Hi Bruce- On Jul 10, 2014, at 2:49 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: On Jul 10, 2014, at 2:19 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: The server

Re: [PATCH v2 00/21] NFS/RDMA client patches for 3.17

2014-07-10 Thread Steve Wise
Hey Chuck, I tested this series and it tested ok for me. I tested NFS v3 and v4 over cxgb4 and mlx4: cthon, iozone, fio, and xfs. No regressions seen. --- Tested-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 03:07:34PM -0400, Chuck Lever wrote: Hi Bruce- On Jul 10, 2014, at 2:49 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: On Jul 10, 2014, at 2:19 PM, J. Bruce Fields bfie...@fieldses.org wrote: On

RE: [PATCH] svcrdma: send_write() must not overflow the device's max sge

2014-07-10 Thread Steve Wise
I tested this with nfsv3 and v4, over cxgb4 and mlx4: cthon04, iozone, fio, and xfs. No regressions seen... Steve. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] svcrdma: send_write() must not overflow the device's max sge

2014-07-10 Thread J. Bruce Fields
On Wed, Jul 09, 2014 at 01:49:15PM -0500, Steve Wise wrote: Function send_write() must stop creating sges when it reaches the device max and return the amount sent in the RDMA Write to the caller. Queueing up for 3.17, thanks.--b. Signed-off-by: Steve Wise sw...@opengridcomputing.com ---

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
[ Correcting Steve’s e-mail address ] On Jul 10, 2014, at 3:43 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at 03:07:34PM -0400, Chuck Lever wrote: Hi Bruce- On Jul 10, 2014, at 2:49 PM, J. Bruce Fields bfie...@fieldses.org wrote: On Thu, Jul 10, 2014 at