Re: [PATCH V1 for-next 1/2] IB/uverbs: Enable device removal when there are active user space applications

2014-11-19 Thread Or Gerlitz
On 11/18/2014 11:42 PM, Or Gerlitz wrote: On Tue, Nov 18, 2014 at 6:24 PM, Yishai Hadasyish...@dev.mellanox.co.il The IB device pointer is not valid at all spots, for example after the HW Device was removed, that's why we set this information on the uverbs device. In 2nd thought, they must

[PATCH for-next] IB/core: Fix mgid key handling in SA agent multicast data-base

2014-11-19 Thread Or Gerlitz
From: Jack Morgenstein ja...@dev.mellanox.co.il Applications can request that the SM assign an mgid, by passing a mcast member request containing an mgid = 0. When the SM responds by sending the allocated mgid, this mgid replaces the 0-mgid in the multicast group. However, the mgid field in the

Re: [PATCH for-next] IB/core: Fix mgid key handling in SA agent multicast data-base

2014-11-19 Thread Or Gerlitz
On 11/19/2014 11:08 AM, Or Gerlitz wrote: Since this is a key field, correct handling requires that the group entry be deleted from the rb table, and then re-inserted with the new key, so that the table structure is properly maintained. The current code does not do this correctly. Correct

[PATCH for-next] IB/core: Do not resolve VLAN if already resolved

2014-11-19 Thread Or Gerlitz
From: Moni Shoua mo...@mellanox.com For RoCE, resolution of layer 2 address attributes forces no VLAN if link local gids are used. This patch enables applications that want to choose VLAN ID for link local based RoCE gids by setting IB_QP_VID in their QP attribute mask and prevent the core to

[PATCH 2/2] libmlx4: add support for the s390x platform

2014-11-19 Thread Alexey Ishchuk
Since, s390x platform requires execution of privileged CPU instructions to work with PCI I/O memory, the PCI I/O memory cannot be directly accessed from the userspace programs via the mapped memory areas. The current implementation of the Inifiniband verbs uses mapped memory areas to write data to

[PATCH 1/2] libibverbs: add support for the s390x platform

2014-11-19 Thread Alexey Ishchuk
This patch adds the required platform specific code to allow execution of the libibverbs functions on the s390x platform. Signed-off-by: Alexey Ishchuk aishc...@linux.vnet.ibm.com --- include/infiniband/arch.h |7 +++ 1 file changed, 7 insertions(+) --- a/include/infiniband/arch.h +++

Re: [PATCH V1 for-next 2/2] IB/mlx4_ib: Disassociate support

2014-11-19 Thread Yishai Hadas
On 11/18/2014 11:50 PM, Or Gerlitz wrote: On Tue, Nov 18, 2014 at 7:14 PM, Yishai Hadas yish...@dev.mellanox.co.il wrote: On 11/18/2014 4:42 PM, Or Gerlitz wrote: Can we somehow make this patch generic (e.g land in the IB core) such that it can apply also for mlx5 (and other HW drivers...)

Re: [PATCH V1 for-next 2/2] IB/mlx4_ib: Disassociate support

2014-11-19 Thread Or Gerlitz
On 11/19/2014 2:15 PM, Yishai Hadas wrote: For that reason we believe that the correct place to use the zap call is in the HW driver and not in IB core OK let it be - get this one (after the trivial comments are addressed) in and let the ones that follow see if they can generalize/re-use

[PATCH 0/3] Ibacm/ibacmp bug fixes

2014-11-19 Thread kaike . wan
From: Kaike Wan kaike@intel.com This patch series fixes a print format error and two bugs related to SM restart. Kaike Wan (3): ibacmp: missing '%' in acm_log format ibacm: close the provider endpoint when it fails to assign a name to a core endpoint ibacm/ibacmp: fix a crash when

[PATCH 2/3] ibacm: close the provider endpoint when it fails to assign a name to a core endpoint

2014-11-19 Thread kaike . wan
From: Kaike Wan kaike@intel.com In function acm_ep_up(), when it fails to assign any name to an endpoint, the endpoint in the provider is not properly closed before the core endpoint is freed. This may cause segfault when ibacmp tries to join multicast group with a stale core endpoint

[PATCH 3/3] ibacm/ibacmp: fix a crash when SM restarts

2014-11-19 Thread kaike . wan
From: Kaike Wan kaike@intel.com Ibacm may cause segfault when the SM restarts: when the SM restarts, ibacm will receive P_Key change event and instruct ibacmp to close all endpoints. However, ibacmp only resets the core endpoint pointer in its ep structure and keeps the ep in the port's

Re: [PATCH V1 for-next 1/2] IB/uverbs: Enable device removal when there are active user space applications

2014-11-19 Thread Or Gerlitz
On 11/18/2014 2:11 PM, Yishai Hadas wrote: @@ -533,6 +552,12 @@ void ib_uverbs_event_handler(struct ib_event_handler *handler, struct ib_uverbs_file *file = container_of(handler, struct ib_uverbs_file, event_handler); + if (event-event == IB_EVENT_DEVICE_FATAL) { +

[PATCH 1/3] ibacmp: missing '%' in acm_log format

2014-11-19 Thread kaike . wan
From: Kaike Wan kaike@intel.com This debugging print is in function acmp_get_ep(). Signed-off-by: Kaike Wan kaike@intel.com --- prov/acmp/src/acmp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/prov/acmp/src/acmp.c b/prov/acmp/src/acmp.c index

[PATCH 1/1] InfiniBand: Deletion of unnecessary checks before two function calls

2014-11-19 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Wed, 19 Nov 2014 19:19:21 +0100 The functions kfree() and pci_dev_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH V1 for-next 1/2] IB/uverbs: Enable device removal when there are active user space applications

2014-11-19 Thread Yishai Hadas
On 11/19/2014 4:49 PM, Or Gerlitz wrote: On 11/18/2014 2:11 PM, Yishai Hadas wrote: @@ -533,6 +552,12 @@ void ib_uverbs_event_handler(struct ib_event_handler *handler, struct ib_uverbs_file *file = container_of(handler, struct ib_uverbs_file, event_handler); +if (event-event