RE: [PATCH infiniband-diags] ibccquery.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Weiny, Ira
> > Enhanced switch port 0 can support CC (indicated in CC > ClassPortInfo:CapabilityMask.EnhancedPort0CC). > > portnum 0 is a valid port number and offsets should be calculated based on > port 0 rather than port 1. > > Also, fix some error messages to indicate switch port congestion setting >

RE: [PATCH infiniband-diags] ibccconfig.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Weiny, Ira
> > Enhanced switch port 0 can support CC (indicated in CC > ClassPortInfo:CapabilityMask.EnhancedPort0CC). > > portnum 0 is a valid port number and offsets should be calculated based on > port 0 rather than port 1. > > Also, fix some error messages to indicate switch port congestion setting >

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

2015-01-09 Thread Weiny, Ira
> > When idebug is >= 1, mad_rpc and mad_rpc_rmpp output only the mad data > response in debug output. It does not output the request mad data. This is > confusing since it's not clear if it's request or response output. > > When idebug > 1, full mad send and receive buffers are output, which m

[PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

2015-01-09 Thread Albert Chu
When idebug is >= 1, mad_rpc and mad_rpc_rmpp output only the mad data response in debug output. It does not output the request mad data. This is confusing since it's not clear if it's request or response output. When idebug > 1, full mad send and receive buffers are output, which makes the mad

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

2015-01-09 Thread Albert Chu
Just didn't hit the issue there so didn't think to remove it there a well. I'll repost Al On Fri, 2015-01-09 at 23:27 +, Weiny, Ira wrote: > Any reason this should not be removed from mad_rpc_rmpp as well? > > Ira > > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.o

RE: [PATCHv2 libibmad] fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal

2015-01-09 Thread Weiny, Ira
> for consistency with CC Annex which shows meaning of threshold fields in hex > not decimal > > Signed-off-by: Hal Rosenstock Thanks applied. Ira > --- > Change since v1: > Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be > consistent with CC Annex > > diff --git

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

2015-01-09 Thread Weiny, Ira
Any reason this should not be removed from mad_rpc_rmpp as well? Ira > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Albert Chu > Sent: Friday, December 19, 2014 11:08 AM > To: linux-rdma@vger.kernel.org > Subject: [

Re: [PATCH v1 00/10] NFS/RDMA server for 3.20

2015-01-09 Thread J. Bruce Fields
On Fri, Jan 09, 2015 at 03:40:51PM -0500, Chuck Lever wrote: > > On Jan 9, 2015, at 3:39 PM, J. Bruce Fields wrote: > > > On Fri, Jan 09, 2015 at 02:21:54PM -0500, Chuck Lever wrote: > >> In addition to miscellaneous clean up, the following series of > >> patches for the Linux NFS server introdu

Re: [PATCH v1 00/10] NFS/RDMA server for 3.20

2015-01-09 Thread Chuck Lever
On Jan 9, 2015, at 3:39 PM, J. Bruce Fields wrote: > On Fri, Jan 09, 2015 at 02:21:54PM -0500, Chuck Lever wrote: >> In addition to miscellaneous clean up, the following series of >> patches for the Linux NFS server introduces support in the >> server’s RPC/RDMA transport implementation for RDMA

Re: [PATCH v1 00/10] NFS/RDMA server for 3.20

2015-01-09 Thread J. Bruce Fields
On Fri, Jan 09, 2015 at 02:21:54PM -0500, Chuck Lever wrote: > In addition to miscellaneous clean up, the following series of > patches for the Linux NFS server introduces support in the > server’s RPC/RDMA transport implementation for RDMA_NOMSG type > messages, and fixes a bug that prevents the s

Re: [PATCH v1 09/10] Move read list XDR round-up logic

2015-01-09 Thread Chuck Lever
On Jan 9, 2015, at 3:14 PM, J. Bruce Fields wrote: > On Fri, Jan 09, 2015 at 02:23:11PM -0500, Chuck Lever wrote: >> Simpler approach, and this needs to be done before the tail is >> copied to the end of the read list (pre-requisite for a subsequent >> patch). >> >> Fixes: e560e3b510d2 ("svcrdm

Re: [PATCH v1 09/10] Move read list XDR round-up logic

2015-01-09 Thread J. Bruce Fields
On Fri, Jan 09, 2015 at 02:23:11PM -0500, Chuck Lever wrote: > Simpler approach, and this needs to be done before the tail is > copied to the end of the read list (pre-requisite for a subsequent > patch). > > Fixes: e560e3b510d2 ("svcrdma: Add zero padding if the client... ") Wait, does this actu

[PATCH v1 09/10] Move read list XDR round-up logic

2015-01-09 Thread Chuck Lever
Simpler approach, and this needs to be done before the tail is copied to the end of the read list (pre-requisite for a subsequent patch). Fixes: e560e3b510d2 ("svcrdma: Add zero padding if the client... ") Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 37 ---

[PATCH v1 10/10] svcrdma: Handle additional inline content

2015-01-09 Thread Chuck Lever
Most NFS RPCs place large payload arguments at the end of the RPC header (eg, NFSv3 WRITE). For NFSv3 WRITE and SYMLINK, RPC/RDMA sends the complete RPC header inline, and the payload argument in a read list. One important case is not like this, however. NFSv4 WRITE compounds can have an operation

[PATCH v1 07/10] svcrdma: rc_position sanity checking

2015-01-09 Thread Chuck Lever
An RPC/RDMA client may send large data payloads via a read chunk list. This is a list of scatter/gather elements which are RPC call arguments too large to fit in a small RDMA SEND. Each read chunk list entry has a "position" which is the offset in the RPC header where the chunk list payload should

[PATCH v1 08/10] svcrdma: Support RDMA_NOMSG requests

2015-01-09 Thread Chuck Lever
Currently the Linux server can not decode RDMA_NOMSG type requests. The client sends the RPC/RDMA header via RDMA SEND. The header has a read chunk list that conveys the RPC and NFS headers and the NFS payload (if any). Large operations like NFSv4 CREATE(NF4LNK) will by conveyed via RDMA_NOMSG, so

[PATCH v1 03/10] svcrdma: Clean up read chunk counting

2015-01-09 Thread Chuck Lever
The byte_count argument is not used, and the function is called only from one place. Signed-off-by: Chuck Lever --- include/linux/sunrpc/svc_rdma.h |2 -- net/sunrpc/xprtrdma/svc_rdma_marshal.c | 16 net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 15 ---

[PATCH v1 00/10] NFS/RDMA server for 3.20

2015-01-09 Thread Chuck Lever
In addition to miscellaneous clean up, the following series of patches for the Linux NFS server introduces support in the server’s RPC/RDMA transport implementation for RDMA_NOMSG type messages, and fixes a bug that prevents the server from handling RPC/RDMA messages with inline content following a

[PATCH v1 06/10] svcrdma: Plant reader function in struct svcxprt_rdma

2015-01-09 Thread Chuck Lever
The RDMA reader function doesn't change once an svcxprt is instantiated. Instead of checking sc_devcap during every incoming RPC, set the reader function once when the connection is accepted. Signed-off-by: Chuck Lever --- include/linux/sunrpc/svc_rdma.h | 10 net/sunrpc/xprtrdm

[PATCH v1 01/10] svcrdma: Clean up dprintk

2015-01-09 Thread Chuck Lever
Nit: Fix inconsistent white space in dprintk messages. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c index

[PATCH v1 02/10] svcrdma: Remove unused variable

2015-01-09 Thread Chuck Lever
Nit: remove an unused variable to squelch a compiler warning. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c in

[PATCH v1 04/10] svcrdma: Scrub BUG_ON() and WARN_ON() call sites

2015-01-09 Thread Chuck Lever
Current convention is to avoid using BUG_ON() in places where an oops could cause complete system failure. Replace BUG_ON() call sites in svcrdma with an assertion error message and allow execution to continue safely. Some BUG_ON() calls are removed because they have never fired in production (th

[PATCH v1 05/10] svcrdma: Find rmsgp more reliably

2015-01-09 Thread Chuck Lever
xdr_start() can return the wrong rmsgp address if an assumption about how the xdr_buf was constructed changes. When it gets it wrong, the client receives a reply that has gibberish in the RPC/RDMA header, preventing it from matching a waiting RPC request. Instead, make (and document) just one ass

Re: [PATCH infiniband-diags] ibccconfig.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Hal Rosenstock
On 1/9/2015 10:46 AM, Weiny, Ira wrote: > [off-list] > > This replaces the first one? This is ibccconfig. Other was for ibccquery. Similar subjects but separated by tool rather than one patch for both. > >> -Original Message- >> From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] >> S

RE: [PATCH infiniband-diags] ibccconfig.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Weiny, Ira
[off-list] This replaces the first one? > -Original Message- > From: Hal Rosenstock [mailto:h...@dev.mellanox.co.il] > Sent: Friday, January 09, 2015 7:18 AM > To: Weiny, Ira > Cc: linux-rdma (linux-rdma@vger.kernel.org); Chu, Al > Subject: [PATCH infiniband-diags] ibccconfig.c: Account f

[PATCH infiniband-diags] ibccconfig.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Hal Rosenstock
Enhanced switch port 0 can support CC (indicated in CC ClassPortInfo:CapabilityMask.EnhancedPort0CC). portnum 0 is a valid port number and offsets should be calculated based on port 0 rather than port 1. Also, fix some error messages to indicate switch port congestion setting rather then switch

[PATCH infiniband-diags] ibccquery.c: Account for enhanced switch port 0 in SwitchPortCongestionSetting handling

2015-01-09 Thread Hal Rosenstock
Enhanced switch port 0 can support CC (indicated in CC ClassPortInfo:CapabilityMask.EnhancedPort0CC). portnum 0 is a valid port number and offsets should be calculated based on port 0 rather than port 1. Also, fix some error messages to indicate switch port congestion setting rather then switch

[PATCH] net/9p: add a privport option for RDMA transport.

2015-01-09 Thread Dominique Martinet
RDMA can use the same kind of weak security as TCP by checking the client can bind to a privileged port, which is better than nothing if TAUTH isn't implemented. Signed-off-by: Dominique Martinet --- Please note that this does NOT checkpatch because option tokens "Opt_foo" are considered CamelCa

[PATCHv2 libibmad] fields.c: Print SwitchCongestionSetting threshold fields in hex rather than decimal

2015-01-09 Thread Hal Rosenstock
for consistency with CC Annex which shows meaning of threshold fields in hex not decimal Signed-off-by: Hal Rosenstock --- Change since v1: Change fields to hex rather than SwitchPortCongestionSetting:Threshold to be consistent with CC Annex diff --git a/src/fields.c b/src/fields.c index 33a63

Re: [PATCH V1 FIX for-3.19] IB/ipoib: Fix broken multicast flow

2015-01-09 Thread Or Gerlitz
On Wed, Jan 7, 2015 at 5:04 PM, Or Gerlitz wrote: > From: Erez Shitrit > > Following commit 016d9fb25cd9 "IPoIB: fix MCAST_FLAG_BUSY usage" > both IPv6 traffic and for the most cases all IPv4 multicast traffic > aren't working. Doug, can you ack the breakage introduced by your commit and the fix