Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-19 Thread Or Gerlitz
On 2/18/2015 8:07 AM, Roland Dreier wrote: On Tue, Feb 17, 2015 at 9:03 PM, Or Gerlitz ogerl...@mellanox.com wrote: Roland, can you please pick this one too, it's a bug fix and no comments were raised against it. I just failed to remove the Gerrit Issue: XXX line, so if you can do that, will

RE: [PATCH] RDMA/ocrdma: Changes in driver to incorporate the moving of GID Table mgmt to IB/Core.

2015-02-19 Thread Somnath Kotur
Shachar, Yes, it happened by mistake which I realized and immediately sent out the patch with the correct patch number Thanks Som -Original Message- From: Shachar Raindel [mailto:rain...@mellanox.com] Sent: Thursday, February 19, 2015 2:31 PM To: Somnath Kotur;

RE: [PATCH v1 00/30] IB/Core: Adding support for RoCEV2 Specification

2015-02-19 Thread Somnath Kotur
Hi Bart, Here's the link to the git tree with the patches https://github.com/matanb10/linux.git branch name: rocev2_rc4 Thanks Som -Original Message- From: Bart Van Assche [mailto:bart.vanass...@sandisk.com] Sent: Thursday, February 19, 2015 1:47 PM To: Somnath Kotur;

Re: [PATCH RE-RESEND V2 for-next 3/5] IB/core: Call ib_unregister_mad_agent() only for valid agents

2015-02-19 Thread Majd Dibbiny
On 17/2/2015 3:59 PM, Yann Droneaud wrote: Hi, Le lundi 16 février 2015 à 22:28 +0100, Yann Droneaud a écrit : Le jeudi 05 février 2015 à 13:53 +0200, Or Gerlitz a écrit : From: Majd Dibbiny m...@mellanox.com In some error flows, ib_mad_unregister_agent is being invoked also in cases

RE: [PATCH] RDMA/ocrdma: Changes in driver to incorporate the moving of GID Table mgmt to IB/Core.

2015-02-19 Thread Shachar Raindel
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Somnath Kotur Sent: Friday, February 20, 2015 12:02 AM To: rol...@kernel.org Cc: linux-rdma@vger.kernel.org; Somnath Kotur; Devesh Sharma Subject: [PATCH] RDMA/ocrdma:

[PATCH v2 1/1] IB/mthca: remove deprecated use of pci api

2015-02-19 Thread Quentin Lambert
Replace occurences of the pci api by appropriate call to the dma api. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id,

Re: [PATCH 02/30] IB/core: Add kref to IB devices

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: From: Matan Barak mat...@mellanox.com Previously. we used device_mutex lock in order to protect the device's list. That means that in order to guarantee a device isn't freed while we use it, we had to lock all devices. Adding a kref per IB

Re: [PATCH 02/30] IB/core: Add kref to IB devices

2015-02-19 Thread Matan Barak
On Thu, Feb 19, 2015 at 12:57 PM, Haggai Eran hagg...@mellanox.com wrote: On 20/02/2015 00:02, Somnath Kotur wrote: From: Matan Barak mat...@mellanox.com Previously. we used device_mutex lock in order to protect the device's list. That means that in order to guarantee a device isn't freed

Re: [PATCH 08/30] IB/core: Support find sgid index using a filter function

2015-02-19 Thread Matan Barak
On 2/19/2015 2:41 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: @@ -111,6 +111,33 @@ int ib_find_cached_gid_by_port(struct ib_device *device, struct net *net, int if_index,

Re: [PATCH v1 1/3] IB/core: Add support for extended query device caps

2015-02-19 Thread Matan Barak
On Wed, Feb 18, 2015 at 9:26 AM, Haggai Eran hagg...@mellanox.com wrote: From: Eli Cohen e...@mellanox.com Add extensible query device capabilities verb to allow adding new features. ib_uverbs_ex_query_device is added and copy_query_dev_fields is used to copy capability fields to be used by

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Matan Barak
On 2/19/2015 2:52 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -2089,15 +2089,16 @@ ssize_t ib_uverbs_modify_qp(struct ib_uverbs_file *file, attr-alt_ah_attr.port_num =

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Or Gerlitz
On Thu, Feb 19, 2015 at 3:22 PM, Matan Barak mat...@mellanox.com wrote: On 2/19/2015 2:52 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -2089,15 +2089,16 @@ ssize_t

Re: [PATCH 08/30] IB/core: Support find sgid index using a filter function

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: @@ -111,6 +111,33 @@ int ib_find_cached_gid_by_port(struct ib_device *device, struct net *net, int if_index, u16 *index); + +/** +

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -2089,15 +2089,16 @@ ssize_t ib_uverbs_modify_qp(struct ib_uverbs_file *file, attr-alt_ah_attr.port_num = cmd.alt_dest.port_num; if

RE: [PATCH 30/30] IB/cma: Join and leave multicast groups with IGMP

2015-02-19 Thread Shachar Raindel
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Somnath Kotur Sent: Friday, February 20, 2015 12:03 AM To: rol...@kernel.org Cc: linux-rdma@vger.kernel.org; Moni Shoua; Somnath Kotur Subject: [PATCH 30/30] IB/cma:

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Matan Barak
On 2/19/2015 4:37 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: @@ -203,21 +235,30 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, memset(ah_attr, 0, sizeof *ah_attr); if (is_eth) { + u16 vlan_id =

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Matan Barak
On 2/19/2015 5:03 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: @@ -502,9 +547,7 @@ EXPORT_SYMBOL(ib_create_qp); static const struct { int valid; enum ib_qp_attr_maskreq_param[IB_QPT_MAX]; - enum ib_qp_attr_mask

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Matan Barak
On 2/19/2015 5:18 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -458,7 +458,7 @@ static void resolve_cb(int status, struct sockaddr *src_addr, } int rdma_addr_find_dmac_by_grh(union ib_gid

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/core/addr.c @@ -458,7 +458,7 @@ static void resolve_cb(int status, struct sockaddr *src_addr, } int rdma_addr_find_dmac_by_grh(union ib_gid *sgid, union ib_gid *dgid, u8 *dmac, -

Re: [PATCH v1 1/3] IB/core: Add support for extended query device caps

2015-02-19 Thread Jason Gunthorpe
On Thu, Feb 19, 2015 at 02:30:29PM +0200, Matan Barak wrote: I think we should all agree about the extension verbs mechanism before taking it further. IMHO, using comp_mask only for fields that their valid value != 0 is confusing. For example, an old kernel should support a command if: (a)

Re: [PATCH 10/30] IB/core: Add gid_type to path and rdma_id_private

2015-02-19 Thread Matan Barak
On 2/19/2015 5:51 PM, Haggai Eran wrote: On 20/02/2015 00:02, Somnath Kotur wrote: @@ -1521,6 +1520,8 @@ static int cm_req_handler(struct cm_work *work) struct ib_cm_id *cm_id; struct cm_id_private *cm_id_priv, *listen_cm_id_priv; struct cm_req_msg *req_msg; +

RE: [PATCH 29/30] IB/mlx4: Create and use another QP1 for RoCEv2

2015-02-19 Thread Shachar Raindel
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Somnath Kotur Sent: Friday, February 20, 2015 12:03 AM To: rol...@kernel.org Cc: linux-rdma@vger.kernel.org; Moni Shoua; Somnath Kotur Subject: [PATCH 29/30] IB/mlx4:

Re: [PATCH 10/30] IB/core: Add gid_type to path and rdma_id_private

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: @@ -1521,6 +1520,8 @@ static int cm_req_handler(struct cm_work *work) struct ib_cm_id *cm_id; struct cm_id_private *cm_id_priv, *listen_cm_id_priv; struct cm_req_msg *req_msg; + union ib_gid gid; + struct ib_gid_attr

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: @@ -203,21 +235,30 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, struct ib_wc *wc, memset(ah_attr, 0, sizeof *ah_attr); if (is_eth) { + u16 vlan_id = wc-wc_flags IB_WC_WITH_VLAN ? +

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-19 Thread Haggai Eran
On 20/02/2015 00:02, Somnath Kotur wrote: @@ -502,9 +547,7 @@ EXPORT_SYMBOL(ib_create_qp); static const struct { int valid; enum ib_qp_attr_maskreq_param[IB_QPT_MAX]; - enum ib_qp_attr_maskreq_param_add_eth[IB_QPT_MAX]; enum ib_qp_attr_mask