[PATCH] RDMA/ocrdma: Fix double free in ocrdma_alloc_pd()

2015-02-23 Thread Christian Engelmayer
Commit 9ba1377daa51 ("RDMA/ocrdma: Move PD resource management to driver.") modified the err exit path in function ocrdma_alloc_pd() so that a call of _ocrdma_dealloc_pd(dev, pd) is followed by kfree(pd). However, _ocrdma_dealloc_pd() already unconditionally frees argument pd. Thus remove the doubl

Re: [PATCH v4 14/19] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

2015-02-23 Thread Hal Rosenstock
On 2/17/2015 4:25 PM, Weiny, Ira wrote: > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index > 3ab4033..2614233 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -128,6 +128,10 @@ enum ib_device_cap_flags { > IB_DEVICE_ON_D

Re: [PATCH 9/9] IB/ipoib: drop mcast_mutex usage

2015-02-23 Thread Doug Ledford
On Mon, 2015-02-23 at 18:56 +0200, Or Gerlitz wrote: > On Sun, Feb 22, 2015 at 2:27 AM, Doug Ledford wrote: > > We needed the mcast_mutex when we had to prevent the join completion > > callback from having the value it stored in mcast->mc overwritten > > downstream patches of this series (7/9 and

RE: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-23 Thread Devesh Sharma
> -Original Message- > From: Matan Barak [mailto:mat...@mellanox.com] > Sent: Monday, February 23, 2015 3:47 PM > To: Devesh Sharma; Somnath Kotur; rol...@kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use > roce_gid_ca

Re: [PATCH 9/9] IB/ipoib: drop mcast_mutex usage

2015-02-23 Thread Or Gerlitz
On Sun, Feb 22, 2015 at 2:27 AM, Doug Ledford wrote: > We needed the mcast_mutex when we had to prevent the join completion > callback from having the value it stored in mcast->mc overwritten downstream patches of this series (7/9 and 8/9) make pretty much heavy usage of the mcast_mutex (e.g add/

Re: [PATCH 5/9] IB/ipoib: Use dedicated workqueues per interface

2015-02-23 Thread Or Gerlitz
On Sun, Feb 22, 2015 at 2:27 AM, Doug Ledford wrote: > @@ -236,12 +247,19 @@ out_free_send_cq: > out_free_recv_cq: > ib_destroy_cq(priv->recv_cq); > > +out_cm_dev_cleanup: > + ipoib_cm_dev_cleanup(dev); > + > +out_free_wq: > + destroy_workqueue(priv->wq); > + priv->wq =

[PATCH] IB/verbs: Check each operation of dma_ops individually

2015-02-23 Thread Yuval Shaia
Current approach force one to implement all ops even when some functions can use the default implementation. As a result, for new DMA ops (e.x new arch) many functions just wrap the default function. The fix is to check each DMA operation individually so one can leave empty the ones not need to

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-23 Thread Matan Barak
On 2/23/2015 12:32 PM, Somnath Kotur wrote: -Original Message- From: Matan Barak [mailto:mat...@mellanox.com] Sent: Monday, February 23, 2015 3:47 PM To: Devesh Sharma; Somnath Kotur; rol...@kernel.org Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 09/30] IB/core: Modify ib_verbs

Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-23 Thread Matan Barak
On 2/23/2015 7:25 AM, Devesh Sharma wrote: Hi Matan, Please find a comment inline below: -Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Somnath Kotur Sent: Friday, February 20, 2015 3:32 AM To: rol...@

RE: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use roce_gid_cache

2015-02-23 Thread Somnath Kotur
> -Original Message- > From: Matan Barak [mailto:mat...@mellanox.com] > Sent: Monday, February 23, 2015 3:47 PM > To: Devesh Sharma; Somnath Kotur; rol...@kernel.org > Cc: linux-rdma@vger.kernel.org > Subject: Re: [PATCH 09/30] IB/core: Modify ib_verbs and cma in order to use > roce_gid_c