[patch] RDMA/nes: remove a stray indent

2015-02-25 Thread Dan Carpenter
This line was indented two tabs too far so it looks weird. Signed-off-by: Dan Carpenter diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 70acda9..1f74ae2 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b/drivers/infiniband/hw/nes/nes_nic.c @@ -92

Re: [PATCH v4 14/19] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

2015-02-25 Thread Doug Ledford
On Wed, 2015-02-25 at 00:29 +, Weiny, Ira wrote: > > >>> > > >>> Do you have a suggestion for alternatives? > > >> > > >> The desire to leverage the IB MAD infrastructure for OPA is > > >> understood but the current approach represents OPA as a device > > >> capability which does not seem appro

RE: [PATCH v4 06/19] IB/core: Add max_mad_size to ib_device_attr

2015-02-25 Thread Weiny, Ira
> > diff --git a/drivers/infiniband/core/mad.c > > b/drivers/infiniband/core/mad.c index 819b794..a6a33cf 100644 > > --- a/drivers/infiniband/core/mad.c > > +++ b/drivers/infiniband/core/mad.c > > @@ -2924,6 +2924,12 @@ static int ib_mad_port_open(struct ib_device > *device, > > char name[sizeo

Re: [PATCH v4 06/19] IB/core: Add max_mad_size to ib_device_attr

2015-02-25 Thread Jason Gunthorpe
On Wed, Feb 25, 2015 at 06:13:35PM +, Weiny, Ira wrote: > > > diff --git a/drivers/infiniband/core/mad.c > > > b/drivers/infiniband/core/mad.c index 819b794..a6a33cf 100644 > > > +++ b/drivers/infiniband/core/mad.c > > > @@ -2924,6 +2924,12 @@ static int ib_mad_port_open(struct ib_device > > *d

RE: [PATCH v4 07/19] IB/mad: Convert ib_mad_private allocations from kmem_cache to kmalloc

2015-02-25 Thread Weiny, Ira
> > > > +static struct ib_mad_private *alloc_mad_priv(struct ib_device *dev) { > > + return (kmalloc(sizeof(struct ib_mad_private_header) + > > + sizeof(struct ib_grh) + > > + dev->cached_dev_attrs.max_mad_size, > GFP_ATOMIC)); > > Ouch! GFP_ATOMIC? I though

RE: [PATCH v4 06/19] IB/core: Add max_mad_size to ib_device_attr

2015-02-25 Thread Weiny, Ira
> > > > Fixed for v5 with this message. > > > > + dev_err(&device->dev, > > + "Max supported MAD size (%u) < min required by > > ib_mad > (%u), ignoring device (%s)\n", > > + device->cached_dev_attrs.max_mad_size, > > +

Re: [PATCH v4 06/19] IB/core: Add max_mad_size to ib_device_attr

2015-02-25 Thread Jason Gunthorpe
On Wed, Feb 25, 2015 at 06:32:27PM +, Weiny, Ira wrote: > > > > > > Fixed for v5 with this message. > > > > > > + dev_err(&device->dev, > > > + "Max supported MAD size (%u) < min required by > > > ib_mad > > (%u), ignoring device (%s)\n", > > > +