re: RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter

2015-02-26 Thread Dan Carpenter
Hello Parav Pandit, The patch fe2caefcdf58: "RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter" from Mar 21, 2012, leads to the following static checker warning: drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:1426 _ocrdma_modify_qp() warn: bool is not less than zero. d

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-02-26 Thread Erez Shitrit
On 2/22/2015 2:26 AM, Doug Ledford wrote: Create a an ipoib_flush_ah and ipoib_stop_ah routines to use at appropriate times to flush out all remaining ah entries before we shut the device down. Because neighbors and mcast entries can each have a reference on any given ah, we must make sure to fr

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-02-26 Thread Doug Ledford
On Thu, 2015-02-26 at 15:28 +0200, Erez Shitrit wrote: > On 2/22/2015 2:26 AM, Doug Ledford wrote: > > Create a an ipoib_flush_ah and ipoib_stop_ah routines to use at > > appropriate times to flush out all remaining ah entries before we shut > > the device down. > > > > Because neighbors and mcast

RE: RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter

2015-02-26 Thread Devesh Sharma
Thanks Dan for pointing out, we will address this issue and send out a patch to fix this. -Regards Devesh > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Dan Carpenter > Sent: Thursday, February 26, 2015 6:00 PM > To

[PATCH] net: ethernet: mellanox: correct page conversion

2015-02-26 Thread timur
From: Sinan Kaya Current code is assuming that the addresses returned by dma_alloc_coherent is a logical address. This is not true on ARM/ARM64 systems. This patch uses dma_to_phys API to reach to the actual physical address and then convert to the page pointer. Signed-off-by: Sinan Kaya --- d

[patch] IB/ipath: remove some left over code

2015-02-26 Thread Dan Carpenter
"ret" is always zero here after commit c4bce8032ef4 ('IB/ipath: Add new chip-specific functions to older chips, consistent init'). Signed-off-by: Dan Carpenter --- I just happened to spot this dead code when I was reviewing a different static checker warning: drivers/infiniband/hw/ipath/