[PATCH v2] IB/ipatch: Use setup_timer and mod_timer

2015-03-03 Thread Vaishali Thakkar
Use timer API functions setup_timer and mod_timer instead of structure assignments as they are standard way to set the timer and to update the expire field of an active timer respectively. This is done using Coccinelle and semantic patch used for this is as follows: // @@ expression x,y,z,a,b; @

RE: [PATCH v4 14/19] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

2015-03-03 Thread Weiny, Ira
Doug, You have given me a lot to think about... Comments below... > > > > > > > > While it is a different type of technology, standard verbs[*] > > > > remains 100% > > > compatible. Unlike other verbs technologies user space software > > > does not need any knowledge that the underlying device

[ANNOUNCE] libibumad 1.3.10.2 release

2015-03-03 Thread Hal Rosenstock
There is a new 1.3.10.2 release of libibumad. Tarball is available in: http://www.openfabrics.org/downloads/management/ (listed in http://www.openfabrics.org/downloads/management/latest.txt) md5sum: dd017844c55713bd335aa229e6841d41 libibumad-1.3.10.2.tar.gz All component versions are from recen

RE: [PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration

2015-03-03 Thread Weiny, Ira
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Hal Rosenstock > Sent: Tuesday, March 03, 2015 12:23 PM > To: linux-rdma (linux-rdma@vger.kernel.org) > Cc: Weiny, Ira; ra...@mellanox.com > Subject: [PATCH libibumad] uma

[PATCH libibumad] umad.h: Remove umad_reg_flags from enum declaration

2015-03-03 Thread Hal Rosenstock
This causes it to be a global variable which causes linking issues when used by multiple files linked together. It results in multiple definition of `umad_reg_flags'. Found-by: Rafi Weiner Signed-off-by: Hal Rosenstock --- diff --git a/include/infiniband/umad.h b/include/infiniband/umad.h inde

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-03-03 Thread Erez Shitrit
On 3/2/2015 5:09 PM, Doug Ledford wrote: On Sun, 2015-03-01 at 08:47 +0200, Erez Shitrit wrote: On 2/26/2015 6:27 PM, Doug Ledford wrote: @@ -1037,6 +1038,7 @@ static void __ipoib_ib_dev_flush(struct ipoib_dev_priv *priv, if (level == IPOIB_FLUSH_LIGHT) { ipoib_mark_pat

Re: [PATCH 8/9] IB/ipoib: deserialize multicast joins

2015-03-03 Thread Erez Shitrit
On 3/2/2015 5:29 PM, Doug Ledford wrote: On Sun, 2015-03-01 at 15:58 +0200, Erez Shitrit wrote: On 2/22/2015 2:27 AM, Doug Ledford wrote: Allow the ipoib layer to attempt to join all outstanding multicast groups at once. The ib_sa layer will serialize multiple attempts to join the same group,

Re: [PATCH 7/9] IB/ipoib: fix MCAST_FLAG_BUSY usage

2015-03-03 Thread Erez Shitrit
On 3/2/2015 5:27 PM, Doug Ledford wrote: On Sun, 2015-03-01 at 11:31 +0200, Erez Shitrit wrote: On 2/22/2015 2:27 AM, Doug Ledford wrote: Commit a9c8ba5884 ("IPoIB: Fix usage of uninitialized multicast objects") added a new flag MCAST_JOIN_STARTED, but was not very strict in how it was used. W