RE: [PATCH v4 14/19] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

2015-03-16 Thread Hefty, Sean
or management application. Agreed, but _only_ when talking to the hardware. Other MAD interfaces are IB compatible. Maybe this is what Ira is thinking, and just not explaining very well. But it makes sense to me to use management specific fields/attributes/flags for the *management*

RE: [patch] IB/ipath: remove some left over code

2015-03-16 Thread Marciniszyn, Mike
Subject: [patch] IB/ipath: remove some left over code Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v1 12/16] xprtrdma: Acquire FMRs in rpcrdma_fmr_register_external()

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:28 PM, Chuck Lever wrote: Acquiring 64 FMRs in rpcrdma_buffer_get() while holding the buffer pool lock is expensive, and unnecessary because FMR mode can transfer up to a 1MB payload using just a single ib_fmr. Instead, acquire ib_fmrs one-at-a-time as chunks are registered, and

Re: [PATCH v1 04/16] xprtrdma: Add a max_payload op for each memreg mode

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:27 PM, Chuck Lever wrote: The max_payload computation is generalized to ensure that the payload maximum is the lesser of RPC_MAX_DATA_SEGS and the number of data segments that can be transmitted in an inline buffer. Signed-off-by: Chuck Lever chuck.le...@oracle.com ---

Re: [PATCH v1 06/16] xprtrdma: Add a deregister_external op for each memreg mode

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory deregistration functions. In addition, instead of calling the deregistration function for each segment, have one call release all segments for a request. This makes the API a

Re: [PATCH v1 09/16] xprtrdma: Add destroy MRs memreg op

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:27 PM, Chuck Lever wrote: Memory Region objects associated with a transport instance are destroyed before the instance is shutdown and destroyed. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/fmr_ops.c | 21 +++

Re: [PATCH v1 13/16] xprtrdma: Acquire MRs in rpcrdma_register_external()

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:28 PM, Chuck Lever wrote: Acquiring 64 MRs in rpcrdma_buffer_get() while holding the buffer pool lock is expensive, and unnecessary because most modern adapters can transfer 100s of KBs of payload using just a single MR. Instead, acquire MRs one-at-a-time as chunks are

Re: [PATCH v1 15/16] xprtrdma: Make rpcrdma_{un}map_one() into inline functions

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:28 PM, Chuck Lever wrote: These functions are called in a loop for each page transferred via RDMA READ or WRITE. Extract loop invariants and inline them to reduce CPU overhead. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/fmr_ops.c | 10

Re: [PATCH v1 14/16] xprtrdma: Remove rpcrdma_ia::ri_memreg_strategy

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:28 PM, Chuck Lever wrote: Clean up: This field is no longer used. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- include/linux/sunrpc/xprtrdma.h |3 ++- net/sunrpc/xprtrdma/verbs.c |3 --- net/sunrpc/xprtrdma/xprt_rdma.h |1 - 3 files changed, 2

Re: [PATCH v1 05/16] xprtrdma: Add a register_external op for each memreg mode

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory registration functions. Have rpcrdma_create_chunks() call the registration method directly. This removes a stack frame and a switch statement from the external registration path.

Re: [PATCH v1 11/16] xprtrdma: Handle non-SEND completions via a callout

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:28 PM, Chuck Lever wrote: Allow each memory registration mode to plug in a callout that handles the completion of a memory registration operation. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/frwr_ops.c | 17 +

Re: [PATCH v1 08/16] xprtrdma: Add reset MRs memreg op

2015-03-16 Thread Sagi Grimberg
On 3/13/2015 11:27 PM, Chuck Lever wrote: This method is invoked when a transport instance is about to be reconnected. Each Memory Region object is reset to its initial state. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/fmr_ops.c | 23

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-03-16 Thread Erez Shitrit
On 3/15/2015 8:42 PM, Doug Ledford wrote: On Mar 13, 2015, at 1:39 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Tue, Mar 3, 2015 at 11:59 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: On 3/2/2015 5:09 PM, Doug Ledford wrote: On Sun, 2015-03-01 at 08:47 +0200, Erez Shitrit wrote: On

Re: [PATCH v1 09/16] xprtrdma: Add destroy MRs memreg op

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 3:46 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: Memory Region objects associated with a transport instance are destroyed before the instance is shutdown and destroyed. Signed-off-by: Chuck Lever chuck.le...@oracle.com

Re: [PATCH v1 05/16] xprtrdma: Add a register_external op for each memreg mode

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 3:28 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory registration functions. Have rpcrdma_create_chunks() call the registration method directly. This

Re: [PATCH v1 06/16] xprtrdma: Add a deregister_external op for each memreg mode

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 3:34 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory deregistration functions. In addition, instead of calling the deregistration function for each

Re: [PATCH v1 12/16] xprtrdma: Acquire FMRs in rpcrdma_fmr_register_external()

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 5:28 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:28 PM, Chuck Lever wrote: Acquiring 64 FMRs in rpcrdma_buffer_get() while holding the buffer pool lock is expensive, and unnecessary because FMR mode can transfer up to a 1MB payload using just a

Re: [PATCH v1 01/16] xprtrdma: Display IPv6 addresses and port numbers correctly

2015-03-16 Thread Chuck Lever
On Mar 14, 2015, at 7:50 PM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:26 PM, Chuck Lever wrote: Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/transport.c | 47 --- net/sunrpc/xprtrdma/verbs.c |

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-03-16 Thread Erez Shitrit
On 3/16/2015 6:06 PM, Doug Ledford wrote: On Mar 16, 2015, at 8:24 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: On 3/15/2015 8:42 PM, Doug Ledford wrote: Doug, ten days and no response from you... lets finalize the review on this series so we have it safely done for 4.1 -- on top of it

Re: [PATCH 1/9] IB/ipoib: factor out ah flushing

2015-03-16 Thread Doug Ledford
On Mar 16, 2015, at 8:24 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: On 3/15/2015 8:42 PM, Doug Ledford wrote: Doug, ten days and no response from you... lets finalize the review on this series so we have it safely done for 4.1 -- on top of it Erez prepares a set of IPoIB fixes

Re: [PATCH v1 05/16] xprtrdma: Add a register_external op for each memreg mode

2015-03-16 Thread Sagi Grimberg
On 3/16/2015 6:48 PM, Chuck Lever wrote: On Mar 16, 2015, at 3:28 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory registration functions. Have rpcrdma_create_chunks() call

[PATCH] infiniband/mlx4: check for mapping error

2015-03-16 Thread Sebastian Ott
Since ib_dma_map_single can fail use ib_dma_mapping_error to check for errors. Signed-off-by: Sebastian Ott seb...@linux.vnet.ibm.com --- drivers/infiniband/hw/mlx4/mad.c |9 + drivers/infiniband/hw/mlx4/qp.c |4 2 files changed, 13 insertions(+) ---

Re: [PATCH v1 13/16] xprtrdma: Acquire MRs in rpcrdma_register_external()

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 5:44 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:28 PM, Chuck Lever wrote: Acquiring 64 MRs in rpcrdma_buffer_get() while holding the buffer pool lock is expensive, and unnecessary because most modern adapters can transfer 100s of KBs of payload

[PATCH opensm] osm_sa_mcmember_record.c: Extend P_Pkey validation on MCMemberRecord(Join)

2015-03-16 Thread Hal Rosenstock
From: Daniel Klein dani...@mellanox.com Verify that a port that joins a multicast group is in the partition for that MC group. Signed-off-by: Daniel Klein dani...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- opensm/osm_sa_mcmember_record.c | 18 ++ 1 files

Re: [PATCH v1 05/16] xprtrdma: Add a register_external op for each memreg mode

2015-03-16 Thread Chuck Lever
On Mar 16, 2015, at 1:13 PM, Steve Wise sw...@opengridcomputing.com wrote: On 3/16/2015 1:15 PM, Sagi Grimberg wrote: On 3/16/2015 6:48 PM, Chuck Lever wrote: On Mar 16, 2015, at 3:28 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: There is

[PATCH 0/2] infiniband-diags/rdma-ndd: Fix install/start up script

2015-03-16 Thread ira . weiny
From: Ira Weiny ira.we...@intel.com Fix the following issues reported by Dan: 1. I found an issue with the /etc/init.d/rdma-ndd script. The “stop” option (e.g. /etc/init.d/rdma-ndd stop) doesn’t kill the rdma-ndd. The problem is that the rdma-ndd doesn’t creates pidfile. Just

[PATCH 2/2] infiniband-diags/rdma-ndd: add --pidfile option

2015-03-16 Thread ira . weiny
From: Ira Weiny ira.we...@intel.com rdma-ndd start up script works better with a pidfile. This was partially implemented in the start up script and not at all in the daemon. Fully implement this. Reported-by: Dan Ben Yosef da...@mellanox.com Signed-off-by: Ira Weiny ira.we...@intel.com ---

Re: [PATCH v1 05/16] xprtrdma: Add a register_external op for each memreg mode

2015-03-16 Thread Steve Wise
On 3/16/2015 1:15 PM, Sagi Grimberg wrote: On 3/16/2015 6:48 PM, Chuck Lever wrote: On Mar 16, 2015, at 3:28 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 3/13/2015 11:27 PM, Chuck Lever wrote: There is very little common processing among the different external memory registration