On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the time is right to just remove the iPath driver?
With PAT now
So, I think that our old-transport below is just fine.
No need to change it (and you aren't, since it is currently implemented
as a function).
I think there is a need to change this. Encoding the transport into the
node
type is not a good idea. Having different transport semantics
On Wed, 2015-04-22 at 15:21 +, Devesh Sharma wrote:
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Doug Ledford
Sent: Wednesday, April 22, 2015 8:33 PM
To: Michael Wang
Cc: Roland Dreier; Sean Hefty;
On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote:
On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
Introduce helper cap_ipoib() to help us check if the port of an
IB device support IP over Infiniband.
I
On Wed, Apr 22, 2015 at 11:38:34AM +, Liran Liss wrote:
This is redundant. All IB ports have SMI, so if you know that you
are using an IB device, you know you have an SMI.
You should really go back and read the whole thread, this has already
been discussed.
The patch set was developed
On Wed, Apr 22, 2015 at 10:17:55AM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the
From: Michael Wang [mailto:yun.w...@profitbricks.com]
Hi, Liran
Thanks for the comment :-)
On 04/22/2015 01:36 AM, Liran Liss wrote:
[snip]
(**) This has been extended to also encode the transport in the current
code.
At least for user-space visible APIs, we might chose to leave
On Wed, Apr 22, 2015 at 03:21:43PM +, Devesh Sharma wrote:
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Doug Ledford
Sent: Wednesday, April 22, 2015 8:33 PM
To: Michael Wang
Cc: Roland Dreier; Sean Hefty;
On Wed, Apr 22, 2015 at 09:38:57AM +0200, Michael Wang wrote:
Hi, Ira
Thanks for the review :-)
On 04/22/2015 01:19 AM, ira.weiny wrote:
[snip]
diff --git a/drivers/infiniband/core/sysfs.c
b/drivers/infiniband/core/sysfs.c
index cbd0383..8570180 100644
---
On Wed, Apr 22, 2015 at 8:23 AM, Luis R. Rodriguez mcg...@suse.com wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the time is right to just remove the iPath driver?
With PAT now
On Tue, Apr 21, 2015 at 08:15:12AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu Apr 16 16:39:43 2015 +0300
sa_free_handle function is not called at the end of
path_record_query function.
The patch fixes file descriptor leak when path_record_query
On Tue, 2015-04-21 at 23:36 +, Liran Liss wrote:
Hi Michael,
The spirit of this patch-set is great, but I think that we need to clarify
some concepts.
Since this will affect the whole patch-set, I am laying out my concerns here
instead.
A suggestion for the resulting management
On Wed, Apr 22, 2015 at 09:44:52AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
From: Luis R. Rodriguez mcg...@suse.com
There is no good reason not to, we eventually delete it as well.
Cc: Toshi Kani toshi.k...@hp.com
Cc: Suresh Siddha
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
From: Luis R. Rodriguez mcg...@suse.com
There is no good reason not to, we eventually delete it as well.
Cc: Toshi Kani toshi.k...@hp.com
Cc: Suresh Siddha sbsid...@gmail.com
Cc: Ingo Molnar mi...@elte.hu
Cc: Thomas Gleixner
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if this is non-zero */
+ if (!dd-wc_cookie)
vma-vm_page_prot = pgprot_writecombine(vma-vm_page_prot);
And this:
+ dd-wc_cookie = arch_phys_wc_add(pioaddr, piolen);
+
On Thu, Apr 16, 2015 at 09:22:28AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Tue, 14 Apr 2015 18:14:48 +0300
Additional file descriptor for SMP MADs should be closed before running
ibnd_discover_fabric() to avoid parallel usage of two SMP file
On Thu, 2015-04-16 at 16:18 -0600, Jason Gunthorpe wrote:
On Thu, Apr 16, 2015 at 06:03:19PM -0400, Doug Ledford wrote:
AFAIK, capturing provided tags is considered best practice as a way to
recognize and retain contributors.
Agreed. I'll double check them tomorrow.
These are two I
On Tue, Apr 21, 2015 at 08:15:03AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu, 16 Apr 2015 16:29:43 +0300
Global file descriptor for SMPs and GMPs should be closed before running
ibnd_discover_fabric() to avoid parallel usage of two SMP file
On Tue, Apr 21, 2015 at 08:15:12AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu Apr 16 16:39:43 2015 +0300
sa_free_handle function is not called at the end of
path_record_query function.
The patch fixes file descriptor leak when path_record_query
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if this is non-zero */
+ if (!dd-wc_cookie)
vma-vm_page_prot = pgprot_writecombine(vma-vm_page_prot);
And this:
+
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the time is right to just remove the iPath driver?
With PAT now
On Wed, Apr 22, 2015 at 8:54 AM, Luis R. Rodriguez mcg...@suse.com wrote:
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you
On Tue, Apr 21, 2015 at 08:15:19AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu, 16 Apr 2015 16:56:40 +0300
Global file descriptor for SMPs should be opened only after running
ibnd_discover_fabric() to avoid parallel usage of two SMP file descriptors
On Thu, Apr 16, 2015 at 10:26:24AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu, 16 Apr 2015 14:11:16 +0300
Today, process_one_recv calls umad_recv with zero timeout.
That means umad_recv will use non-blocking read() without polling,
In many cases,
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the time is right to just remove the iPath driver?
With PAT now being default the driver effectively won't work
with write-combining on
On Tue, Apr 21, 2015 at 10:01:48AM -0400, Hal Rosenstock wrote:
From: Vladimir Koushnir vladim...@mellanox.com
Date: Thu, 16 Apr 2015 18:27:39 +0300
Call mad_rpc_close_port in all corner cases.
This is needed so fds are not leaked with ibsim.
Signed-off-by: Vladimir Koushnir
From: Ilya Nelkenbaum il...@mellanox.com
In old glibc versions ( 2.9.90) it is not defined
Signed-off-by: Ilya Nelkenbaum il...@mellanox.com
---
ibsim/sim_cmd.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/ibsim/sim_cmd.c b/ibsim/sim_cmd.c
index 4822a0b..249228a 100644
---
On Wed, Apr 22, 2015 at 10:59:52AM -0400, Doug Ledford wrote:
2)The name rdma_tech_* is lame.
rdma_transport_*(), adhering to the above (*) remark, is much better.
For example, both IB and ROCE *do* use the same transport.
I especially want to second this. I haven't really been happy
On Wed, Apr 22, 2015 at 10:59:52AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 23:36 +, Liran Liss wrote:
[snip]
2)The name rdma_tech_* is lame.
rdma_transport_*(), adhering to the above (*) remark, is much better.
For example, both IB and ROCE *do* use the same transport.
On Wed, Apr 22, 2015 at 7:43 AM, Doug Ledford dledf...@redhat.com wrote:
New items since the last push:
Jason's fix to the CMA for IPv4/IPv6 canonization
Hariprasad's series to iw_cxgb4
Tatyana's and Steve's series for iWARP portmapper address resolution
I just sent the previous batch, since
On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote:
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if
On Wed, 2015-04-22 at 19:37 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote:
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R.
On Tue, Apr 21, 2015 at 01:15:11PM +0300, Haggai Eran wrote:
That's correct. We didn't address it because it was part of the existing
code. Anyway, in a later patch in this series we move this code from the
CMA to the CM module.
Just so we are all on the same page in the future:
- Don't half
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 09:54:38AM -0400, Doug Ledford wrote:
On Tue, 2015-04-21 at 14:50 -0700, Luis R. Rodriguez wrote:
This:
+ /* MTRR was used if this is non-zero */
+ if (!dd-wc_cookie)
vma-vm_page_prot =
Hi Linus,
Please pull from
git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git
tags/rdma-for-linus
InfiniBand/RDMA updates for 4.1:
- IPoIB fixes from Doug Ledford and Erez Shitrit
- iSER updates from Sagi
On Wed, Apr 22, 2015 at 10:49:44AM +0200, Michael Wang wrote:
On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
Introduce helper cap_ipoib() to help us check if the port of an
IB device support IP over Infiniband.
I
On Apr 21, 2015, at 6:36 PM, Liran Liss lir...@mellanox.com wrote:
An ib_dev (or a port of) should be distinguished by 3 qualifiers:
- The link layer:
-- Ethernet (shared by iWARP, USNIC, and ROCE)
-- Infiniband
- The transport (*)
-- IBTA transport (shared by IB and ROCE)
-- iWARP
I thought we were dropping this in favor of listing the actual
features the ULP required unconditionally? One of my messages had the
start of a list..
??? I forget. I was arguing that we should not have it. But I thought
others
disagreed with me so it was left in.
I don't
On Wed, Apr 22, 2015 at 09:53:03AM -0700, Andy Lutomirski wrote:
On Wed, Apr 22, 2015 at 8:23 AM, Luis R. Rodriguez mcg...@suse.com wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think
On Wed, 2015-04-22 at 10:10 -0700, Roland Dreier wrote:
On Wed, Apr 22, 2015 at 7:43 AM, Doug Ledford dledf...@redhat.com wrote:
New items since the last push:
Jason's fix to the CMA for IPv4/IPv6 canonization
Hariprasad's series to iw_cxgb4
Tatyana's and Steve's series for iWARP
On Wed, Apr 22, 2015 at 01:48:27PM -0400, Doug Ledford wrote:
On Wed, 2015-04-22 at 19:37 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 12:57:18PM -0400, Doug Ledford wrote:
On Wed, 2015-04-22 at 17:33 +0200, Luis R. Rodriguez wrote:
On Wed, Apr 22, 2015 at 09:54:38AM -0400,
On Wed, 2015-04-22 at 10:17 -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote:
Mike, do you think the time is
From: Luis R. Rodriguez mcg...@suse.com
This driver already makes use of ioremap_wc() on PIO buffers,
so convert it to use arch_phys_wc_add().
The qib driver uses a mmap() special case for when PAT is
not used, this behaviour used to be determined with a
module parameter but since we have been
On Wed, Apr 22, 2015 at 02:53:11PM -0400, Doug Ledford wrote:
On Wed, 2015-04-22 at 10:17 -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote:
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 01:39:07AM
On Wed, 2015-04-22 at 21:05 +0200, Luis R. Rodriguez wrote:
I'd also love to remove the driver if it turns out there are actually
no users. qib substantially replaces it except for a few very old
cards.
To be precise, the split is that ipath powers the old HTX bus cards that
only
On Thu, 2015-04-16 at 16:11 +0300, Guy Shapiro wrote:
This patchset contains small changes that improve the performance of memory
map updates.
The patches reduce the execution time of ib_umem_odp_unmap_dma_pages when
invalidating 4MB of memory from 46us to 13us. This amounts to a reduction
On Wed, Apr 22, 2015 at 12:10 PM, Doug Ledford dledf...@redhat.com wrote:
On Wed, 2015-04-22 at 21:05 +0200, Luis R. Rodriguez wrote:
I'd also love to remove the driver if it turns out there are actually
no users. qib substantially replaces it except for a few very old
cards.
To be
From: Luis R. Rodriguez mcg...@suse.com
We are burrying direct access to MTRR code support on
x86 in order to take advantage of PAT. In the future we
also want to make the default behaviour of ioremap_nocache()
to use strong UC, use of mtrr_add() on those systems
would make write-combining void.
On Wed, Apr 22, 2015 at 02:53:11PM -0400, Doug Ledford wrote:
To be precise, the split is that ipath powers the old HTX bus cards that
only work in AMD systems, qib is all PCI-e cards. I still have a few
HTX cards, but I no longer have any systems with HTX slots, so we
haven't even used this
On Wed, 2015-04-22 at 14:46 -0600, Jason Gunthorpe wrote:
On Wed, Apr 22, 2015 at 02:53:11PM -0400, Doug Ledford wrote:
To be precise, the split is that ipath powers the old HTX bus cards that
only work in AMD systems, qib is all PCI-e cards. I still have a few
HTX cards, but I no longer
On 04/22/2015 04:41 AM, ira.weiny wrote:
[snip]
5) Do no modify phys_state_show() in [PATCH v5 09/27] IB/Verbs: Reform
IB-core verbs/uverbs_cmd/sysfs
It *is* the link layer!
I agree with this. When the Link Layer is directly being requested we should
report the link layer. However,
On 04/22/2015 02:28 AM, ira.weiny wrote:
[snip]
Highlights:
The patch set covered a wide range of IB stuff, thus for those who are
familiar with the particular part, your suggestion would be invaluable
;-)
Patch 1#~15# included all the logical reform, 16#~25# introduced the
Hi, Ira
Thanks for the review :-)
On 04/22/2015 01:19 AM, ira.weiny wrote:
[snip]
diff --git a/drivers/infiniband/core/sysfs.c
b/drivers/infiniband/core/sysfs.c
index cbd0383..8570180 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -248,14 +248,10 @@
Hi, Liran
Thanks for the comment :-)
On 04/22/2015 01:36 AM, Liran Liss wrote:
[snip]
(**) This has been extended to also encode the transport in the current code.
At least for user-space visible APIs, we might chose to leave this for
backward compatibility, but we can consider cleaning up
On Tuesday, April 21, 2015 1:15 PM, Haggai Eran hagg...@mellanox.com wrote:
On 20/04/2015 23:01, Jason Gunthorpe wrote:
This should take care of it, testing, and figuring the fixes tag is
left as an exercise to the reader..
Fixes: e51060f08a61 (IB: IP address based RDMA connection manager)
On 4/22/2015 2:21 AM, Ilya Nelkenbaum wrote:
From: Ilya Nelkenbaum il...@mellanox.com
In old glibc versions ( 2.9.90) it is not defined
Signed-off-by: Ilya Nelkenbaum il...@mellanox.com
Thanks. Applied.
-- Hal
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the
On 04/22/2015 07:40 AM, Jason Gunthorpe wrote:
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote:
Introduce helper cap_ipoib() to help us check if the port of an
IB device support IP over Infiniband.
I thought we were dropping this in favor of listing the actual
features the
57 matches
Mail list logo
